Skip to content

Commit e97b4e4

Browse files
authored
fix(reports): remove superseded Storybook catalogue links from Conloca report (#8)
* fix(reports): remove superseded Storybook catalogue links from Conloca report (Refs #6) * test(reports): scan whole page text for rejected catalogue links and claims (Refs #6) * test(reports): also scan raw page text including script-rendered links (Refs #6)
1 parent e69a95b commit e97b4e4

3 files changed

Lines changed: 68 additions & 54 deletions

File tree

‎reports/2026-10-own-results-evidence.json‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,8 @@
345345
"url": "https://github.com/conloca/private/pull/509"
346346
}
347347
],
348+
"status": "historical",
349+
"historicalNote": "Receipts of an earlier catalogue publication on 5 November 2026. Superseded and not linked from the human reports.",
348350
"segments": [
349351
{
350352
"segment": "main",

‎reports/conloca-2026-10/index.html‎

Lines changed: 8 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ <h3>Storybook and browser coverage</h3>
187187
</div>
188188
</section>
189189
<section class="report-section" id="approval">
190-
<h2>Ready for approval</h2>
190+
<h2>Theme picker preview</h2>
191191
<p class="refs">
192192
Current preview, 5 November. Separate from the October merges above.
193193
</p>
@@ -197,7 +197,7 @@ <h3>Documentation theme picker</h3>
197197
<p>
198198
Added Light, Dark and System controls with visible selection,
199199
keyboard navigation and touch targets. Current-head CI and
200-
deployed-stage E2E passed; the implementation awaits team approval.
200+
deployed-stage E2E passed; the change awaits team review.
201201
</p>
202202
<p class="refs">
203203
<a
@@ -253,54 +253,13 @@ <h2>Before / after</h2>
253253
</div>
254254
</section>
255255
<section class="report-section" id="checks">
256-
<h2>Checks and previews</h2>
257-
<p>
258-
<strong>Protected Storybook:</strong>
259-
<a
260-
href="https://pages.hyperide.ai/alex-mextner/conloca-storybook-previews/main/"
261-
>Main</a
262-
>
263-
·
264-
<a
265-
href="https://pages.hyperide.ai/alex-mextner/conloca-storybook-previews/pr-404/"
266-
>Publisher preview #404</a
267-
>
268-
·
269-
<a
270-
href="https://pages.hyperide.ai/alex-mextner/conloca-storybook-previews/pr-489/"
271-
>Theme-picker preview #489</a
272-
>. Forge sign-in is required.
273-
</p>
274-
<p>
275-
Published these catalogue snapshots and added their links to PR
276-
descriptions. The publisher and automatic link refresh are implemented
277-
in
278-
<a
279-
href="https://github.com/conloca/private/pull/404"
280-
aria-label="Pull request 404"
281-
>#404</a
282-
>
283-
and
284-
<a
285-
href="https://github.com/conloca/private/pull/509"
286-
aria-label="Pull request 509"
287-
>#509</a
288-
>; both await merge approval.
289-
</p>
290-
<p class="refs">
291-
<a
292-
href="https://github.com/conloca/private/actions/runs/42052900149/job/127344610560"
293-
>Publisher deployed-stage E2E</a
294-
>. PR #404 includes the sandbox-path fix for prefixed catalogues; Main
295-
tracks the merged branch.
296-
</p>
256+
<h2>Checks</h2>
297257
<p>
298258
<a href="https://github.com/conloca/private/actions/runs/40534284367"
299259
>How it works: production deployment and E2E</a
300260
>
301261
·
302-
<a
303-
href="https://github.com/conloca/private/pull/244"
262+
<a href="https://github.com/conloca/private/pull/244"
304263
>Interactive Storybook scenarios and screenshot workflow</a
305264
>
306265
·
@@ -311,7 +270,7 @@ <h2>Checks and previews</h2>
311270
</p>
312271
</section>
313272
<footer>
314-
October 2026 · Ultra / Mextner · Updated 5 November 2026 ·
273+
October 2026 · Ultra / Mextner · Updated 6 November 2026 ·
315274
<a href="../2026-10-own-results-evidence.json">Source record</a>
316275
</footer>
317276
</main>
@@ -323,12 +282,12 @@ <h2>Checks and previews</h2>
323282
title: "Conloca: October 2026",
324283
subtitle:
325284
"Editor fixes, safe writes, visual coverage and the production landing update",
326-
date: "2026-11-05",
285+
date: "2026-11-06",
327286
badge: { label: "October results", type: "feat" },
328287
links: [
329288
{ label: "Merged changes", href: "#results" },
330-
{ label: "Ready for approval", href: "#approval" },
331-
{ label: "Checks and previews", href: "#checks" },
289+
{ label: "Theme picker", href: "#approval" },
290+
{ label: "Checks", href: "#checks" },
332291
],
333292
});
334293
</script>

‎scripts/ci/check-own-results.py‎

Lines changed: 58 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,39 @@ def handle_starttag(self, tag, attrs):
1616
self.urls.append(dict(attrs).get("href", ""))
1717

1818

19+
class VisibleText(HTMLParser):
20+
def __init__(self, text):
21+
super().__init__()
22+
self.parts = []
23+
self.skip = 0
24+
self.feed(text)
25+
26+
def handle_starttag(self, tag, attrs):
27+
if tag in ("script", "style"):
28+
self.skip += 1
29+
30+
def handle_endtag(self, tag):
31+
if tag in ("script", "style"):
32+
self.skip -= 1
33+
34+
def handle_data(self, data):
35+
if not self.skip:
36+
self.parts.append(data)
37+
38+
@property
39+
def text(self):
40+
return " ".join(" ".join(self.parts).split()).casefold()
41+
42+
43+
REJECTED_CLAIMS = [
44+
"protected storybook",
45+
"ready for approval",
46+
"catalogue snapshots",
47+
"publisher deployed-stage e2e",
48+
"automatic link refresh",
49+
]
50+
51+
1952
class ReportContract(unittest.TestCase):
2053
def setUp(self):
2154
self.data = json.loads(
@@ -35,11 +68,31 @@ def test_images_match_recorded_evidence(self):
3568
self.assertEqual(b[:8], b"\x89PNG\r\n\x1a\n")
3669
self.assertEqual(hashlib.sha256(b).hexdigest(), r["sha256"])
3770

38-
def test_live_catalogue_links_not_just_pr_links(self):
39-
urls = Links((ROOT / "reports/conloca-2026-10/index.html").read_text()).urls
40-
base = "https://pages.hyperide.ai/alex-mextner/conloca-storybook-previews/"
41-
for segment in ["main", "pr-404", "pr-489"]:
42-
self.assertIn(base + segment + "/", urls)
71+
def test_rejected_catalogue_links_and_claims_are_absent(self):
72+
for slug in self.data["reports"]:
73+
text = (ROOT / "reports" / slug / "index.html").read_text(encoding="utf-8")
74+
self.assertNotIn("pages.hyperide.ai", text.casefold())
75+
visible = VisibleText(text).text
76+
raw = " ".join(text.split()).casefold()
77+
for phrase in REJECTED_CLAIMS:
78+
self.assertNotIn(phrase, visible)
79+
self.assertNotIn(phrase, raw)
80+
81+
def test_conloca_keeps_tested_preview_attribution_and_images(self):
82+
text = (ROOT / "reports/conloca-2026-10/index.html").read_text(encoding="utf-8")
83+
urls = Links(text).urls
84+
for url in [
85+
"https://site.pr489.conloca.com/getting-started/",
86+
"https://github.com/conloca/private/actions/runs/41626469902/job/125893569803",
87+
"https://github.com/conloca/private/actions/runs/40534284367",
88+
"images/theme-before.png",
89+
"images/theme-after.png",
90+
]:
91+
self.assertIn(url, urls)
92+
self.assertIn("Work by Ultra / Mextner", text)
93+
94+
def test_catalogue_receipts_are_historical_only(self):
95+
self.assertEqual(self.data["storybookPreviews"]["status"], "historical")
4396

4497
def test_new_workflows_not_presented_as_merged(self):
4598
data = self.data["storybookPreviews"]

0 commit comments

Comments
 (0)