From da2337eeaf70431ba4041448383f7c406ffc162e Mon Sep 17 00:00:00 2001 From: Derek Date: Mon, 16 Nov 2026 13:33:00 +1100 Subject: [PATCH] docs(contributing): drop the DCO sign-off requirement No required check enforces the sign-off. The contributing guide stops asking for it. --- CONTRIBUTING.md | 56 +++---------------------------------------------- 1 file changed, 3 insertions(+), 53 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a5f0822..0144b67 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -74,54 +74,6 @@ This project follows [Semantic Versioning 2.0.0](https://semver.org/): Versions are automatically determined by semantic-release based on commit messages. Do not manually update version numbers. -## Developer Certificate of Origin - -This project uses the Developer Certificate of Origin (DCO) to ensure that -contributors have the right to submit their contributions. - -By making a contribution to this project, you certify that: - -1. The contribution was created in whole or in part by you and you have the - right to submit it under the license indicated in the file; or - -2. The contribution is based upon previous work that, to the best of your - knowledge, is covered under an appropriate open source license and you - have the right under that license to submit that work with modifications; - or - -3. The contribution was provided directly to me by some other person who - certified (1), (2) or (3) and you have not modified it. - -4. You understand and agree that this project and the contribution are public - and that a record of the contribution (including all personal information - you submit with it, including your sign-off) is maintained indefinitely - and may be redistributed consistent with this project or the license(s) - involved. - -## How to Sign Off Your Commits - -You must sign off each commit to indicate your acceptance of the DCO. Combine -the signoff with your conventional commit message: - -``` -git commit --signoff -m "feat(auth): add two-factor authentication" -``` - -This produces: - -``` -feat(auth): add two-factor authentication - -Signed-off-by: Your Name -``` - -Make sure your Git configuration has your correct name and email: - -``` -git config --global user.name "Your Name" -git config --global user.email "your.email@example.com" -``` - ## License for Contributions All contributions to this project are licensed under the Business Source @@ -135,14 +87,12 @@ anniversary of its release. 1. **Fork the repository** and create your branch from `main` 2. **Make your changes** following the commit message format above -3. **Sign off your commits** with the DCO -4. **Test your changes** to ensure they work as expected -5. **Submit a pull request** with a clear description of what you've done +3. **Test your changes** to ensure they work as expected +4. **Submit a pull request** with a clear description of what you've done ### Pull Request Checklist - [ ] Commits follow the conventional commit format -- [ ] All commits are signed off (DCO) - [ ] Tests pass (if applicable) - [ ] Documentation is updated (if applicable) @@ -183,7 +133,7 @@ If you have questions about contributing, please open an issue or contact us. ### What this is -dfe-docker stands the whole DFE suite up as one Docker Compose stack on a single host, and it is the definition-of-done target for the suite's docker path: a change is proven when it runs on the deployment target, not because it ran on someone's laptop. It packages the stack: its release builds the dfe-docker image that sets a folder up from this tree, publishes it with the Compose artefacts and `quickstart.json`, and builds no component image (`make dev` builds those locally, for a test rig). It provisions no ClickHouse table and no Kafka topic. dfe-engine is the only schema and topic controller, and `scripts/tests/test_engine_only_schema_control.py` fails the build on a DDL file or a topic-creating step appearing here. When the data path is wrong the fix is nearly always in a component repo. It is not the Kubernetes path either: Kubernetes stays primary and dfe-infra owns it, which is why there is deliberately no `scale` profile - Compose cannot run an HA broker or a ClickHouse cluster. `main` is protected, so every change arrives as a pull request, with Conventional Commits and a DCO sign-off ([CONTRIBUTING.md](CONTRIBUTING.md)). +dfe-docker stands the whole DFE suite up as one Docker Compose stack on a single host, and it is the definition-of-done target for the suite's docker path: a change is proven when it runs on the deployment target, not because it ran on someone's laptop. It packages the stack: its release builds the dfe-docker image that sets a folder up from this tree, publishes it with the Compose artefacts and `quickstart.json`, and builds no component image (`make dev` builds those locally, for a test rig). It provisions no ClickHouse table and no Kafka topic. dfe-engine is the only schema and topic controller, and `scripts/tests/test_engine_only_schema_control.py` fails the build on a DDL file or a topic-creating step appearing here. When the data path is wrong the fix is nearly always in a component repo. It is not the Kubernetes path either: Kubernetes stays primary and dfe-infra owns it, which is why there is deliberately no `scale` profile - Compose cannot run an HA broker or a ClickHouse cluster. `main` is protected, so every change arrives as a pull request, with Conventional Commits ([CONTRIBUTING.md](CONTRIBUTING.md)). ### Where things live