Skip to content

Update GHA reusable workflow ref#720

Merged
mikelittle merged 1 commit into
masterfrom
gha-module-update
May 22, 2026
Merged

Update GHA reusable workflow ref#720
mikelittle merged 1 commit into
masterfrom
gha-module-update

Conversation

@mikelittle

Copy link
Copy Markdown
Contributor

Pin to altis-dev-tools tip past #1056 (artifact name + module-config input + Packagist bypass + other follow-ups).

@mikelittle mikelittle force-pushed the gha-module-update branch from 33750bb to 16822c3 Compare May 21, 2026 15:12
@mikelittle mikelittle marked this pull request as draft May 21, 2026 15:47
@mikelittle mikelittle force-pushed the gha-module-update branch from 16822c3 to a56c18c Compare May 21, 2026 16:28
@mikelittle mikelittle marked this pull request as ready for review May 21, 2026 17:13
@jerico

jerico commented May 22, 2026

Copy link
Copy Markdown
Contributor

Is this intentional to be pinned to a hash? I think this would mean future changes to the workflow would require another change across Altis modules

@mikelittle

Copy link
Copy Markdown
Contributor Author

Is this intentional to be pinned to a hash? I think this would mean future changes to the workflow would require another change across Altis modules

Yes. That's what was done with the previous (still current) Travis tests. It means when new tests or functionality are introduced that might not apply to old versions, they won't try to run them.
The only exception is the dev-tools module, which references the common module by path so that PRs with changes to the tests, run those changes.

@ferschubert-hm ferschubert-hm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikelittle mikelittle merged commit f3308f3 into master May 22, 2026
2 of 3 checks passed
@mikelittle mikelittle deleted the gha-module-update branch May 22, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants