fix: clearer ValueError when Solver values are missing or wrong type#21
Merged
Conversation
Calling solver() with no arguments on a multi-variable formula raised
'The value of the \"values\" parameter is not a dict! Its type is
<class \"NoneType\">' — which incorrectly framed the problem as a type
mismatch when the caller had actually just forgotten to pass anything.
Split the two cases:
- values is None and the formula has variables → "Missing values for
variables: {...}"
- values is not None but not a Mapping → "Expected a Mapping for
'values' (got <type>); variables to provide: {...}"
Regression test in tests/test_solver_missing_values_message.py.
See ai/improvements_2026-05-09.md item #7.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. Calling
solver()(no arguments) on a multi-variable formula raisedValueError: The value of the 'values' parameter is not a dict! Its type is <class 'NoneType'>.... That framed the problem as a type mismatch when the caller had actually just forgotten to pass anything. New users hit this immediately.Fix.
src/formula/formula.py— split the two cases:values is None+ the formula has variables →"Missing values for variables: {...}"values is not Nonebut not aMapping→"Expected a Mapping for 'values' (got <type>); variables to provide: {...}"Test. New file
tests/test_solver_missing_values_message.pycovers both messages and confirms the proper-call path still works. All pass; full suite 320/320.