From 986ee652c94b5047d7126adb569aff3e4ea3ef14 Mon Sep 17 00:00:00 2001 From: ajinkya Date: Fri, 30 Jan 2026 11:09:08 +0530 Subject: [PATCH 1/2] fix: allow saving optional phone number and improve visibility conditions (#408) --- src/components/FacilityAddressModal.vue | 4 ++-- src/views/FacilityDetails.vue | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/FacilityAddressModal.vue b/src/components/FacilityAddressModal.vue index 911a817a..98939c1e 100644 --- a/src/components/FacilityAddressModal.vue +++ b/src/components/FacilityAddressModal.vue @@ -56,7 +56,7 @@ - {{ telecomNumberValue?.countryCode }} + {{ telecomNumberValue?.countryCode }} @@ -284,7 +284,7 @@ export default defineComponent({ : true }, isTelecomNumberUpdated() { - return this.telecomNumberValue?.contactNumber && JSON.stringify(this.telecomNumberValue.contactNumber) !== JSON.stringify(this.contactDetails?.telecomNumber?.contactNumber) + return JSON.stringify(this.telecomNumberValue?.contactNumber) !== JSON.stringify(this.contactDetails?.telecomNumber?.contactNumber) }, isEmailAddressUpdated() { return this.emailAddress?.infoString && JSON.stringify(this.emailAddress.infoString) !== JSON.stringify(this.contactDetails?.emailAddress?.infoString); diff --git a/src/views/FacilityDetails.vue b/src/views/FacilityDetails.vue index 0551ee00..0ff29356 100644 --- a/src/views/FacilityDetails.vue +++ b/src/views/FacilityDetails.vue @@ -58,7 +58,7 @@

{{ postalAddress.directions }}

{{ postalAddress.postalCode ? `${postalAddress.city}, ${postalAddress.postalCode}` : postalAddress.city }}

{{ postalAddress.countryGeoName ? `${postalAddress.stateGeoName}, ${postalAddress.countryGeoName}` : postalAddress.stateGeoName }}

-

{{ `${contactDetails.telecomNumber?.countryCode}-${contactDetails.telecomNumber?.contactNumber}` }}

+

{{ `${contactDetails.telecomNumber?.countryCode}-${contactDetails.telecomNumber?.contactNumber}` }}

{{ contactDetails.emailAddress?.infoString }}

From 072396241e658c9f2d717801396a1d64ac3d02e4 Mon Sep 17 00:00:00 2001 From: ajinkya Date: Fri, 30 Jan 2026 11:14:46 +0530 Subject: [PATCH 2/2] fix: address pr comments for phone number validation and display --- src/components/FacilityAddressModal.vue | 2 +- src/views/FacilityDetails.vue | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/FacilityAddressModal.vue b/src/components/FacilityAddressModal.vue index 98939c1e..f7b7a279 100644 --- a/src/components/FacilityAddressModal.vue +++ b/src/components/FacilityAddressModal.vue @@ -284,7 +284,7 @@ export default defineComponent({ : true }, isTelecomNumberUpdated() { - return JSON.stringify(this.telecomNumberValue?.contactNumber) !== JSON.stringify(this.contactDetails?.telecomNumber?.contactNumber) + return !Object.is(this.telecomNumberValue?.contactNumber, this.contactDetails?.telecomNumber?.contactNumber) }, isEmailAddressUpdated() { return this.emailAddress?.infoString && JSON.stringify(this.emailAddress.infoString) !== JSON.stringify(this.contactDetails?.emailAddress?.infoString); diff --git a/src/views/FacilityDetails.vue b/src/views/FacilityDetails.vue index 0ff29356..4aa5e220 100644 --- a/src/views/FacilityDetails.vue +++ b/src/views/FacilityDetails.vue @@ -58,7 +58,7 @@

{{ postalAddress.directions }}

{{ postalAddress.postalCode ? `${postalAddress.city}, ${postalAddress.postalCode}` : postalAddress.city }}

{{ postalAddress.countryGeoName ? `${postalAddress.stateGeoName}, ${postalAddress.countryGeoName}` : postalAddress.stateGeoName }}

-

{{ `${contactDetails.telecomNumber?.countryCode}-${contactDetails.telecomNumber?.contactNumber}` }}

+

{{ [contactDetails.telecomNumber.countryCode, contactDetails.telecomNumber.contactNumber].filter(Boolean).join('-') }}

{{ contactDetails.emailAddress?.infoString }}