From 29d6fdfcdb92ee574219bdc3ebd791b93e1d505a Mon Sep 17 00:00:00 2001 From: kellyaa Date: Fri, 20 Nov 2026 04:34:49 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=8C=B1=20attribution:=20extra=20footer-li?= =?UTF-8?q?ne=20regression=20cases=20for=20the=20trailer=20parser?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #19366 landed the trailer-past-footer-lines fix this PR carried, so the parser and marker-insertion changes are dropped in favour of the upstream implementation. What remains are regression cases upstream does not cover: an unclosed HTML comment, a language-tagged code fence and a keyword inside prose after the trailer still hide it, and a mixed Closes/marker/Generated with/Refs tail before the identity footer parses with CRLF line endings. Fixes #19364 Hive-Run: hivecommons/hive#19364 Hive-Plan: issue-19364 Hive-Spec: issue-19364#acceptance-criteria Co-Authored-By: Claude Opus 5.5 Signed-off-by: kellyaa --- .../attribution_footer_lines_extra_test.go | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 src/pkg/github/attribution_footer_lines_extra_test.go diff --git a/src/pkg/github/attribution_footer_lines_extra_test.go b/src/pkg/github/attribution_footer_lines_extra_test.go new file mode 100644 index 0000000000..759aac8982 --- /dev/null +++ b/src/pkg/github/attribution_footer_lines_extra_test.go @@ -0,0 +1,30 @@ +package github + +import ( + "strings" + "testing" +) + +// Extra regression cases for hivecommons/hive#19364 not covered by +// attribution_footer_lines_test.go. + +func TestParseAttributionTrailerFooterLinesExtraStrictCases(t *testing.T) { + for _, tc := range []struct{ name, body string }{ + {"unclosed-html-comment", "Done\n\n" + footerLinesTrailer + "\n\n