From b8ab1fefd24461dcecb59ee39ac8217099a4cde7 Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Wed, 18 Nov 2026 03:02:51 -0500 Subject: [PATCH] fix: treat already-running agent at startup launch as benign Co-Authored-By: Claude Sonnet 5.5 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --- .../fixed-18936-startup-already-running-benign.md | 1 + src/cmd/hive/boot_launch_deps_test.go | 14 ++++++++++++++ src/cmd/hive/main.go | 8 +++++++- 3 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 changelog.d/fixed-18936-startup-already-running-benign.md diff --git a/changelog.d/fixed-18936-startup-already-running-benign.md b/changelog.d/fixed-18936-startup-already-running-benign.md new file mode 100644 index 0000000000..873e28923d --- /dev/null +++ b/changelog.d/fixed-18936-startup-already-running-benign.md @@ -0,0 +1 @@ +- Startup no longer reports "failed to start agent" (and a self-report issue) when an agent is already running or launching by the time its startup launch runs ([#18936](https://github.com/hivecommons/hive/issues/18936)). diff --git a/src/cmd/hive/boot_launch_deps_test.go b/src/cmd/hive/boot_launch_deps_test.go index a09b5332e9..10bfafb4ce 100644 --- a/src/cmd/hive/boot_launch_deps_test.go +++ b/src/cmd/hive/boot_launch_deps_test.go @@ -161,6 +161,20 @@ func TestBootLaunchWithLogsServeAndStartFailures(t *testing.T) { } } +func TestBootLaunchWithAlreadyRunningAgentIsNotStartFailure(t *testing.T) { + b := newLaunchBoot(t, map[string]config.AgentConfig{"telemetry": {Enabled: true}}) + var sb strings.Builder + b.logger = slog.New(slog.NewTextHandler(&sb, nil)) + h := &launchHarness{ + startErr: map[string]error{"telemetry": errors.New("agent telemetry already running")}, + } + b.bootLaunchWith(h.deps()) + + if out := sb.String(); strings.Contains(out, "failed to start agent") { + t.Fatalf("already-running agent must not log a start failure:\n%s", out) + } +} + func TestBootLaunchWithStartsDiscordBotWhenConfigured(t *testing.T) { for _, tc := range []struct { name string diff --git a/src/cmd/hive/main.go b/src/cmd/hive/main.go index 655f7f05e3..5c734560cc 100644 --- a/src/cmd/hive/main.go +++ b/src/cmd/hive/main.go @@ -4655,7 +4655,13 @@ func (b *boot) bootLaunchWith(deps bootLaunchDeps) { } b.logger.Info("audit: starting agent", "name", name, "trigger", "startup") if err := deps.startAgent(b.ctx, b.agentMgr, name); err != nil { - b.logger.Warn("failed to start agent", "name", name, "error", err) + if stoppedAgentStartErrorIsBenign(err) { + // Already running (adopted/raced) or launching: the desired + // end state holds, so this is not a start failure (#18936). + b.logger.Info("agent already started; skipping startup launch", "name", name, "reason", err.Error()) + } else { + b.logger.Warn("failed to start agent", "name", name, "error", err) + } } else { // Surface whether a persisted operator pause was honored on this // restart, so the audit log shows pause state survived (or didn't).