From c041719a4340cd45733d21153631ca6195bcacd7 Mon Sep 17 00:00:00 2001 From: Danathar <6772335+Danathar@users.noreply.github.com> Date: Tue, 17 Nov 2026 17:21:13 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20gfi:=20withdraw=20the=20invite?= =?UTF-8?q?=20once=20a=20PR=20covers=20the=20issue;=20never=20advertise=20?= =?UTF-8?q?relay-refused=20issues?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The good-first-issue sweep only re-scored filtered rows, so an advertised issue a pull request later covered (claimed_by_pr) kept both labels and the welcome comment, and linked-pr / stage/040-covered-by-pr were not withdrawable anyway. Covered rows wearing the label now reach the sweep with HasLinkedPR and are withdrawn with a covered-by-a-PR note; a relay contributor's or person's claim keeps the label (Convert). Score also never consulted hub.contribute_skip_labels, so needs-triage issues were advertised with a claim link the relay refuses. Policy gains an optional RelaySkip matcher, wired to the hub setting; relay-skip is checked after the withdrawable gates and is itself not withdrawable. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 --- ...gfi-withdraw-covered-skip-relay-refused.md | 1 + src/cmd/hive/gfi_wire.go | 25 ++- src/cmd/hive/gfi_wire_test.go | 57 +++++++ src/docs/good-first-issue.md | 25 ++- src/pkg/gfi/covered_relayskip_test.go | 142 ++++++++++++++++++ src/pkg/gfi/gfi.go | 33 +++- src/pkg/gfi/opstracking.go | 19 ++- 7 files changed, 291 insertions(+), 11 deletions(-) create mode 100644 changelog.d/fixed-gfi-withdraw-covered-skip-relay-refused.md create mode 100644 src/pkg/gfi/covered_relayskip_test.go diff --git a/changelog.d/fixed-gfi-withdraw-covered-skip-relay-refused.md b/changelog.d/fixed-gfi-withdraw-covered-skip-relay-refused.md new file mode 100644 index 0000000000..4db920bf67 --- /dev/null +++ b/changelog.d/fixed-gfi-withdraw-covered-skip-relay-refused.md @@ -0,0 +1 @@ +- Good-first-issue curation no longer keeps inviting newcomers to issues the contributor relay will not hand out. An advertised issue that a pull request later covers (its `claimed_by_pr` row, `linked-pr`, or `stage/040-covered-by-pr`) now loses `good first issue` and `help wanted` on the next sweep, and its welcome comment is edited to say a pull request covers it; a relay contributor's or person's own claim still keeps the label until the issue closes. The sweep also skips any issue matching `hub.contribute_skip_labels` (`needs-triage` by default, logged as `relay-skip: