From fae33fabfb2657b13caf9bbd986107e0ca8d70ac Mon Sep 17 00:00:00 2001 From: Danathar <6772335+Danathar@users.noreply.github.com> Date: Tue, 17 Nov 2026 11:58:54 -0500 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=93=8A=20Governor=20PRs=20by=20model:?= =?UTF-8?q?=20list=20one=20model's=20pull=20requests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GET /api/governor/pr-models takes an optional model= (canonicalised with modelfamily.Canonical) and then adds prs[]: every PR in the window in that model's bucket, with the most_reworked fields plus outcome, agent, created_at, merged_at and first_pass, sorted by review rounds + fix attempts then newest, capped at 200 with prs_truncated. Without model the response is unchanged. Each PRs-by-model row gets a "PRs" disclosure that fetches the list on demand, cached per window and model. Refs #18722 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01WcWm7qFmFJp26r9LPdmi3t --- ...added-18722-governor-pr-models-list-prs.md | 1 + dashboard/test/governor-pr-models-ui.test.js | 72 +++++++ src/docs/api-reference/agents-and-controls.md | 2 +- src/docs/dashboard.md | 7 +- src/pkg/dashboard/api_governor_pr_models.go | 4 + .../dashboard/api_governor_pr_models_list.go | 138 ++++++++++++ .../api_governor_pr_models_list_test.go | 199 ++++++++++++++++++ .../dashboard/governor_pr_models_ui_test.go | 6 + src/pkg/dashboard/static-src/css/governor.css | 8 + .../dashboard/static-src/js/governor-view.js | 69 +++++- src/pkg/dashboard/static/index.html | 77 ++++++- 11 files changed, 577 insertions(+), 6 deletions(-) create mode 100644 changelog.d/added-18722-governor-pr-models-list-prs.md create mode 100644 src/pkg/dashboard/api_governor_pr_models_list.go create mode 100644 src/pkg/dashboard/api_governor_pr_models_list_test.go diff --git a/changelog.d/added-18722-governor-pr-models-list-prs.md b/changelog.d/added-18722-governor-pr-models-list-prs.md new file mode 100644 index 0000000000..137a230852 --- /dev/null +++ b/changelog.d/added-18722-governor-pr-models-list-prs.md @@ -0,0 +1 @@ +- Governor **PRs by model** can list one model's pull requests: a **▸ PRs** button on each model row opens that model's PRs in the window (outcome, review rounds, fix attempts, first pass, author agent and backend, each linking to GitHub), loaded on demand from the new optional `model=` parameter on `GET /api/governor/pr-models`. The parameter accepts any raw spelling of the model, returns up to 200 PRs most reworked first with `prs_truncated` past that, and leaves the response unchanged when omitted (#18722). diff --git a/dashboard/test/governor-pr-models-ui.test.js b/dashboard/test/governor-pr-models-ui.test.js index cef6a5e1ea..14be70ce02 100644 --- a/dashboard/test/governor-pr-models-ui.test.js +++ b/dashboard/test/governor-pr-models-ui.test.js @@ -37,3 +37,75 @@ test('Governor PRs by model shows unmeasured run columns as a dash and discloses assert.ok(indexHtml.includes(expected), `index.html missing ${expected}`); } }); + +// Extracts `function name(` / `async function name(` from index.html by brace matching. +function extractFunction(name) { + const re = new RegExp(`(?:async )?function ${name}\\(`); + const m = re.exec(indexHtml); + assert.ok(m, `index.html does not define ${name}()`); + const open = indexHtml.indexOf('{', m.index + m[0].length); + let depth = 0; + for (let i = open; i < indexHtml.length; i++) { + if (indexHtml[i] === '{') depth++; + else if (indexHtml[i] === '}' && --depth === 0) return indexHtml.slice(m.index, i + 1); + } + assert.fail(`unbalanced braces in ${name}()`); +} + +test('Opening a model row requests model=… and lists its PRs with GitHub links (#18722)', async () => { + const vm = require('node:vm'); + const fetchURLs = []; + const sandbox = { + fetchURLs, + renders: 0, + escapeHtml: s => String(s).replace(/&/g, '&').replace(//g, '>').replace(/"/g, '"'), + fetch: async url => { + fetchURLs.push(url); + return { + ok: true, + json: async () => ({ + prs: [ + { repo: 'org/a', number: 2, title: 'reworked ', url: 'https://github.com/org/a/pull/2', outcome: 'merged', review_rounds: 2, fix_attempts: 1, agent: 'fixer', backend: 'pi' }, + { repo: 'org/b', number: 4, url: 'https://github.com/org/b/pull/4', outcome: 'closed_unmerged', review_rounds: 1, fix_attempts: 2, first_pass: false }, + ], + prs_truncated: true, + }), + }; + }, + }; + sandbox.window = sandbox; + vm.createContext(sandbox); + const src = [ + "let govPRModelsWindow = '30d';", + "let govPRModelPRsOpen = '';", + 'const govPRModelPRsCache = {};', + 'const govPRModelPRsLoading = {};', + 'function renderGovernorFromLastStatus() { renders++; }', + ...['normalizeGovernorPRModelsWindowName', 'governorPRModelPRsKey', 'loadGovernorPRModelPRs', 'toggleGovernorPRModelPRs', 'governorPRModelPRsToggleHtml', 'governorPRModelPRListHtml'].map(extractFunction), + 'this.api = { toggleGovernorPRModelPRs, governorPRModelPRsToggleHtml, governorPRModelPRListHtml, state: () => govPRModelPRsOpen };', + ].join('\n'); + vm.runInContext(src, sandbox); + const api = sandbox.api; + + assert.match(api.governorPRModelPRsToggleHtml('claude-opus-5.5'), /data-action="toggleGovernorPRModelPRs" data-arg0="claude-opus-5\.5"/); + assert.match(api.governorPRModelPRsToggleHtml('claude-opus-5.5'), /aria-expanded="false"/); + assert.equal(api.governorPRModelPRListHtml('claude-opus-5.5'), '', 'a closed row renders no list'); + + await api.toggleGovernorPRModelPRs('claude-opus-5.5'); + assert.deepEqual(fetchURLs, ['/api/governor/pr-models?window=30d&model=claude-opus-5.5']); + assert.equal(api.state(), 'claude-opus-5.5'); + assert.match(api.governorPRModelPRsToggleHtml('claude-opus-5.5'), /aria-expanded="true"/); + const html = api.governorPRModelPRListHtml('claude-opus-5.5'); + assert.match(html, /org\/a#2<\/a>/); + assert.match(html, /org\/b#4<\/a>/); + assert.match(html, /reworked <b>/, 'titles are escaped'); + assert.match(html, /closed-unmerged/); + assert.match(html, /Showing the first 2 PRs/, 'a truncated list says so'); + assert.equal(api.governorPRModelPRListHtml('gpt-6.1-sol'), '', 'other rows stay closed'); + + // Reopening the same model in the same window uses the cache. + await api.toggleGovernorPRModelPRs('claude-opus-5.5'); + assert.equal(api.state(), ''); + await api.toggleGovernorPRModelPRs('claude-opus-5.5'); + assert.equal(fetchURLs.length, 1, 'cached per window and model'); +}); diff --git a/src/docs/api-reference/agents-and-controls.md b/src/docs/api-reference/agents-and-controls.md index fa1b6297f9..ffb786b9e8 100644 --- a/src/docs/api-reference/agents-and-controls.md +++ b/src/docs/api-reference/agents-and-controls.md @@ -21,7 +21,7 @@ Part of the [Dashboard REST API reference](../api-reference.md); see that page f | `POST` | `/api/unpin/{agent}/{dimension}` | Owner only | Unpin | `pkg/dashboard/api.go:135` | | `POST` | `/api/restart/{agent}` | Owner only | Restart | `pkg/dashboard/api.go:139` | | `GET` | `/api/model-advisor` | Dashboard auth/session | Model Advisor | `pkg/dashboard/api.go:156` | -| `GET` | `/api/governor/pr-models` | Dashboard auth/session | Agent-authored PR distribution by normalized attribution model/backend for `window=7d`, `30d`, or `all`, including per-model rework stats, Wilson 95% `*_ci` intervals on the rates (omitted when the denominator is 0), a `coverage` block (closed-PR lookback and run-log partiality, as on `/api/contribute/effective-models`), `earliest_pr_created_at`, and the top 10 most-reworked PRs | `pkg/dashboard/api.go:157` | +| `GET` | `/api/governor/pr-models` | Dashboard auth/session | Agent-authored PR distribution by normalized attribution model/backend for `window=7d`, `30d`, or `all`, including per-model rework stats, Wilson 95% `*_ci` intervals on the rates (omitted when the denominator is 0), a `coverage` block (closed-PR lookback and run-log partiality, as on `/api/contribute/effective-models`), `earliest_pr_created_at`, and the top 10 most-reworked PRs. Optional `model=` (matched after `modelfamily.Canonical`, so raw spellings such as `anthropic/claude-opus-5-5` work) adds `prs[]`: every PR in the window in that model's bucket, with the `most_reworked` fields plus `outcome` (`merged` / `closed_unmerged` / `open`), `agent`, `created_at`, `merged_at` and `first_pass`, sorted by review rounds + fix attempts then newest, capped at 200 with `prs_truncated: true` past that. An unknown model returns `prs: []`; without `model` the response is unchanged | `pkg/dashboard/api.go:157` | | `GET` | `/api/reviewer/accuracy` | Dashboard auth/session | Reviewer verdict calibration for the configured window: false-approve/false-block rates and confidence buckets per perspective and reviewer model | `pkg/dashboard/api.go:220` | | `GET` | `/api/review/queue` | Dashboard auth/session | PR review queue: every open PR (agent and contributor, actionable and held) ranked by triage class, confidence band, CI state and age, with per-PR `reasons`; unreviewed items carry `pending_since` and `redispatch_count` from the review dispatch state; each entry carries `stage` `{stage, entered_at, last_activity_at, quiet_for, stalled, waiting_on_hive, past_dwell, history[]}` from the stage-label store (`stalled`/`past_dwell` follow `governor.labels.stage.dwell` and `stalled.require_quiet`; `history[]` is `{from, to, at, reason, regressed}`, newest last, capped at 8) and the top-level `hive_held` counts PRs past their stage dwell while waiting on the hive (`waiting_on_hive` and `past_dwell` both true); paged with `limit` (1-200, default 50) and `offset` | `pkg/dashboard/api.go:502` | | `POST` | `/api/review/queue/{owner}/{repo}/{number}/superseded/close` | Owner only | Close a superseded PR now (grace window or not): posts the close comment, adds `hive/superseded`, closes it | `pkg/dashboard/api.go:505` | diff --git a/src/docs/dashboard.md b/src/docs/dashboard.md index 174dcdef4d..7606bfc006 100644 --- a/src/docs/dashboard.md +++ b/src/docs/dashboard.md @@ -173,7 +173,12 @@ The dashboard **Governor** card summarizes queue depth, operating mode, budget posture, and cadence controls for the hive. Its collapsible **PRs by model** nested sub-section reads `GET /api/governor/pr-models` with the selected `7d`, `30d`, or `all` window. The nested header keeps the window/sort toggles visible and its -collapsed summary shows the current top-ranked model plus model count. +collapsed summary shows the current top-ranked model plus model count. Each +model row has a **▸ PRs** button that opens that model's pull requests in the +selected window (outcome, review rounds, fix attempts, first pass, author agent +and backend, each linked to GitHub). The list is fetched on demand with +`GET /api/governor/pr-models?window=…&model=` and cached per window and +model. The Governor **actionable issues** and **actionable PRs** tiles use the shared server-side actionable partition described in [Repository card legend, issue diff --git a/src/pkg/dashboard/api_governor_pr_models.go b/src/pkg/dashboard/api_governor_pr_models.go index 0c0225e34c..5a0396c33f 100644 --- a/src/pkg/dashboard/api_governor_pr_models.go +++ b/src/pkg/dashboard/api_governor_pr_models.go @@ -135,6 +135,10 @@ func (s *Server) handleGovernorPRModels(w http.ResponseWriter, r *http.Request) effective := aggregateEffectiveModelsFromPRAggregation(resp, aggregateEffectiveRunStats(runs, effectiveModelsFilterAll), effectiveModelsFilterAll, minMergedPRs) applyGovernorPRModelEffectiveness(&resp, effective, minMergedPRs) w.Header().Set("Content-Type", "application/json") + if model, ok := governorPRModelsQueryModel(r); ok { + _ = json.NewEncoder(w).Encode(withGovernorPRModelPRs(resp, actionable.PRs.Attributed, model, now)) + return + } _ = json.NewEncoder(w).Encode(resp) } diff --git a/src/pkg/dashboard/api_governor_pr_models_list.go b/src/pkg/dashboard/api_governor_pr_models_list.go new file mode 100644 index 0000000000..4c39f73d49 --- /dev/null +++ b/src/pkg/dashboard/api_governor_pr_models_list.go @@ -0,0 +1,138 @@ +package dashboard + +import ( + "net/http" + "sort" + "strings" + "time" + + ghpkg "github.com/hivecommons/hive/pkg/github" + "github.com/hivecommons/hive/pkg/modelfamily" +) + +// governorPRModelPRsCap bounds the per-model PR list returned by +// /api/governor/pr-models?model=…; past it PRsTruncated is set. +const governorPRModelPRsCap = 200 + +// governorPRModelsWithPRsResponse is the /api/governor/pr-models response +// when a model filter is given: the usual body plus that model's PRs. PRs is +// a pointer so an unknown model encodes as "prs": [] rather than dropping the +// field; without a filter this type is never used, so the default response is +// unchanged. +type governorPRModelsWithPRsResponse struct { + governorPRModelsResponse + PRs *[]governorPRModelPRItem `json:"prs,omitempty"` + PRsTruncated bool `json:"prs_truncated,omitempty"` +} + +// governorPRModelPRItem is one PR in a model's list: the most_reworked fields +// plus its outcome, author agent, timestamps and first-pass flag. No PR body, +// the same privacy as most_reworked. +type governorPRModelPRItem struct { + governorPRMostReworkedItem + Outcome string `json:"outcome"` + Agent string `json:"agent,omitempty"` + CreatedAt string `json:"created_at,omitempty"` + MergedAt string `json:"merged_at,omitempty"` + FirstPass bool `json:"first_pass"` +} + +// governorPRModelsQueryModel returns the canonical model named by the +// request's model= parameter, and false when the parameter is absent or blank. +func governorPRModelsQueryModel(r *http.Request) (string, bool) { + raw := strings.TrimSpace(r.URL.Query().Get("model")) + if raw == "" { + return "", false + } + return modelfamily.Canonical(raw), true +} + +// governorPRModelPRList lists every attributed PR in the window whose bucket +// (modelfamily.Canonical of its model) is model, using the same window and +// attribution filters as aggregateGovernorPRModels so the list length matches +// the bucket's prs count. Sorted by review rounds + fix attempts descending, +// then created_at descending; capped at governorPRModelPRsCap. +func governorPRModelPRList(prs []ghpkg.PullRequest, window, model string, now time.Time) ([]governorPRModelPRItem, bool) { + window = normalizeGovernorPRModelsWindow(window) + cutoff := time.Time{} + switch window { + case governorPRModelsWindow7d: + cutoff = now.AddDate(0, 0, -governorPRModelsDays7) + case governorPRModelsWindow30d: + cutoff = now.AddDate(0, 0, -governorPRModelsDays30) + } + type listed struct { + item governorPRModelPRItem + created time.Time + } + var rows []listed + for _, pr := range prs { + if !pr.HiveAttributed { + continue + } + if !cutoff.IsZero() && pr.CreatedAt.Before(cutoff) { + continue + } + if modelfamily.Canonical(pr.HiveModel) != model { + continue + } + agent := ghpkg.NormalizeAttributionValue(pr.HiveAgent) + if agent == "unknown" { + agent = "" + } + item := governorPRModelPRItem{ + governorPRMostReworkedItem: governorPRMostReworkedItem{ + Repo: pr.Repo, + Number: pr.Number, + Title: pr.Title, + Model: model, + Backend: ghpkg.NormalizeAttributionValue(pr.HiveBackend), + URL: pr.URL, + ReviewRounds: pr.Rework.ReviewRounds, + FixAttempts: pr.Rework.FixAttempts, + FollowUpCommits: pr.Rework.FollowUpCommits, + FixerModels: append([]string(nil), pr.Rework.FixerModels...), + HumanChangeRequests: pr.Rework.HumanChangeRequests, + }, + Outcome: governorPRModelOutcome(pr), + Agent: agent, + FirstPass: pr.Rework.FirstPass, + } + if !pr.CreatedAt.IsZero() { + item.CreatedAt = pr.CreatedAt.UTC().Format(time.RFC3339) + } + if !pr.MergedAt.IsZero() { + item.MergedAt = pr.MergedAt.UTC().Format(time.RFC3339) + } + rows = append(rows, listed{item: item, created: pr.CreatedAt}) + } + sort.SliceStable(rows, func(i, j int) bool { + a := rows[i].item.ReviewRounds + rows[i].item.FixAttempts + b := rows[j].item.ReviewRounds + rows[j].item.FixAttempts + if a != b { + return a > b + } + if !rows[i].created.Equal(rows[j].created) { + return rows[i].created.After(rows[j].created) + } + if rows[i].item.Repo != rows[j].item.Repo { + return rows[i].item.Repo < rows[j].item.Repo + } + return rows[i].item.Number > rows[j].item.Number + }) + truncated := len(rows) > governorPRModelPRsCap + if truncated { + rows = rows[:governorPRModelPRsCap] + } + out := make([]governorPRModelPRItem, 0, len(rows)) + for _, row := range rows { + out = append(out, row.item) + } + return out, truncated +} + +// withGovernorPRModelPRs wraps resp with model's PR list for the same window. +func withGovernorPRModelPRs(resp governorPRModelsResponse, prs []ghpkg.PullRequest, model string, now time.Time) governorPRModelsWithPRsResponse { + list, truncated := governorPRModelPRList(prs, resp.Window, model, now) + return governorPRModelsWithPRsResponse{governorPRModelsResponse: resp, PRs: &list, PRsTruncated: truncated} +} diff --git a/src/pkg/dashboard/api_governor_pr_models_list_test.go b/src/pkg/dashboard/api_governor_pr_models_list_test.go new file mode 100644 index 0000000000..9c22870fb5 --- /dev/null +++ b/src/pkg/dashboard/api_governor_pr_models_list_test.go @@ -0,0 +1,199 @@ +package dashboard + +import ( + "encoding/json" + "fmt" + "net/http" + "net/http/httptest" + "path/filepath" + "testing" + "time" + + ghpkg "github.com/hivecommons/hive/pkg/github" +) + +func governorPRModelListServer(t *testing.T, prs []ghpkg.PullRequest) *Server { + t.Helper() + s := covApiServer(t) + dir := t.TempDir() + s.SetContributorsDir(dir) + if s.contributeHub != nil { + s.contributeHub.taskRunLogFile = filepath.Join(dir, taskRunLogFileName) + } + s.deps.Scheduler = metricsSchedulerStub{actionable: &ghpkg.ActionableResult{PRs: ghpkg.PRResult{Attributed: prs}}} + return s +} + +func getGovernorPRModels(t *testing.T, s *Server, query string) []byte { + t.Helper() + rec := httptest.NewRecorder() + s.handleGovernorPRModels(rec, httptest.NewRequest(http.MethodGet, "/api/governor/pr-models?"+query, nil)) + if rec.Code != http.StatusOK { + t.Fatalf("GET ?%s status = %d, want 200: %s", query, rec.Code, rec.Body.String()) + } + return rec.Body.Bytes() +} + +func TestHandleGovernorPRModelsModelFilterListsPRs(t *testing.T) { + now := time.Now().UTC() + prs := []ghpkg.PullRequest{ + // claude-opus-5.5 under three spellings: merged, merged-after-rework, open, closed. + {Repo: "org/a", Number: 1, Title: "first pass", URL: "https://github.com/org/a/pull/1", HiveAttributed: true, HiveModel: "claude-opus-5.5", HiveBackend: "claude", HiveAgent: "scanner", CreatedAt: now.Add(-1 * time.Hour), MergedAt: now, Rework: ghpkg.PRReworkStats{FirstPass: true}}, + {Repo: "org/a", Number: 2, Title: "reworked", URL: "https://github.com/org/a/pull/2", HiveAttributed: true, HiveModel: "anthropic/claude-opus-5-5", HiveBackend: "pi", HiveAgent: "fixer", CreatedAt: now.Add(-3 * time.Hour), MergedAt: now, Rework: ghpkg.PRReworkStats{ReviewRounds: 2, FixAttempts: 1, FixerModels: []string{"gpt-6.1-sol"}}}, + {Repo: "org/b", Number: 3, HiveAttributed: true, HiveModel: "Claude-Opus-5-5", HiveBackend: "claude", CreatedAt: now.Add(-2 * time.Hour), State: "open"}, + {Repo: "org/b", Number: 4, HiveAttributed: true, HiveModel: "claude-opus-5.5", HiveBackend: "claude", HiveAgent: "unknown", CreatedAt: now.Add(-4 * time.Hour), State: "closed", ClosedAt: now, Rework: ghpkg.PRReworkStats{ReviewRounds: 1, FixAttempts: 2}}, + // Another model, an out-of-window PR and an unattributed PR: never listed. + {Repo: "org/a", Number: 5, HiveAttributed: true, HiveModel: "gpt-6.1-sol", HiveBackend: "codex", CreatedAt: now.Add(-1 * time.Hour), MergedAt: now, Rework: ghpkg.PRReworkStats{ReviewRounds: 9}}, + {Repo: "org/a", Number: 6, HiveAttributed: true, HiveModel: "claude-opus-5.5", HiveBackend: "claude", CreatedAt: now.AddDate(0, 0, -20), MergedAt: now}, + {Repo: "org/a", Number: 7, HiveAttributed: false, HiveModel: "claude-opus-5.5", CreatedAt: now}, + } + s := governorPRModelListServer(t, prs) + + type listResp struct { + Buckets []governorPRModelBucket `json:"buckets"` + Total int `json:"total"` + PRs *[]governorPRModelPRItem `json:"prs"` + PRsTruncated bool `json:"prs_truncated"` + } + decode := func(body []byte) listResp { + t.Helper() + var out listResp + if err := json.Unmarshal(body, &out); err != nil { + t.Fatalf("decode: %v: %s", err, body) + } + return out + } + + canonical := decode(getGovernorPRModels(t, s, "window=7d&model=claude-opus-5.5")) + raw := decode(getGovernorPRModels(t, s, "window=7d&model=anthropic%2Fclaude-opus-5-5")) + if canonical.PRs == nil || raw.PRs == nil { + t.Fatalf("prs missing with a model filter: canonical=%v raw=%v", canonical.PRs, raw.PRs) + } + canonJSON, _ := json.Marshal(canonical.PRs) + rawJSON, _ := json.Marshal(raw.PRs) + if string(canonJSON) != string(rawJSON) { + t.Fatalf("raw spelling lists different PRs:\ncanonical %s\nraw %s", canonJSON, rawJSON) + } + + list := *canonical.PRs + var gotOrder []int + outcomes := map[string]int{} + for _, pr := range list { + gotOrder = append(gotOrder, pr.Number) + outcomes[pr.Outcome]++ + if pr.Model != "claude-opus-5.5" { + t.Fatalf("PR #%d model = %q, want the canonical id", pr.Number, pr.Model) + } + } + // #4 and #2 both score 3: newer #2 first. Then #1 and #3 score 0: newer #1 first. + if want := []int{2, 4, 1, 3}; fmt.Sprint(gotOrder) != fmt.Sprint(want) { + t.Fatalf("order = %v, want %v", gotOrder, want) + } + var bucket *governorPRModelBucket + for i := range canonical.Buckets { + if canonical.Buckets[i].Model == "claude-opus-5.5" { + bucket = &canonical.Buckets[i] + } + } + if bucket == nil { + t.Fatalf("no claude-opus-5.5 bucket: %+v", canonical.Buckets) + } + if len(list) != bucket.PRs || outcomes["merged"] != bucket.Merged || outcomes["closed_unmerged"] != bucket.ClosedUnmerged || outcomes["open"] != bucket.Open { + t.Fatalf("list %d (outcomes %v) does not match bucket prs=%d merged=%d closed=%d open=%d", len(list), outcomes, bucket.PRs, bucket.Merged, bucket.ClosedUnmerged, bucket.Open) + } + reworked := list[0] + if reworked.Repo != "org/a" || reworked.URL != "https://github.com/org/a/pull/2" || reworked.Title != "reworked" || reworked.Backend != "pi" || reworked.Agent != "fixer" || + reworked.ReviewRounds != 2 || reworked.FixAttempts != 1 || len(reworked.FixerModels) != 1 || reworked.FirstPass || reworked.MergedAt == "" || reworked.CreatedAt == "" { + t.Fatalf("reworked PR item = %+v", reworked) + } + if first := list[2]; first.Number != 1 || !first.FirstPass || first.Outcome != "merged" { + t.Fatalf("first-pass PR item = %+v", first) + } + if closed := list[1]; closed.Agent != "" || closed.MergedAt != "" || closed.Outcome != "closed_unmerged" { + t.Fatalf("closed PR item = %+v, want no agent, no merged_at", closed) + } + if canonical.PRsTruncated { + t.Fatal("prs_truncated set for 4 PRs") + } + + // The 30d window picks up #6 too. + if wide := decode(getGovernorPRModels(t, s, "window=30d&model=claude-opus-5.5")); wide.PRs == nil || len(*wide.PRs) != 5 { + t.Fatalf("30d list = %v, want 5 PRs", wide.PRs) + } + + // Unknown model: an empty list, not an error and not a missing field. + unknownBody := getGovernorPRModels(t, s, "window=7d&model=no-such-model") + var unknownRaw map[string]json.RawMessage + if err := json.Unmarshal(unknownBody, &unknownRaw); err != nil { + t.Fatalf("decode: %v", err) + } + if string(unknownRaw["prs"]) != "[]" { + t.Fatalf("unknown model prs = %s, want []", unknownRaw["prs"]) + } + + // Without a model (or with a blank one) the response carries no prs fields + // and is byte-identical to the unfiltered response. + plain := getGovernorPRModels(t, s, "window=7d") + blank := getGovernorPRModels(t, s, "window=7d&model=%20") + var plainRaw map[string]json.RawMessage + if err := json.Unmarshal(plain, &plainRaw); err != nil { + t.Fatalf("decode: %v", err) + } + for _, k := range []string{"prs", "prs_truncated"} { + if _, ok := plainRaw[k]; ok { + t.Fatalf("unfiltered response has %q: %s", k, plain) + } + } + if string(plain) != string(blank) { + t.Fatalf("blank model changed the response:\nplain %s\nblank %s", plain, blank) + } + // The filtered response is the usual body plus prs: the shared fields match. + var filteredRaw map[string]json.RawMessage + if err := json.Unmarshal(getGovernorPRModels(t, s, "window=7d&model=claude-opus-5.5"), &filteredRaw); err != nil { + t.Fatalf("decode: %v", err) + } + for _, k := range []string{"window", "total", "buckets", "unknown", "most_reworked", "min_merged_prs"} { + if string(plainRaw[k]) != string(filteredRaw[k]) { + t.Fatalf("field %q differs with the filter:\nplain %s\nfiltered %s", k, plainRaw[k], filteredRaw[k]) + } + } +} + +func TestGovernorPRModelPRListCapsAt200(t *testing.T) { + now := time.Date(2026, 11, 17, 12, 0, 0, 0, time.UTC) + var prs []ghpkg.PullRequest + for i := 0; i < governorPRModelPRsCap+1; i++ { + prs = append(prs, ghpkg.PullRequest{ + Repo: "org/a", Number: i + 1, HiveAttributed: true, HiveModel: "gpt-6.1-terra", HiveBackend: "codex", + CreatedAt: now.Add(-time.Duration(i+1) * time.Minute), MergedAt: now, + Rework: ghpkg.PRReworkStats{FixAttempts: i % 7}, + }) + } + list, truncated := governorPRModelPRList(prs, "7d", "gpt-6.1-terra", now) + if !truncated || len(list) != governorPRModelPRsCap { + t.Fatalf("len=%d truncated=%v, want %d and true", len(list), truncated, governorPRModelPRsCap) + } + for i := 1; i < len(list); i++ { + a := list[i-1].ReviewRounds + list[i-1].FixAttempts + b := list[i].ReviewRounds + list[i].FixAttempts + if a < b || (a == b && list[i-1].CreatedAt < list[i].CreatedAt) { + t.Fatalf("list not sorted at %d: %+v then %+v", i, list[i-1], list[i]) + } + } + full, truncated := governorPRModelPRList(prs[:governorPRModelPRsCap], "7d", "gpt-6.1-terra", now) + if truncated || len(full) != governorPRModelPRsCap { + t.Fatalf("at the cap: len=%d truncated=%v, want %d and false", len(full), truncated, governorPRModelPRsCap) + } + resp := withGovernorPRModelPRs(aggregateGovernorPRModels(prs, "7d", now), prs, "gpt-6.1-terra", now) + body, err := json.Marshal(resp) + if err != nil { + t.Fatal(err) + } + var raw map[string]json.RawMessage + if err := json.Unmarshal(body, &raw); err != nil { + t.Fatal(err) + } + if string(raw["prs_truncated"]) != "true" { + t.Fatalf("prs_truncated = %s, want true", raw["prs_truncated"]) + } +} diff --git a/src/pkg/dashboard/governor_pr_models_ui_test.go b/src/pkg/dashboard/governor_pr_models_ui_test.go index 2f0f5d14b1..5ff0e55d6d 100644 --- a/src/pkg/dashboard/governor_pr_models_ui_test.go +++ b/src/pkg/dashboard/governor_pr_models_ui_test.go @@ -30,6 +30,12 @@ func TestGovernorPRModelsUIRendersReworkStats(t *testing.T) { "no runs recorded, not a measured 0%", "first_pass_merge_rate_ci", "closed_prs_partial", + // Per-model PR list (#18722). + "toggleGovernorPRModelPRs", + "data-action=\"toggleGovernorPRModelPRs\"", + "&model=${encodeURIComponent(model)}", + "gov-pr-model-prlist", + "prs_truncated", } { if !strings.Contains(s, want) { t.Fatalf("static/index.html missing %q", want) diff --git a/src/pkg/dashboard/static-src/css/governor.css b/src/pkg/dashboard/static-src/css/governor.css index 06db9ad540..083c438e4a 100644 --- a/src/pkg/dashboard/static-src/css/governor.css +++ b/src/pkg/dashboard/static-src/css/governor.css @@ -82,6 +82,14 @@ .gov-pr-model-reworked-title { color:var(--amber); font-size:var(--fs-xs); font-weight:800; letter-spacing:0.1em; text-transform:uppercase; margin-bottom:var(--sp-3); } .gov-pr-model-reworked ol { margin:var(--sp-0); padding-left:18px; color:var(--muted); font-size:0.74rem; } .gov-pr-model-reworked li { margin:var(--sp-2) var(--sp-0); } + .gov-pr-model-prs-toggle { margin:2px 0 0; padding:0 var(--sp-2); border:1px solid var(--border); border-radius:var(--r-pill); background:var(--bg); color:var(--muted); font-size:var(--fs-2xs); cursor:pointer; } + .gov-pr-model-prs-toggle[aria-expanded="true"] { color:var(--text); border-color:var(--amber); } + .gov-pr-model-prlist { margin:0 0 var(--sp-3); padding:var(--sp-2) var(--sp-3); border-left:2px solid var(--border); font-size:0.74rem; color:var(--muted); } + .gov-pr-model-prlist ol { margin:var(--sp-0); padding-left:18px; max-height:320px; overflow-y:auto; } + .gov-pr-model-prlist li { margin:var(--sp-1) var(--sp-0); overflow-wrap:anywhere; } + .gov-pr-model-prlist-outcome.merged { color:var(--green); } + .gov-pr-model-prlist-outcome.open { color:var(--blue); } + .gov-pr-model-prlist-outcome.closed { color:var(--yellow); } .gov-pr-model-legend { display:flex; gap:10px; flex-wrap:wrap; color:var(--muted); font-size:var(--fs-xs); margin-top:var(--sp-4); } .gov-pr-model-legend span::before { content:''; display:inline-block; width:8px; height:8px; border-radius:50%; margin-right:var(--sp-2); vertical-align:middle; } .gov-pr-model-legend .merged::before { background:var(--green); } diff --git a/src/pkg/dashboard/static-src/js/governor-view.js b/src/pkg/dashboard/static-src/js/governor-view.js index 60b3cb3e6d..996ef6e135 100644 --- a/src/pkg/dashboard/static-src/js/governor-view.js +++ b/src/pkg/dashboard/static-src/js/governor-view.js @@ -11,6 +11,11 @@ let govPRModelsData = null; let reviewerAccuracyLoading = false; let reviewerAccuracyData = null; + // Per-model PR list (#18722): the open row's model and a cache keyed by + // window + model, filled on demand from /api/governor/pr-models?model=…. + let govPRModelPRsOpen = ''; + const govPRModelPRsCache = {}; + const govPRModelPRsLoading = {}; function normalizeGovernorPRModelsWindowName(windowName) { return ['7d', '30d', 'all'].includes(windowName) ? windowName : '7d'; @@ -33,6 +38,66 @@ } window.setGovernorPRModelsSort = setGovernorPRModelsSort; + function governorPRModelPRsKey(windowName, model) { + return `${normalizeGovernorPRModelsWindowName(windowName)}\u0000${model}`; + } + + async function loadGovernorPRModelPRs(model, windowName = govPRModelsWindow) { + const requestedWindow = normalizeGovernorPRModelsWindowName(windowName); + const key = governorPRModelPRsKey(requestedWindow, model); + if (govPRModelPRsLoading[key] || govPRModelPRsCache[key]) return; + govPRModelPRsLoading[key] = true; + try { + const res = await fetch(`/api/governor/pr-models?window=${encodeURIComponent(requestedWindow)}&model=${encodeURIComponent(model)}`); + const data = res.ok ? await res.json() : null; + govPRModelPRsCache[key] = data && Array.isArray(data.prs) + ? { prs: data.prs, truncated: !!data.prs_truncated } + : { prs: [], truncated: false, error: true }; + } catch (_) { + govPRModelPRsCache[key] = { prs: [], truncated: false, error: true }; + } finally { + delete govPRModelPRsLoading[key]; + renderGovernorFromLastStatus(); + } + } + + function toggleGovernorPRModelPRs(model) { + govPRModelPRsOpen = govPRModelPRsOpen === model ? '' : String(model || ''); + const pending = govPRModelPRsOpen ? loadGovernorPRModelPRs(govPRModelPRsOpen, govPRModelsWindow) : Promise.resolve(); + renderGovernorFromLastStatus(); + return pending; + } + window.toggleGovernorPRModelPRs = toggleGovernorPRModelPRs; + + function governorPRModelPRsToggleHtml(model) { + const open = govPRModelPRsOpen === model; + return ``; + } + + function governorPRModelPRListHtml(model) { + if (govPRModelPRsOpen !== model) return ''; + const entry = govPRModelPRsCache[governorPRModelPRsKey(govPRModelsWindow, model)]; + if (!entry) { + // First open, or the window pill changed while a row was open: fetch on demand. + loadGovernorPRModelPRs(model, govPRModelsWindow); + return '
Loading PRs…
'; + } + if (entry.error) return '
Could not load this model\'s PRs.
'; + if (!entry.prs.length) return '
No PRs for this model in the window.
'; + const outcomeLabel = { merged: 'merged', closed_unmerged: 'closed-unmerged', open: 'open' }; + const items = entry.prs.map(pr => { + const label = `${pr.repo || ''}#${pr.number || ''}`; + const href = pr.url ? ` href="${escapeHtml(pr.url)}" target="_blank" rel="noopener"` : ''; + const outcome = outcomeLabel[pr.outcome] || 'open'; + const title = pr.title ? ` ${escapeHtml(pr.title)}` : ''; + const who = [pr.agent, pr.backend].filter(Boolean).map(escapeHtml).join(' / '); + const firstPass = pr.first_pass ? ' · first pass' : ''; + return `
  • ${escapeHtml(label)}${title} ${outcome} · ${pr.review_rounds || 0} rounds · ${pr.fix_attempts || 0} fixes${firstPass}${who ? ` · ${who}` : ''}
  • `; + }).join(''); + const more = entry.truncated ? `
    Showing the first ${entry.prs.length} PRs, most reworked first.
    ` : ''; + return `
      ${items}
    ${more}
    `; + } + function governorPRModelUnattributed(b) { return !!(b?.effectiveness?.unattributed) || !b?.model || String(b.model).toLowerCase() === 'unknown'; } @@ -170,7 +235,7 @@ const scoreLine = eff.rank ? `\nRank #${eff.rank} · score ${(Number(eff.score) || 0).toFixed(3)} = Wilson lower bound(${eff.first_pass_merged ?? '?'}/${eff.merged_prs ?? b.merged ?? 0} first pass)${scoreFormula}` : (unattributed ? '\nUnattributed: no model recorded, listed but not ranked' : `\nUnranked: fewer than ${data.min_merged_prs || 5} merged PRs`); const tip = `${b.model || 'unknown'} via ${backends.join(', ')}${scoreLine}\n${prs} PRs (${share.toFixed(1)}%)\n${b.merged || 0} merged · ${b.open || 0} open · ${b.closed_unmerged || 0} closed-unmerged\nFirst-pass ${values.first_pass}${ci(eff.first_pass_merge_rate_ci || rw.first_pass_merge_rate_ci)} · PR run rate ${values.pr_runs}${measured ? ci(eff.verified_pr_run_rate_ci) : ''} · failure ${values.fail}${measured ? ci(eff.failure_rate_ci) : ''} · nothing-to-ship ${values.no_ship}${measured ? ci(eff.nothing_to_ship_rate_ci) : ''}${measured ? '' : '\n— = no runs recorded, not a measured 0%'}\nAvg rounds ${(rw.avg_review_rounds || 0).toFixed(1)} · avg fix attempts ${(rw.avg_fix_attempts || 0).toFixed(1)}${sources ? '\n\nRaw model ids folded into this row:\n' + sources : ''}${agentBreakdown ? '\n\n' + agentBreakdown : ''}`; return `
    -
    ${rank}${escapeHtml(b.model || 'unknown')}
    ${backendChips}
    +
    ${rank}${escapeHtml(b.model || 'unknown')}
    ${backendChips}${governorPRModelPRsToggleHtml(b.model || 'unknown')}
    @@ -178,7 +243,7 @@
    ${metrics} -
    `; + ${governorPRModelPRListHtml(b.model || 'unknown')}`; }).join(''); const reworkTable = data && total > 0 ? ` diff --git a/src/pkg/dashboard/static/index.html b/src/pkg/dashboard/static/index.html index 47cfb448e8..b62d19d552 100644 --- a/src/pkg/dashboard/static/index.html +++ b/src/pkg/dashboard/static/index.html @@ -2865,6 +2865,14 @@ .gov-pr-model-reworked-title { color:var(--amber); font-size:var(--fs-xs); font-weight:800; letter-spacing:0.1em; text-transform:uppercase; margin-bottom:var(--sp-3); } .gov-pr-model-reworked ol { margin:var(--sp-0); padding-left:18px; color:var(--muted); font-size:0.74rem; } .gov-pr-model-reworked li { margin:var(--sp-2) var(--sp-0); } + .gov-pr-model-prs-toggle { margin:2px 0 0; padding:0 var(--sp-2); border:1px solid var(--border); border-radius:var(--r-pill); background:var(--bg); color:var(--muted); font-size:var(--fs-2xs); cursor:pointer; } + .gov-pr-model-prs-toggle[aria-expanded="true"] { color:var(--text); border-color:var(--amber); } + .gov-pr-model-prlist { margin:0 0 var(--sp-3); padding:var(--sp-2) var(--sp-3); border-left:2px solid var(--border); font-size:0.74rem; color:var(--muted); } + .gov-pr-model-prlist ol { margin:var(--sp-0); padding-left:18px; max-height:320px; overflow-y:auto; } + .gov-pr-model-prlist li { margin:var(--sp-1) var(--sp-0); overflow-wrap:anywhere; } + .gov-pr-model-prlist-outcome.merged { color:var(--green); } + .gov-pr-model-prlist-outcome.open { color:var(--blue); } + .gov-pr-model-prlist-outcome.closed { color:var(--yellow); } .gov-pr-model-legend { display:flex; gap:10px; flex-wrap:wrap; color:var(--muted); font-size:var(--fs-xs); margin-top:var(--sp-4); } .gov-pr-model-legend span::before { content:''; display:inline-block; width:8px; height:8px; border-radius:50%; margin-right:var(--sp-2); vertical-align:middle; } .gov-pr-model-legend .merged::before { background:var(--green); } @@ -33445,6 +33453,11 @@

    All labels

    let govPRModelsData = null; let reviewerAccuracyLoading = false; let reviewerAccuracyData = null; + // Per-model PR list (#18722): the open row's model and a cache keyed by + // window + model, filled on demand from /api/governor/pr-models?model=…. + let govPRModelPRsOpen = ''; + const govPRModelPRsCache = {}; + const govPRModelPRsLoading = {}; function normalizeGovernorPRModelsWindowName(windowName) { return ['7d', '30d', 'all'].includes(windowName) ? windowName : '7d'; @@ -33467,6 +33480,66 @@

    All labels

    } window.setGovernorPRModelsSort = setGovernorPRModelsSort; + function governorPRModelPRsKey(windowName, model) { + return `${normalizeGovernorPRModelsWindowName(windowName)}\u0000${model}`; + } + + async function loadGovernorPRModelPRs(model, windowName = govPRModelsWindow) { + const requestedWindow = normalizeGovernorPRModelsWindowName(windowName); + const key = governorPRModelPRsKey(requestedWindow, model); + if (govPRModelPRsLoading[key] || govPRModelPRsCache[key]) return; + govPRModelPRsLoading[key] = true; + try { + const res = await fetch(`/api/governor/pr-models?window=${encodeURIComponent(requestedWindow)}&model=${encodeURIComponent(model)}`); + const data = res.ok ? await res.json() : null; + govPRModelPRsCache[key] = data && Array.isArray(data.prs) + ? { prs: data.prs, truncated: !!data.prs_truncated } + : { prs: [], truncated: false, error: true }; + } catch (_) { + govPRModelPRsCache[key] = { prs: [], truncated: false, error: true }; + } finally { + delete govPRModelPRsLoading[key]; + renderGovernorFromLastStatus(); + } + } + + function toggleGovernorPRModelPRs(model) { + govPRModelPRsOpen = govPRModelPRsOpen === model ? '' : String(model || ''); + const pending = govPRModelPRsOpen ? loadGovernorPRModelPRs(govPRModelPRsOpen, govPRModelsWindow) : Promise.resolve(); + renderGovernorFromLastStatus(); + return pending; + } + window.toggleGovernorPRModelPRs = toggleGovernorPRModelPRs; + + function governorPRModelPRsToggleHtml(model) { + const open = govPRModelPRsOpen === model; + return ``; + } + + function governorPRModelPRListHtml(model) { + if (govPRModelPRsOpen !== model) return ''; + const entry = govPRModelPRsCache[governorPRModelPRsKey(govPRModelsWindow, model)]; + if (!entry) { + // First open, or the window pill changed while a row was open: fetch on demand. + loadGovernorPRModelPRs(model, govPRModelsWindow); + return '
    Loading PRs…
    '; + } + if (entry.error) return '
    Could not load this model\'s PRs.
    '; + if (!entry.prs.length) return '
    No PRs for this model in the window.
    '; + const outcomeLabel = { merged: 'merged', closed_unmerged: 'closed-unmerged', open: 'open' }; + const items = entry.prs.map(pr => { + const label = `${pr.repo || ''}#${pr.number || ''}`; + const href = pr.url ? ` href="${escapeHtml(pr.url)}" target="_blank" rel="noopener"` : ''; + const outcome = outcomeLabel[pr.outcome] || 'open'; + const title = pr.title ? ` ${escapeHtml(pr.title)}` : ''; + const who = [pr.agent, pr.backend].filter(Boolean).map(escapeHtml).join(' / '); + const firstPass = pr.first_pass ? ' · first pass' : ''; + return `
  • ${escapeHtml(label)}${title} ${outcome} · ${pr.review_rounds || 0} rounds · ${pr.fix_attempts || 0} fixes${firstPass}${who ? ` · ${who}` : ''}
  • `; + }).join(''); + const more = entry.truncated ? `
    Showing the first ${entry.prs.length} PRs, most reworked first.
    ` : ''; + return `
      ${items}
    ${more}
    `; + } + function governorPRModelUnattributed(b) { return !!(b?.effectiveness?.unattributed) || !b?.model || String(b.model).toLowerCase() === 'unknown'; } @@ -33604,7 +33677,7 @@

    All labels

    const scoreLine = eff.rank ? `\nRank #${eff.rank} · score ${(Number(eff.score) || 0).toFixed(3)} = Wilson lower bound(${eff.first_pass_merged ?? '?'}/${eff.merged_prs ?? b.merged ?? 0} first pass)${scoreFormula}` : (unattributed ? '\nUnattributed: no model recorded, listed but not ranked' : `\nUnranked: fewer than ${data.min_merged_prs || 5} merged PRs`); const tip = `${b.model || 'unknown'} via ${backends.join(', ')}${scoreLine}\n${prs} PRs (${share.toFixed(1)}%)\n${b.merged || 0} merged · ${b.open || 0} open · ${b.closed_unmerged || 0} closed-unmerged\nFirst-pass ${values.first_pass}${ci(eff.first_pass_merge_rate_ci || rw.first_pass_merge_rate_ci)} · PR run rate ${values.pr_runs}${measured ? ci(eff.verified_pr_run_rate_ci) : ''} · failure ${values.fail}${measured ? ci(eff.failure_rate_ci) : ''} · nothing-to-ship ${values.no_ship}${measured ? ci(eff.nothing_to_ship_rate_ci) : ''}${measured ? '' : '\n— = no runs recorded, not a measured 0%'}\nAvg rounds ${(rw.avg_review_rounds || 0).toFixed(1)} · avg fix attempts ${(rw.avg_fix_attempts || 0).toFixed(1)}${sources ? '\n\nRaw model ids folded into this row:\n' + sources : ''}${agentBreakdown ? '\n\n' + agentBreakdown : ''}`; return `
    -
    ${rank}${escapeHtml(b.model || 'unknown')}
    ${backendChips}
    +
    ${rank}${escapeHtml(b.model || 'unknown')}
    ${backendChips}${governorPRModelPRsToggleHtml(b.model || 'unknown')}
    @@ -33612,7 +33685,7 @@

    All labels

    ${metrics} -
    `; + ${governorPRModelPRListHtml(b.model || 'unknown')}`; }).join(''); const reworkTable = data && total > 0 ? `
    ModelFirst-passReview roundsFix attemptsFollow-up commitsMedian mergeSample
    From bf728ccad91fcfc5caba20f5bd8d16e0cdbc9943 Mon Sep 17 00:00:00 2001 From: Danathar <6772335+Danathar@users.noreply.github.com> Date: Tue, 17 Nov 2026 12:50:46 -0500 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=A7=AA=20PRs=20by=20model=20header=20?= =?UTF-8?q?test:=20lift=20the=20per-model=20PR=20list=20helpers?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pr_models_header_once.test.js lifts renderGovernorPRModelsTile out of index.html; the row now calls the PR-list toggle and list helpers, so lift them (and stub the open-row state and loader) alongside it. Refs #18722 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01WcWm7qFmFJp26r9LPdmi3t --- src/pkg/dashboard/pr_models_header_once.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/pkg/dashboard/pr_models_header_once.test.js b/src/pkg/dashboard/pr_models_header_once.test.js index e8c14f0bf5..4126707cf9 100644 --- a/src/pkg/dashboard/pr_models_header_once.test.js +++ b/src/pkg/dashboard/pr_models_header_once.test.js @@ -25,6 +25,12 @@ const src = [ pick(/function governorPRModelUnattributed\(b\) \{[\s\S]*?\n \}\n/, 'governorPRModelUnattributed'), pick(/const GOV_PR_MODEL_COLUMNS = \[[\s\S]*?\n \];\n/, 'GOV_PR_MODEL_COLUMNS'), pick(/function governorPRModelRows\(data\) \{[\s\S]*?\n \}\n/, 'governorPRModelRows'), + // Per-model PR list (#18722): rows render a PRs toggle and, when open, the list. + 'let govPRModelPRsOpen = ""; const govPRModelPRsCache = {}; const loadGovernorPRModelPRs = () => {};', + pick(/function normalizeGovernorPRModelsWindowName\(windowName\) \{[\s\S]*?\n \}\n/, 'normalizeGovernorPRModelsWindowName'), + pick(/function governorPRModelPRsKey\(windowName, model\) \{[\s\S]*?\n \}\n/, 'governorPRModelPRsKey'), + pick(/function governorPRModelPRsToggleHtml\(model\) \{[\s\S]*?\n \}\n/, 'governorPRModelPRsToggleHtml'), + pick(/function governorPRModelPRListHtml\(model\) \{[\s\S]*?\n \}\n/, 'governorPRModelPRListHtml'), pick(/function renderGovernorPRModelsTile\(\) \{[\s\S]*?\n \}\n\n function renderGovernor\(/, 'renderGovernorPRModelsTile').replace(/\n\n function renderGovernor\($/, ''), ].join('\n'); const lifted = new Function(src + '; return { render: data => { govPRModelsData = data; return renderGovernorPRModelsTile(); }, rows: governorPRModelRows, columns: GOV_PR_MODEL_COLUMNS };')();
    ModelFirst-passReview roundsFix attemptsFollow-up commitsMedian mergeSample