From 2b33dc97e435c66610074672a2325fa98606f52c Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Tue, 10 Nov 2026 12:28:29 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20stageengine:=20classify=20repo-a?= =?UTF-8?q?uto-merge-disabled=20from=20head=20evidence=20(#17565)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --- ...17565-classify-repo-auto-merge-disabled.md | 1 + src/pkg/stageengine/derive_pr_classify.go | 44 ++++++++++++- .../derive_pr_repo_automerge_off_test.go | 58 ++++++++++++++++ .../stage_goldens/lane-reason-authorkind.json | 24 +++---- .../stage_goldens/lane-reason-modifier.json | 66 +++++++++---------- .../stage_goldens/lane-reason-verdict.json | 36 +++++----- 6 files changed, 165 insertions(+), 64 deletions(-) create mode 100644 changelog.d/fixed-17565-classify-repo-auto-merge-disabled.md create mode 100644 src/pkg/stageengine/derive_pr_repo_automerge_off_test.go diff --git a/changelog.d/fixed-17565-classify-repo-auto-merge-disabled.md b/changelog.d/fixed-17565-classify-repo-auto-merge-disabled.md new file mode 100644 index 0000000000..e33b0411bf --- /dev/null +++ b/changelog.d/fixed-17565-classify-repo-auto-merge-disabled.md @@ -0,0 +1 @@ +- Stage engine: a PR observed on a repo whose auto-merge is off (`repo-auto-merge-disabled`) is now staged from its head evidence (050 / 07x / 085, or 090 "auto-merge off" when approved and green) instead of being dropped as a lane hand-off (#17565). diff --git a/src/pkg/stageengine/derive_pr_classify.go b/src/pkg/stageengine/derive_pr_classify.go index 096d84c957..e94d5a20c2 100644 --- a/src/pkg/stageengine/derive_pr_classify.go +++ b/src/pkg/stageengine/derive_pr_classify.go @@ -251,7 +251,7 @@ func StageHumanApprovalReason(d stageDetail, head string) string { // stageHandoffReasons are reasons that mean "not this lane's PR". var stageHandoffReasons = map[string]bool{ - "not-app-authored": true, trustedBotLaneSkipReason: true, "repo-auto-merge-disabled": true, + "not-app-authored": true, trustedBotLaneSkipReason: true, trustedAuthorReasonAppAuthored: true, contributorLaneReasonAppAuthored: true, contributorLaneReasonNoAuthor: true, "missing-head-sha": true, "fetch-pr": true, "fetch-pr-recheck": true, // A merge to the destination was in flight, so the lane did not look at @@ -473,6 +473,48 @@ func ClassifyStage(o stageObservation) stageVerdict { } return WithHumanApprovalReason(stageVerdict{Stage: stagelabels.ReadyForHumanMerge, Rank: stageRankOwned, Human: true}, humanApprovalReason) } + if reason == "repo-auto-merge-disabled" { + // Auto-merge is off for the repo (hivecommons/hive#17565): nothing + // will merge the head, so its stage comes from the head's own + // evidence and is never 080, 095 or 100. Approved and green parks + // at 090 under the lane reason, the "auto-merge off" human merge. + if HasLabelFold(o.Labels, "needs-rebase") { + return stageVerdict{Stage: fixing, Rank: stageRankOwned} + } + if v, ok := HumanChangeRequestStage(o); ok { + return v + } + if VerdictBlocks(o.Detail) { + return stageVerdict{Stage: fixing, Rank: stageRankOwned, Reason: StageVerdictReason(o.Detail)} + } + if v, ok := RequiresHumanStage(o, stageRankOwned); ok { + return v + } + if d := o.Detail; d.VerdictKnown && d.Verdict.DecisionRequested && (strings.TrimSpace(d.HumanApprover) == "" || strings.TrimSpace(d.HumanApprovalHead) != strings.TrimSpace(o.HeadSHA)) { + // An approve verdict that still asks a question is not ready + // for a merge click: the person owes the decision first. + return stageVerdict{Stage: stagelabels.NeedsDecision, Rank: stageRankOwned, Human: true, Reason: StageVerdictReason(d)} + } + if v, ok := SharedCIDeferredStage(o); ok { + return v + } + if v, ok := BaseBranchRedStage(o); ok { + return v + } + if v, ok := ForkGuardStage(o); ok { + return v + } + if name := o.Detail.RedCheck(o.HeadSHA); name != "" { + return stageVerdict{Stage: fixing, Rank: stageRankOwned, Reason: stageReasonOptionalCheckFailing + name} + } + if o.Detail.SentinelAlert || len(stagelabels.Holds(o.Labels)) > 0 { + return stageVerdict{Stage: stagelabels.NeedsDecision, Rank: stageRankOwned, Human: true} + } + if !AuthorSideDone(o) && humanApprovalReason == "" { + return stageVerdict{Stage: stagelabels.ReviewPending, Rank: stageRankOwned} + } + return WithHumanApprovalReason(stageVerdict{Stage: stagelabels.ReadyForHumanMerge, Rank: stageRankOwned, Human: true}, humanApprovalReason) + } // An open issue the PR closes is held or parked on a person: // removing the issue's label releases the PR on the next sweep. if _, _, _, linked := prstage.ParseLinkedIssueReason(reason); linked || diff --git a/src/pkg/stageengine/derive_pr_repo_automerge_off_test.go b/src/pkg/stageengine/derive_pr_repo_automerge_off_test.go new file mode 100644 index 0000000000..8a1a06c4e7 --- /dev/null +++ b/src/pkg/stageengine/derive_pr_repo_automerge_off_test.go @@ -0,0 +1,58 @@ +package stageengine + +import ( + "testing" + + "github.com/hivecommons/hive/pkg/stageengine/prstage" + "github.com/hivecommons/hive/pkg/stagelabels" +) + +// hivecommons/hive#17565: on a repo whose auto-merge is off nothing merges +// the head, so a lane observation under "repo-auto-merge-disabled" is +// classified from the head's evidence instead of being dropped as a +// hand-off: never 080, 095 or 100, and approved and green is the +// "090 ยท auto-merge off" human merge. +func TestClassifyStageRepoAutoMergeDisabledFromHeadEvidence(t *testing.T) { + const reason = "repo-auto-merge-disabled" + approve := ContributorLaneVerdict{Configured: true, Approved: true, Verdict: "approve"} + for _, tc := range []struct { + name string + labels []string + detail stageDetail + want stagelabels.Stage + wantHuman bool + }{ + {name: "no verdict", want: stagelabels.ReviewPending}, + {name: "approve and green", detail: stageDetail{VerdictKnown: true, Verdict: approve}, want: stagelabels.ReadyForHumanMerge, wantHuman: true}, + {name: "approve and red", detail: stageDetail{VerdictKnown: true, Verdict: approve, RedChecks: []string{"unit"}, RedChecksHead: goldenHead}, want: stagelabels.Fixing}, + {name: "changes requested", detail: stageDetail{VerdictKnown: true, Verdict: ContributorLaneVerdict{Configured: true, Verdict: "changes_requested"}}, want: stagelabels.Fixing}, + {name: "requires human", detail: stageDetail{VerdictKnown: true, Verdict: ContributorLaneVerdict{Configured: true, Verdict: "requires_human"}}, want: stagelabels.NeedsDecision, wantHuman: true}, + {name: "decision requested", detail: stageDetail{VerdictKnown: true, Verdict: ContributorLaneVerdict{Configured: true, Approved: true, Verdict: "approve", DecisionRequested: true}}, want: stagelabels.NeedsDecision, wantHuman: true}, + {name: "needs-rebase label", labels: []string{"needs-rebase"}, detail: stageDetail{VerdictKnown: true, Verdict: approve}, want: stagelabels.Fixing}, + {name: "sentinel alert", detail: stageDetail{VerdictKnown: true, Verdict: approve, SentinelAlert: true}, want: stagelabels.NeedsDecision, wantHuman: true}, + {name: "hold label", labels: []string{"hold"}, detail: stageDetail{VerdictKnown: true, Verdict: approve}, want: stagelabels.NeedsDecision, wantHuman: true}, + } { + t.Run(tc.name, func(t *testing.T) { + for _, lane := range []string{stageLaneSelf, stageLaneTrusted, stageLaneContributor} { + obs := stageObservation{Lane: lane, HeadSHA: goldenHead, Reason: reason, Labels: tc.labels, Detail: tc.detail} + got := ClassifyStage(obs) + want := tc.want + if want == stagelabels.Fixing { + want = FixingStage(stageObservation{Lane: lane}) + } + if got.Stage != want || got.Rank != stageRankOwned || got.Human != tc.wantHuman || got.Terminal { + t.Fatalf("%s lane: got %+v, want stage %v rank owned human=%v", lane, got, want, tc.wantHuman) + } + if want == stagelabels.ReadyForHumanMerge { + recorded := got.Reason + if recorded == "" { + recorded = obs.Reason + } + if hm := prstage.HumanMergeReason(recorded); hm != prstage.HumanMergeReasonAutoMergeOff { + t.Fatalf("%s lane: 090 human-merge reason %q (recorded %q), want %q", lane, hm, recorded, prstage.HumanMergeReasonAutoMergeOff) + } + } + } + }) + } +} diff --git a/src/pkg/stageengine/testdata/stage_goldens/lane-reason-authorkind.json b/src/pkg/stageengine/testdata/stage_goldens/lane-reason-authorkind.json index 8d12d506ed..203a2bca4b 100644 --- a/src/pkg/stageengine/testdata/stage_goldens/lane-reason-authorkind.json +++ b/src/pkg/stageengine/testdata/stage_goldens/lane-reason-authorkind.json @@ -251,10 +251,10 @@ {"name":"contributor-lane/release-hold=v1.2/kind=hive","input":{"observations":[{"lane":"contributor-lane","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, {"name":"contributor-lane/release-hold=v1.2/kind=human","input":{"observations":[{"lane":"contributor-lane","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, {"name":"contributor-lane/release-hold=v1.2/kind=unknown","input":{"observations":[{"lane":"contributor-lane","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}]},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, -{"name":"contributor-lane/repo-auto-merge-disabled/kind=clanker","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/kind=hive","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/kind=human","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/kind=unknown","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}]},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, +{"name":"contributor-lane/repo-auto-merge-disabled/kind=clanker","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/kind=hive","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/kind=human","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/kind=unknown","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}]},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, {"name":"contributor-lane/required-check-failing=unit/kind=clanker","input":{"observations":[{"lane":"contributor-lane","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"required-check-failing:unit"}}, {"name":"contributor-lane/required-check-failing=unit/kind=hive","input":{"observations":[{"lane":"contributor-lane","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"070-fixing","final_reason":"required-check-failing:unit"}}, {"name":"contributor-lane/required-check-failing=unit/kind=human","input":{"observations":[{"lane":"contributor-lane","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"071-needs-author","final_reason":"required-check-failing:unit"}}, @@ -567,10 +567,10 @@ {"name":"self-authored/release-hold=v1.2/kind=hive","input":{"observations":[{"lane":"self-authored","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, {"name":"self-authored/release-hold=v1.2/kind=human","input":{"observations":[{"lane":"self-authored","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, {"name":"self-authored/release-hold=v1.2/kind=unknown","input":{"observations":[{"lane":"self-authored","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}]},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, -{"name":"self-authored/repo-auto-merge-disabled/kind=clanker","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/kind=hive","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/kind=human","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/kind=unknown","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}]},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, +{"name":"self-authored/repo-auto-merge-disabled/kind=clanker","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/kind=hive","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/kind=human","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/kind=unknown","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}]},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, {"name":"self-authored/required-check-failing=unit/kind=clanker","input":{"observations":[{"lane":"self-authored","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"070-fixing","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"required-check-failing:unit"}}, {"name":"self-authored/required-check-failing=unit/kind=hive","input":{"observations":[{"lane":"self-authored","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"required-check-failing:unit"}}, {"name":"self-authored/required-check-failing=unit/kind=human","input":{"observations":[{"lane":"self-authored","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"070-fixing","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"required-check-failing:unit"}}, @@ -883,10 +883,10 @@ {"name":"trusted-author/release-hold=v1.2/kind=hive","input":{"observations":[{"lane":"trusted-author","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, {"name":"trusted-author/release-hold=v1.2/kind=human","input":{"observations":[{"lane":"trusted-author","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, {"name":"trusted-author/release-hold=v1.2/kind=unknown","input":{"observations":[{"lane":"trusted-author","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}]},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, -{"name":"trusted-author/repo-auto-merge-disabled/kind=clanker","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/kind=hive","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/kind=human","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/kind=unknown","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}]},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, +{"name":"trusted-author/repo-auto-merge-disabled/kind=clanker","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/kind=hive","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/kind=human","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/kind=unknown","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}]},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, {"name":"trusted-author/required-check-failing=unit/kind=clanker","input":{"observations":[{"lane":"trusted-author","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"072-returned-to-contributor","final_reason":"required-check-failing:unit"}}, {"name":"trusted-author/required-check-failing=unit/kind=hive","input":{"observations":[{"lane":"trusted-author","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"070-fixing","final_reason":"required-check-failing:unit"}}, {"name":"trusted-author/required-check-failing=unit/kind=human","input":{"observations":[{"lane":"trusted-author","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"required-check-failing:unit"}}, diff --git a/src/pkg/stageengine/testdata/stage_goldens/lane-reason-modifier.json b/src/pkg/stageengine/testdata/stage_goldens/lane-reason-modifier.json index f75304b5c4..4abbc40e3a 100644 --- a/src/pkg/stageengine/testdata/stage_goldens/lane-reason-modifier.json +++ b/src/pkg/stageengine/testdata/stage_goldens/lane-reason-modifier.json @@ -820,17 +820,17 @@ {"name":"contributor-lane/release-hold=v1.2/mod=sharedci+redcheck","input":{"observations":[{"lane":"contributor-lane","reason":"release-hold:v1.2","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"shared-ci-incident:9100","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"shared-ci-incident:9100"}}, {"name":"contributor-lane/repo-auto-merge-disabled/mod=err","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","err":true,"detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, {"name":"contributor-lane/repo-auto-merge-disabled/mod=err+approve","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","err":true,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"clanker"},"want":{"stage":"080-awaiting-merge-admission","rank":1,"reason":"","role":"untrusted","lane":"contributor-lane","final_stage":"080-awaiting-merge-admission","final_reason":"repo-auto-merge-disabled"}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=label=author_hive","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["author/hive"],"detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"trusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=label=needs-rebase","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["Needs-Rebase"],"detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=merged","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","merged":true,"detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=no-head","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=redcheck+approve","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"},"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=redcheck=same-head","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["docs-link-check","lint"],"red_checks_head":"abc1234def"}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=redcheck=stale-head","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["lint"],"red_checks_head":"0ld0000000"}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=role=trusted","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"role":"trusted"}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"trusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=sharedci","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=sharedci+approve","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/mod=sharedci+redcheck","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=label=author_hive","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["author/hive"],"detail":{}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"trusted","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=label=needs-rebase","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["Needs-Rebase"],"detail":{}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=merged","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","merged":true,"detail":{}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=no-head","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","detail":{}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=redcheck+approve","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"},"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"optional-check-failing:lint","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"optional-check-failing:lint"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=redcheck=same-head","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["docs-link-check","lint"],"red_checks_head":"abc1234def"}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"optional-check-failing:docs-link-check","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"optional-check-failing:docs-link-check"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=redcheck=stale-head","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["lint"],"red_checks_head":"0ld0000000"}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=role=trusted","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"role":"trusted"}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"trusted","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=sharedci","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=sharedci+approve","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"clanker"},"want":{"stage":"090-ready-for-human-merge","rank":3,"reason":"","role":"none","human":true,"lane":"contributor-lane","final_stage":"085-needs-decision","final_reason":"repo-auto-merge-disabled","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict"]}}, +{"name":"contributor-lane/repo-auto-merge-disabled/mod=sharedci+redcheck","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"shared-ci-incident:9100","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"shared-ci-incident:9100"}}, {"name":"contributor-lane/required-check-failing=unit/mod=err","input":{"observations":[{"lane":"contributor-lane","reason":"required-check-failing:unit","head_sha":"abc1234def","err":true,"detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, {"name":"contributor-lane/required-check-failing=unit/mod=err+approve","input":{"observations":[{"lane":"contributor-lane","reason":"required-check-failing:unit","head_sha":"abc1234def","err":true,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, {"name":"contributor-lane/required-check-failing=unit/mod=label=author_hive","input":{"observations":[{"lane":"contributor-lane","reason":"required-check-failing:unit","head_sha":"abc1234def","labels":["author/hive"],"detail":{}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"trusted","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"required-check-failing:unit"}}, @@ -1847,17 +1847,17 @@ {"name":"self-authored/release-hold=v1.2/mod=sharedci+redcheck","input":{"observations":[{"lane":"self-authored","reason":"release-hold:v1.2","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"shared-ci-incident:9100","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"shared-ci-incident:9100"}}, {"name":"self-authored/repo-auto-merge-disabled/mod=err","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","err":true,"detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, {"name":"self-authored/repo-auto-merge-disabled/mod=err+approve","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","err":true,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"hive"},"want":{"stage":"080-awaiting-merge-admission","rank":1,"reason":"","role":"untrusted","lane":"self-authored","final_stage":"080-awaiting-merge-admission","final_reason":"repo-auto-merge-disabled"}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=label=author_hive","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["author/hive"],"detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"trusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=label=needs-rebase","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["Needs-Rebase"],"detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=merged","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","merged":true,"detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=no-head","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=redcheck+approve","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"},"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=redcheck=same-head","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["docs-link-check","lint"],"red_checks_head":"abc1234def"}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=redcheck=stale-head","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["lint"],"red_checks_head":"0ld0000000"}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=role=trusted","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"role":"trusted"}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"trusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=sharedci","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=sharedci+approve","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/mod=sharedci+redcheck","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=label=author_hive","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["author/hive"],"detail":{}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"trusted","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=label=needs-rebase","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["Needs-Rebase"],"detail":{}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=merged","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","merged":true,"detail":{}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=no-head","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","detail":{}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=redcheck+approve","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"},"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"optional-check-failing:lint","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"optional-check-failing:lint"}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=redcheck=same-head","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["docs-link-check","lint"],"red_checks_head":"abc1234def"}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"optional-check-failing:docs-link-check","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"optional-check-failing:docs-link-check"}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=redcheck=stale-head","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["lint"],"red_checks_head":"0ld0000000"}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=role=trusted","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"role":"trusted"}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"trusted","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=sharedci","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=sharedci+approve","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"hive"},"want":{"stage":"090-ready-for-human-merge","rank":3,"reason":"","role":"none","human":true,"lane":"self-authored","final_stage":"085-needs-decision","final_reason":"repo-auto-merge-disabled","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict"]}}, +{"name":"self-authored/repo-auto-merge-disabled/mod=sharedci+redcheck","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"shared-ci-incident:9100","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"shared-ci-incident:9100"}}, {"name":"self-authored/required-check-failing=unit/mod=err","input":{"observations":[{"lane":"self-authored","reason":"required-check-failing:unit","head_sha":"abc1234def","err":true,"detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, {"name":"self-authored/required-check-failing=unit/mod=err+approve","input":{"observations":[{"lane":"self-authored","reason":"required-check-failing:unit","head_sha":"abc1234def","err":true,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, {"name":"self-authored/required-check-failing=unit/mod=label=author_hive","input":{"observations":[{"lane":"self-authored","reason":"required-check-failing:unit","head_sha":"abc1234def","labels":["author/hive"],"detail":{}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"","role":"trusted","lane":"self-authored","final_stage":"070-fixing","final_reason":"required-check-failing:unit"}}, @@ -2874,17 +2874,17 @@ {"name":"trusted-author/release-hold=v1.2/mod=sharedci+redcheck","input":{"observations":[{"lane":"trusted-author","reason":"release-hold:v1.2","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"shared-ci-incident:9100","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"shared-ci-incident:9100"}}, {"name":"trusted-author/repo-auto-merge-disabled/mod=err","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","err":true,"detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, {"name":"trusted-author/repo-auto-merge-disabled/mod=err+approve","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","err":true,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"human"},"want":{"stage":"080-awaiting-merge-admission","rank":1,"reason":"","role":"untrusted","lane":"trusted-author","final_stage":"080-awaiting-merge-admission","final_reason":"repo-auto-merge-disabled"}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=label=author_hive","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["author/hive"],"detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"trusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=label=needs-rebase","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["Needs-Rebase"],"detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=merged","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","merged":true,"detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=no-head","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=redcheck+approve","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"},"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=redcheck=same-head","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["docs-link-check","lint"],"red_checks_head":"abc1234def"}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=redcheck=stale-head","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["lint"],"red_checks_head":"0ld0000000"}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=role=trusted","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"role":"trusted"}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"trusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=sharedci","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=sharedci+approve","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/mod=sharedci+redcheck","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=label=author_hive","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["author/hive"],"detail":{}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"trusted","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=label=needs-rebase","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","labels":["Needs-Rebase"],"detail":{}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=merged","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","merged":true,"detail":{}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=no-head","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","detail":{}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=redcheck+approve","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"},"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"optional-check-failing:lint","role":"none","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"optional-check-failing:lint"}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=redcheck=same-head","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["docs-link-check","lint"],"red_checks_head":"abc1234def"}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"optional-check-failing:docs-link-check","role":"none","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"optional-check-failing:docs-link-check"}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=redcheck=stale-head","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"red_checks":["lint"],"red_checks_head":"0ld0000000"}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=role=trusted","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"role":"trusted"}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"trusted","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=sharedci","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=sharedci+approve","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"human"},"want":{"stage":"090-ready-for-human-merge","rank":3,"reason":"","role":"none","human":true,"lane":"trusted-author","final_stage":"085-needs-decision","final_reason":"repo-auto-merge-disabled","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict"]}}, +{"name":"trusted-author/repo-auto-merge-disabled/mod=sharedci+redcheck","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","shared_ci_incident":9100,"detail":{"red_checks":["lint"],"red_checks_head":"abc1234def"}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"shared-ci-incident:9100","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"shared-ci-incident:9100"}}, {"name":"trusted-author/required-check-failing=unit/mod=err","input":{"observations":[{"lane":"trusted-author","reason":"required-check-failing:unit","head_sha":"abc1234def","err":true,"detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, {"name":"trusted-author/required-check-failing=unit/mod=err+approve","input":{"observations":[{"lane":"trusted-author","reason":"required-check-failing:unit","head_sha":"abc1234def","err":true,"detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, {"name":"trusted-author/required-check-failing=unit/mod=label=author_hive","input":{"observations":[{"lane":"trusted-author","reason":"required-check-failing:unit","head_sha":"abc1234def","labels":["author/hive"],"detail":{}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"trusted","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"required-check-failing:unit"}}, diff --git a/src/pkg/stageengine/testdata/stage_goldens/lane-reason-verdict.json b/src/pkg/stageengine/testdata/stage_goldens/lane-reason-verdict.json index f272c25dea..f3e37c940c 100644 --- a/src/pkg/stageengine/testdata/stage_goldens/lane-reason-verdict.json +++ b/src/pkg/stageengine/testdata/stage_goldens/lane-reason-verdict.json @@ -755,18 +755,18 @@ {"name":"contributor-lane/release-hold=v1.2/verdict=requires_human-human-approved-stale","input":{"observations":[{"lane":"contributor-lane","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human"},"human_approver":"clubanderson","human_approval_head":"0ld0000000"}}],"author_kind":"clanker"},"want":{"stage":"085-needs-decision","rank":3,"reason":"reviewer-verdict:requires_human","role":"none","human":true,"lane":"contributor-lane","final_stage":"085-needs-decision","final_reason":"reviewer-verdict:requires_human","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict","the automerge lane will not merge this unattended"]}}, {"name":"contributor-lane/release-hold=v1.2/verdict=requires_human-policy-owned","input":{"observations":[{"lane":"contributor-lane","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human","human_summaries":["correctness requires human: LaneQueuedWork is plumbed but never populated; add the producer in AgentActivityFor."],"hive_authored_known":true}}}],"author_kind":"clanker"},"want":{"stage":"085-needs-decision","rank":3,"reason":"reviewer-verdict:requires_human","role":"none","human":true,"lane":"contributor-lane","final_stage":"085-needs-decision","final_reason":"reviewer-verdict:requires_human","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict","the automerge lane will not merge this unattended"]}}, {"name":"contributor-lane/release-hold=v1.2/verdict=unconfigured","input":{"observations":[{"lane":"contributor-lane","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{"verdict":{}}}],"author_kind":"clanker"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=approve","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=changes_requested","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=decision_requested","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve","decision_requested":true,"decision_question":"@clubanderson should decide."}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=incomplete","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"incomplete"}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=none","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=reject","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"reject"}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human"}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human-concrete","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human","human_summaries":["correctness requires human: LaneQueuedWork is plumbed but never populated; add the producer in AgentActivityFor."]}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human-human-approved","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human"},"human_approver":"clubanderson","human_approval_head":"abc1234def"}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human-human-approved-stale","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human"},"human_approver":"clubanderson","human_approval_head":"0ld0000000"}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human-policy-owned","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human","human_summaries":["correctness requires human: LaneQueuedWork is plumbed but never populated; add the producer in AgentActivityFor."],"hive_authored_known":true}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, -{"name":"contributor-lane/repo-auto-merge-disabled/verdict=unconfigured","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{}}}],"author_kind":"clanker"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"contributor-lane","skipped":true}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=approve","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"clanker"},"want":{"stage":"090-ready-for-human-merge","rank":3,"reason":"","role":"none","human":true,"lane":"contributor-lane","final_stage":"085-needs-decision","final_reason":"repo-auto-merge-disabled","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict"]}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=changes_requested","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"reviewer-verdict:changes_requested","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"reviewer-verdict:changes_requested"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=decision_requested","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve","decision_requested":true,"decision_question":"@clubanderson should decide."}}}],"author_kind":"clanker"},"want":{"stage":"085-needs-decision","rank":3,"reason":"contributor-lane:decision-requested","role":"none","human":true,"lane":"contributor-lane","final_stage":"085-needs-decision","final_reason":"contributor-lane:decision-requested","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict","the automerge lane will not merge this unattended"]}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=incomplete","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"incomplete"}}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=none","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=reject","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"reject"}}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"reviewer-verdict:reject","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"reviewer-verdict:reject"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human"}}}],"author_kind":"clanker"},"want":{"stage":"085-needs-decision","rank":3,"reason":"reviewer-verdict:requires_human","role":"none","human":true,"lane":"contributor-lane","final_stage":"085-needs-decision","final_reason":"reviewer-verdict:requires_human","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict","the automerge lane will not merge this unattended"]}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human-concrete","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human","human_summaries":["correctness requires human: LaneQueuedWork is plumbed but never populated; add the producer in AgentActivityFor."]}}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"reviewer-verdict:changes_requested","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"reviewer-verdict:changes_requested"}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human-human-approved","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human"},"human_approver":"clubanderson","human_approval_head":"abc1234def"}}],"author_kind":"clanker"},"want":{"stage":"090-ready-for-human-merge","rank":3,"reason":"reviewer-verdict:requires_human:human-approved@clubanderson","role":"none","human":true,"lane":"contributor-lane","final_stage":"085-needs-decision","final_reason":"reviewer-verdict:requires_human:human-approved@clubanderson","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict"]}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human-human-approved-stale","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human"},"human_approver":"clubanderson","human_approval_head":"0ld0000000"}}],"author_kind":"clanker"},"want":{"stage":"085-needs-decision","rank":3,"reason":"reviewer-verdict:requires_human","role":"none","human":true,"lane":"contributor-lane","final_stage":"085-needs-decision","final_reason":"reviewer-verdict:requires_human","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict","the automerge lane will not merge this unattended"]}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=requires_human-policy-owned","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"requires_human","human_summaries":["correctness requires human: LaneQueuedWork is plumbed but never populated; add the producer in AgentActivityFor."],"hive_authored_known":true}}}],"author_kind":"clanker"},"want":{"stage":"085-needs-decision","rank":3,"reason":"reviewer-verdict:requires_human","role":"none","human":true,"lane":"contributor-lane","final_stage":"085-needs-decision","final_reason":"reviewer-verdict:requires_human","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict","the automerge lane will not merge this unattended"]}}, +{"name":"contributor-lane/repo-auto-merge-disabled/verdict=unconfigured","input":{"observations":[{"lane":"contributor-lane","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{}}}],"author_kind":"clanker"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, {"name":"contributor-lane/required-check-failing=unit/verdict=approve","input":{"observations":[{"lane":"contributor-lane","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"required-check-failing:unit"}}, {"name":"contributor-lane/required-check-failing=unit/verdict=changes_requested","input":{"observations":[{"lane":"contributor-lane","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"reviewer-verdict:changes_requested","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"reviewer-verdict:changes_requested"}}, {"name":"contributor-lane/required-check-failing=unit/verdict=decision_requested","input":{"observations":[{"lane":"contributor-lane","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve","decision_requested":true,"decision_question":"@clubanderson should decide."}}}],"author_kind":"clanker"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"contributor-lane","final_stage":"072-returned-to-contributor","final_reason":"required-check-failing:unit"}}, @@ -1136,9 +1136,9 @@ {"name":"self-authored/release-hold=v1.2/verdict=approve","input":{"observations":[{"lane":"self-authored","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"hive"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, {"name":"self-authored/release-hold=v1.2/verdict=changes_requested","input":{"observations":[{"lane":"self-authored","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"reviewer-verdict:changes_requested","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"reviewer-verdict:changes_requested"}}, {"name":"self-authored/release-hold=v1.2/verdict=none","input":{"observations":[{"lane":"self-authored","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, -{"name":"self-authored/repo-auto-merge-disabled/verdict=approve","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/verdict=changes_requested","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, -{"name":"self-authored/repo-auto-merge-disabled/verdict=none","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"self-authored","skipped":true}}, +{"name":"self-authored/repo-auto-merge-disabled/verdict=approve","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"hive"},"want":{"stage":"090-ready-for-human-merge","rank":3,"reason":"","role":"none","human":true,"lane":"self-authored","final_stage":"085-needs-decision","final_reason":"repo-auto-merge-disabled","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict"]}}, +{"name":"self-authored/repo-auto-merge-disabled/verdict=changes_requested","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"reviewer-verdict:changes_requested","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"reviewer-verdict:changes_requested"}}, +{"name":"self-authored/repo-auto-merge-disabled/verdict=none","input":{"observations":[{"lane":"self-authored","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, {"name":"self-authored/required-check-failing=unit/verdict=approve","input":{"observations":[{"lane":"self-authored","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"required-check-failing:unit"}}, {"name":"self-authored/required-check-failing=unit/verdict=changes_requested","input":{"observations":[{"lane":"self-authored","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"reviewer-verdict:changes_requested","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"reviewer-verdict:changes_requested"}}, {"name":"self-authored/required-check-failing=unit/verdict=none","input":{"observations":[{"lane":"self-authored","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"hive"},"want":{"stage":"070-fixing","rank":3,"reason":"","role":"none","lane":"self-authored","final_stage":"070-fixing","final_reason":"required-check-failing:unit"}}, @@ -1373,9 +1373,9 @@ {"name":"trusted-author/release-hold=v1.2/verdict=approve","input":{"observations":[{"lane":"trusted-author","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"human"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, {"name":"trusted-author/release-hold=v1.2/verdict=changes_requested","input":{"observations":[{"lane":"trusted-author","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"reviewer-verdict:changes_requested","role":"none","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"reviewer-verdict:changes_requested"}}, {"name":"trusted-author/release-hold=v1.2/verdict=none","input":{"observations":[{"lane":"trusted-author","reason":"release-hold:v1.2","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"100-merge-queue","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"100-merge-queue","final_reason":"release-hold:v1.2"}}, -{"name":"trusted-author/repo-auto-merge-disabled/verdict=approve","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/verdict=changes_requested","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, -{"name":"trusted-author/repo-auto-merge-disabled/verdict=none","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"none","rank":0,"reason":"","role":"untrusted","lane":"trusted-author","skipped":true}}, +{"name":"trusted-author/repo-auto-merge-disabled/verdict=approve","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"human"},"want":{"stage":"090-ready-for-human-merge","rank":3,"reason":"","role":"none","human":true,"lane":"trusted-author","final_stage":"085-needs-decision","final_reason":"repo-auto-merge-disabled","route_reasons":["no reviewer agent is configured, so this head will never get a swarm verdict"]}}, +{"name":"trusted-author/repo-auto-merge-disabled/verdict=changes_requested","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"reviewer-verdict:changes_requested","role":"none","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"reviewer-verdict:changes_requested"}}, +{"name":"trusted-author/repo-auto-merge-disabled/verdict=none","input":{"observations":[{"lane":"trusted-author","reason":"repo-auto-merge-disabled","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"050-review-pending","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"050-review-pending","final_reason":"repo-auto-merge-disabled"}}, {"name":"trusted-author/required-check-failing=unit/verdict=approve","input":{"observations":[{"lane":"trusted-author","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"approved":true,"verdict":"approve"}}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"required-check-failing:unit"}}, {"name":"trusted-author/required-check-failing=unit/verdict=changes_requested","input":{"observations":[{"lane":"trusted-author","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{"verdict":{"configured":true,"verdict":"changes_requested"}}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"reviewer-verdict:changes_requested","role":"none","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"reviewer-verdict:changes_requested"}}, {"name":"trusted-author/required-check-failing=unit/verdict=none","input":{"observations":[{"lane":"trusted-author","reason":"required-check-failing:unit","head_sha":"abc1234def","detail":{}}],"author_kind":"human"},"want":{"stage":"071-needs-author","rank":3,"reason":"","role":"none","lane":"trusted-author","final_stage":"071-needs-author","final_reason":"required-check-failing:unit"}},