diff --git a/changed-gate-fold-tap-target.md b/changed-gate-fold-tap-target.md new file mode 100644 index 0000000000..e47dc05587 --- /dev/null +++ b/changed-gate-fold-tap-target.md @@ -0,0 +1 @@ +Activity Monitor: the human-gate pill folds its verbs at render time (three on the strip tier, one plus `…` at ≤1100px), keeps the folded verbs in a template until `…` opens, and gives the `…` button its 44px tap target — the row holds no hidden buttons for the header-geometry probe to reject. diff --git a/changelog.d/fixed-17515.md b/changelog.d/fixed-17515.md new file mode 100644 index 0000000000..d0a22d0bcd --- /dev/null +++ b/changelog.d/fixed-17515.md @@ -0,0 +1 @@ +- dashboard: fold the human-gate verbs at render time; keeps its 44px tap target (#17515) diff --git a/src/pkg/dashboard/stage_tracker_human_gate_test.go b/src/pkg/dashboard/stage_tracker_human_gate_test.go index 0eb5a4c8f7..5fe49ba69b 100644 --- a/src/pkg/dashboard/stage_tracker_human_gate_test.go +++ b/src/pkg/dashboard/stage_tracker_human_gate_test.go @@ -15,6 +15,7 @@ func stageTrackerHumanGateJS(t *testing.T, html string) string { jsConstLine(t, html, "STAGE_TRACKER_GATE_WORD"), jsConstLine(t, html, "STAGE_TRACKER_GATE_SETTLING"), jsConstLine(t, html, "STAGE_TRACKER_GATE_VISIBLE"), + jsConstLine(t, html, "STAGE_TRACKER_GATE_FOLD_QUERY"), jsConstBlock(t, html, "STAGE_TRACKER_GATE_VERBS"), jsConstLine(t, html, "STAGE_TRACKER_GATE_ORDER"), jsConstLine(t, html, "STAGE_TRACKER_GATE_PR_ONLY"), @@ -28,6 +29,7 @@ func stageTrackerHumanGateJS(t *testing.T, html string) string { jsFunc(t, html, "stageTrackerHumanGateTip"), jsFunc(t, html, "stageTrackerHumanGateVerbState"), jsFunc(t, html, "stageTrackerHumanGateVerbHtml"), + jsFunc(t, html, "stageTrackerHumanGateVisible"), jsFunc(t, html, "stageTrackerHumanGateHtml"), }, "\n") } @@ -130,8 +132,8 @@ assert.strictEqual(reasons(row), 'review sentinel', 'review verdict + sentinel a assert.strictEqual(gateWord(row), 'Needs human · review, sentinel'); assert.ok(gateTip(row).includes(question.replace(/\?/g, '?')) && gateTip(row).includes('touches .github/workflows'), 'the status hover is the question and the rule: ' + gateTip(row)); assert.deepStrictEqual(verbs(row), ['Approve', 'Request changes…', 'Let hive decide', 'Confirm safe'], 'union of the review and sentinel verb sets, de-duplicated'); -assert.ok(row.includes('data-ham-gate-overflow="1"') && /
]*>[\s\S]*?Confirm safe/.test(row), 'the fourth verb folds into the … menu: ' + row); -assert.ok(!/data-ham-gate-inline[^>]*>Confirm safe/.test(row) && /data-ham-gate-inline[^>]*>Let hive decide/.test(row), 'menu copies of inline verbs are marked for the phone tier'); +assert.ok(row.includes('data-ham-gate-more') && /