From 62cdada93bfa41e7e8c55ef72ffff9034046b79b Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Sat, 7 Nov 2026 21:49:48 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(mobile-shots):=20phone-chrom?= =?UTF-8?q?e=20probe=20credits=20the=20fixture=20note=20when=20counting=20?= =?UTF-8?q?visible=20rows?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The acceptance fixture prefixes the Activity monitor list with a provenance note that real renders do not have. The probe already subtracts it from the chrome measurement but not from the row-visibility check, so on a 375×667 phone the ~435px first row (issue with two nested PRs) ends below the viewport only because of the note, and every PR since #17176 fails tracker-phone-chrome at that viewport. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --- changelog.d/fixed-phone-chrome-probe-fixture-note.md | 1 + src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 changelog.d/fixed-phone-chrome-probe-fixture-note.md diff --git a/changelog.d/fixed-phone-chrome-probe-fixture-note.md b/changelog.d/fixed-phone-chrome-probe-fixture-note.md new file mode 100644 index 0000000000..0851e36e1a --- /dev/null +++ b/changelog.d/fixed-phone-chrome-probe-fixture-note.md @@ -0,0 +1 @@ +- The Activity monitor phone-chrome acceptance probe credits the fixture-only provenance note back when counting fully visible rows, so the 375×667 run no longer fails every dashboard PR on a row the real render shows. diff --git a/src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js b/src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js index 210701156d..4542953357 100644 --- a/src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js +++ b/src/pkg/dashboard/webstatic/testdata/tracker-phone-chrome.js @@ -52,7 +52,9 @@ measurements.fixtureNote = note ? Math.round(rect(note).height + parseFloat(noteStyle.marginTop) + parseFloat(noteStyle.marginBottom)) : 0; measurements.chrome = Math.round(rect(first).top - rect(header).bottom - measurements.fixtureNote); assert(measurements.chrome <= maxChromePx, 'chrome between the section header and the first row is ' + measurements.chrome + 'px (max ' + maxChromePx + ')'); - measurements.rowsFullyVisible = rows.filter(row => { const box = rect(row); return box.top >= navbar - 1 && box.bottom <= innerHeight + 1; }).length; + // The note also pushes every row down by its own height, so credit it + // back here too: a 375×667 phone shows the first row without it. + measurements.rowsFullyVisible = rows.filter(row => { const box = rect(row); return box.top >= navbar - 1 && box.bottom - measurements.fixtureNote <= innerHeight + 1; }).length; assert(measurements.rowsFullyVisible >= 1, 'at least one row is fully visible with the section header at the top of the viewport'); } const sticky = document.getElementById('activity-monitor-sticky');