From 99a9a6d805af9bc492833b79e32319868a666861 Mon Sep 17 00:00:00 2001 From: Andrew Anderson Date: Sat, 7 Nov 2026 16:18:49 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20release:=20keep=20the=20push=5Fl?= =?UTF-8?q?ine=20script=20free=20of=20workflow=20expressions?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A `${{ github.repository }}` mention in a bash comment inside the push_line step made GitHub evaluate the whole script as an expression; after the #17083 growth it passed the 21000-character limit, so every event since bde4411c9 has reported 'Invalid workflow file … Exceeded max expression length 21000' for tagged-release.yml and no release has been considered on v5 or v6. Reword the comment; the script's value comes from $GITHUB_REPOSITORY already. Signed-off-by: Andrew Anderson --- .github/workflows/tagged-release.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tagged-release.yml b/.github/workflows/tagged-release.yml index 7da7e69216..38f60f68eb 100644 --- a/.github/workflows/tagged-release.yml +++ b/.github/workflows/tagged-release.yml @@ -1278,11 +1278,15 @@ jobs: } while true; do # $GITHUB_REPOSITORY (runner-provided) rather than the - # ${{ github.repository }} expression other steps use: this step's - # script is extracted verbatim and run under plain bash by + # github.repository workflow expression other steps use: this + # step's script is extracted verbatim and run under plain bash by # test-release-push-retry.sh, where an unexpanded workflow # expression is a bash bad-substitution. Same value, and it keeps - # the step testable. + # the step testable. The script must also stay free of workflow + # expressions for a second reason: one anywhere in it makes + # GitHub evaluate the whole 20k-char block as an expression, + # which exceeds its 21000-char limit and breaks the workflow file + # for every event (seen 2026-11-07 after the #17083 growth). # # Do NOT write an empty workflow-expression delimiter pair in this # comment to illustrate the point. GitHub's workflow parser scans