From 8bbadd36ee5ce7fc73bb59ff9202bd68d86b3e77 Mon Sep 17 00:00:00 2001 From: Andrew Anderson Date: Sat, 7 Nov 2026 15:40:33 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20ci:=20native-queue=20contract=20?= =?UTF-8?q?test=20resolves=20the=20pin=20against=20release=5Flines?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit v6 is a release_lines entry since the v6 release-line cut, so native-queue-policy.yml's pin reads [-v4] (v5 and v6 covered) rather than [v6, -v4]; the test asserted the old literal and would fail the next time pr-auto-update-test.yml ran on v5. Signed-off-by: Andrew Anderson --- .github/scripts/test-native-queue-workflows.py | 8 +++++++- changelog.d/fixed-native-queue-contract-release-lines.md | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 changelog.d/fixed-native-queue-contract-release-lines.md diff --git a/.github/scripts/test-native-queue-workflows.py b/.github/scripts/test-native-queue-workflows.py index e598728df9..79c7b094cf 100644 --- a/.github/scripts/test-native-queue-workflows.py +++ b/.github/scripts/test-native-queue-workflows.py @@ -59,7 +59,13 @@ def test_owned_gate_uses_trusted_base_not_member_code(self): "${{ github.event.merge_group.base_sha || format('refs/heads/{0}', github.event.pull_request.base.ref) }}") self.assertFalse(checkout["persist-credentials"]) manifest = yaml.safe_load((ROOT / ".github/release-lines.yml").read_text()) - self.assertEqual(manifest["pinned"]["native-queue-policy.yml"], ["v6", "-v4"]) + # The admission gate covers the active feature lines (v5 and v6) and + # not feature-frozen v4, however the manifest spells that: v6 became a + # `release_lines` entry on 2026-11-07, so it is covered without an extra. + pinned = manifest["pinned"]["native-queue-policy.yml"] + covered = set(manifest["release_lines"]) | {p for p in pinned if not p.startswith("-")} + covered -= {p[1:] for p in pinned if p.startswith("-")} + self.assertEqual(sorted(covered), ["v5", "v6"]) def test_owned_gate_retriggers_never_cancel_the_evidence_wait(self): # Stage-label flips re-fire the PR-target run every few minutes; a diff --git a/changelog.d/fixed-native-queue-contract-release-lines.md b/changelog.d/fixed-native-queue-contract-release-lines.md new file mode 100644 index 0000000000..0ed384ba87 --- /dev/null +++ b/changelog.d/fixed-native-queue-contract-release-lines.md @@ -0,0 +1 @@ +- The native-queue workflow contract test asserted `native-queue-policy.yml`'s release-lines pin as the literal `[v6, -v4]`; with v6 a `release_lines` entry the pin reads `[-v4]`, so the test now resolves the pin against `release_lines` and checks that v5 and v6 are covered.