From cb9a3198f5422c67232709d2db07a7a3b6470669 Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Thu, 5 Nov 2026 21:22:44 -0500 Subject: [PATCH] fix(selfreport): classify watchdog agent credential failures Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --- changelog.d/fixed-selfreport-credential-class.md | 1 + src/pkg/fleetreport/runtime.go | 2 +- src/pkg/fleetreport/runtime_test.go | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelog.d/fixed-selfreport-credential-class.md diff --git a/changelog.d/fixed-selfreport-credential-class.md b/changelog.d/fixed-selfreport-credential-class.md new file mode 100644 index 0000000000..8bd8772e1c --- /dev/null +++ b/changelog.d/fixed-selfreport-credential-class.md @@ -0,0 +1 @@ +- The watchdog's `agent credential failure` log line is now reported under the existing `agent_login_required` selfreport class instead of `unclassified_error_repeated`, so owners are pointed at re-authenticating the agent backend rather than a generic defect report ([#16861](https://github.com/hivecommons/hive/issues/16861)). diff --git a/src/pkg/fleetreport/runtime.go b/src/pkg/fleetreport/runtime.go index 3e0b28d3e0..d4af257b48 100644 --- a/src/pkg/fleetreport/runtime.go +++ b/src/pkg/fleetreport/runtime.go @@ -200,7 +200,7 @@ var Classes = map[string]ClassSpec{ ClassSHAPollCommitMsgUnavail: {Component: "github-client", Severity: "low", MinCount: unclassifiedRepeatCount, Window: unclassifiedRepeatWindow, IdleClear: unclassifiedIdleClear, LogFed: true, Keywords: []string{"sha poll: commit message fetch non-200"}}, ClassKickFreshnessWithheld: {Component: "agent-runtime", Severity: "low", MinCount: unclassifiedRepeatCount, Window: unclassifiedRepeatWindow, IdleClear: unclassifiedIdleClear, LogFed: true, Keywords: []string{"kick withheld: every ref failed the freshness check"}}, ClassModelsEndpointEmpty: {Component: "dashboard", Severity: "low", MinCount: unclassifiedRepeatCount, Window: unclassifiedRepeatWindow, IdleClear: unclassifiedIdleClear, LogFed: true, Keywords: []string{"no models found from any endpoint"}}, - ClassAgentLoginRequired: {Component: "agent-runtime", Severity: "medium", MinCount: unclassifiedRepeatCount, Window: unclassifiedRepeatWindow, IdleClear: unclassifiedIdleClear, LogFed: true, Keywords: []string{"login required detected"}}, + ClassAgentLoginRequired: {Component: "agent-runtime", Severity: "medium", MinCount: unclassifiedRepeatCount, Window: unclassifiedRepeatWindow, IdleClear: unclassifiedIdleClear, LogFed: true, Keywords: []string{"login required detected", "watchdog: agent credential failure"}}, ClassPRRequestHeadUnpushed: {Component: "github-relay", Severity: "medium", MinCount: unclassifiedRepeatCount, Window: unclassifiedRepeatWindow, IdleClear: unclassifiedIdleClear, LogFed: true, Keywords: []string{"head branch is not on the remote"}}, ClassIOScanClassifierUnavail: {Component: "inference-gateway", Severity: "medium", MinCount: 1, IdleClear: unclassifiedIdleClear, LogFed: true, Keywords: []string{"ioscan classifier failed closed", "ioscan classifier failed open", "ioscan fail-closed blocked kick", "ioscan fail-closed blocked held-pr coordination kick"}}, ClassGitHubFetchTransient: {Component: "github-client", Severity: "low", MinCount: unclassifiedRepeatCount, Window: unclassifiedRepeatWindow, IdleClear: unclassifiedIdleClear, LogFed: true, Keywords: []string{"channel commit date: fetch failed"}}, diff --git a/src/pkg/fleetreport/runtime_test.go b/src/pkg/fleetreport/runtime_test.go index 38f27d2e94..b8e8918db6 100644 --- a/src/pkg/fleetreport/runtime_test.go +++ b/src/pkg/fleetreport/runtime_test.go @@ -1096,6 +1096,7 @@ func TestRecurringRuntimeMessagesAreClassified(t *testing.T) { "login required detected": ClassAgentLoginRequired, "pr-request watcher: head branch is not on the remote — the agent's push did not authenticate": ClassPRRequestHeadUnpushed, "ioscan classifier failed closed; text withheld": ClassIOScanClassifierUnavail, + "watchdog: agent credential failure": ClassAgentLoginRequired, "ioscan classifier failed open; text passes on unclassified": ClassIOScanClassifierUnavail, "ioscan fail-closed blocked kick": ClassIOScanClassifierUnavail, "ioscan fail-closed blocked held-PR coordination kick": ClassIOScanClassifierUnavail,