From f8ace51a373c91b63bd6a6b6ee7c5fe24d7a829f Mon Sep 17 00:00:00 2001 From: Karibhou Date: Thu, 5 Nov 2026 15:03:32 +0000 Subject: [PATCH 1/2] docs: correct Prow LGTM error comment Hive-Run: hivecommons/hive#16761 Hive-Plan: correct bindProwLgtm documentation Hive-Spec: issue-16761#reporting-error Signed-off-by: Karibhou --- src/pkg/github/client.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pkg/github/client.go b/src/pkg/github/client.go index f67e33879d..173038b12c 100644 --- a/src/pkg/github/client.go +++ b/src/pkg/github/client.go @@ -3355,8 +3355,9 @@ const ( ) // bindProwLgtm records the `prow/lgtm` success status on headSHA, the commit -// the queue review approved. The label and review are already in place, so a -// failure is logged and surfaced on the PR but never returned. +// the queue review approved. On failure it returns the error, logs it when a +// logger is available, and attempts to surface a warning on the PR. The caller +// records the reporting error without undoing the already-placed label and review. func (c *Client) bindProwLgtm(ctx context.Context, owner, repoName string, number int, headSHA, queuedBy string) error { sha7 := headSHA if len(sha7) > 7 { From cc17a3acc94e0f10914ab08995cb06904277a379 Mon Sep 17 00:00:00 2001 From: Karibhou Date: Thu, 5 Nov 2026 15:07:45 +0000 Subject: [PATCH 2/2] docs: add changelog for Prow LGTM comment Signed-off-by: Karibhou --- changelog.d/fixed-16761-prow-lgtm-comment.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/fixed-16761-prow-lgtm-comment.md diff --git a/changelog.d/fixed-16761-prow-lgtm-comment.md b/changelog.d/fixed-16761-prow-lgtm-comment.md new file mode 100644 index 0000000000..311b3e7acd --- /dev/null +++ b/changelog.d/fixed-16761-prow-lgtm-comment.md @@ -0,0 +1 @@ +- Corrected the `bindProwLgtm` comment to describe returned reporting errors and best-effort warnings; runtime behavior is unchanged (#16761).