From 75b1037d0961892d6adf4e3ce6f46e9c96e481f9 Mon Sep 17 00:00:00 2001 From: Karibhou Date: Wed, 4 Nov 2026 20:00:44 +0000 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=90=9B=20fix:=20label=20narrow=20dash?= =?UTF-8?q?board=20navigation?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make the drawer entry point recognizable when the sidebar is hidden, and keep its accessible name in sync with the drawer state. Hive-Run: hivecommons/hive#16654 Hive-Plan: dashboard-narrow-navigation Hive-Spec: issue-16654#navigation-access Co-authored-by: MikeSpreitzer <14296719+MikeSpreitzer@users.noreply.github.com> Signed-off-by: Karibhou --- changelog.d/fixed-16654-navigation-label.md | 1 + src/pkg/dashboard/static-src/html/topbar.html | 4 ++-- src/pkg/dashboard/static-src/js/chat.js | 3 ++- src/pkg/dashboard/static/index.html | 7 ++++--- 4 files changed, 9 insertions(+), 6 deletions(-) create mode 100644 changelog.d/fixed-16654-navigation-label.md diff --git a/changelog.d/fixed-16654-navigation-label.md b/changelog.d/fixed-16654-navigation-label.md new file mode 100644 index 0000000000..d32f536cd1 --- /dev/null +++ b/changelog.d/fixed-16654-navigation-label.md @@ -0,0 +1 @@ +- Label the narrow dashboard's navigation drawer button so operators can find sidebar sections and version details without guessing what the menu icon does (#16654). diff --git a/src/pkg/dashboard/static-src/html/topbar.html b/src/pkg/dashboard/static-src/html/topbar.html index 4b943b428e..15862c83dc 100644 --- a/src/pkg/dashboard/static-src/html/topbar.html +++ b/src/pkg/dashboard/static-src/html/topbar.html @@ -1,9 +1,9 @@
- + title="Open navigation">Navigation
diff --git a/src/pkg/dashboard/static-src/js/chat.js b/src/pkg/dashboard/static-src/js/chat.js index 04a20dd0b7..2f94867431 100644 --- a/src/pkg/dashboard/static-src/js/chat.js +++ b/src/pkg/dashboard/static-src/js/chat.js @@ -531,7 +531,8 @@ sidebar.classList.toggle('open', open); backdrop.classList.toggle('open', open); toggle.setAttribute('aria-expanded', open ? 'true' : 'false'); - toggle.setAttribute('aria-label', open ? 'Close menu' : 'Open menu'); + toggle.setAttribute('aria-label', open ? 'Close navigation' : 'Open navigation'); + toggle.title = open ? 'Close navigation' : 'Open navigation'; } function closeDrawer() { if (isOpen()) setOpen(false); } diff --git a/src/pkg/dashboard/static/index.html b/src/pkg/dashboard/static/index.html index a09cf5b522..c59a9db129 100644 --- a/src/pkg/dashboard/static/index.html +++ b/src/pkg/dashboard/static/index.html @@ -7963,9 +7963,9 @@

🐝 Getting Started
- + title="Open navigation">Navigation
@@ -66694,7 +66694,8 @@

${model.editIndex === null ? 'Add Event trigger' : 'Edit Event trigger'}

Date: Wed, 4 Nov 2026 20:17:21 +0000 Subject: [PATCH 2/2] fix: apply responsive navigation chip classes Signed-off-by: Karibhou --- src/pkg/dashboard/static-src/html/topbar.html | 2 +- src/pkg/dashboard/static/index.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pkg/dashboard/static-src/html/topbar.html b/src/pkg/dashboard/static-src/html/topbar.html index 15862c83dc..4ceaff3d88 100644 --- a/src/pkg/dashboard/static-src/html/topbar.html +++ b/src/pkg/dashboard/static-src/html/topbar.html @@ -3,7 +3,7 @@
+ title="Open navigation">Navigation
diff --git a/src/pkg/dashboard/static/index.html b/src/pkg/dashboard/static/index.html index c59a9db129..eaedd82929 100644 --- a/src/pkg/dashboard/static/index.html +++ b/src/pkg/dashboard/static/index.html @@ -7965,7 +7965,7 @@

🐝 Getting Started + title="Open navigation">Navigation