From 04755b2a046e261c97d61617fcebc03d4ae948ec Mon Sep 17 00:00:00 2001 From: Andrew Anderson Date: Wed, 4 Nov 2026 11:49:52 -0500 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=90=9B=20Keep=20a=20not-yet-run=20cur?= =?UTF-8?q?rent-phase=20track=20visibly=20filled?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit mobile-shots tracker-header-geometry failed on rows whose current-phase CI/Review track has not run yet (unknown / queued beside its running neighbour): the icon-only .todo chevron lost its fill. Give .todo.ham-current the same muted field as .done/.failing — glyph only, neutral — and make the probe's failure message name the cell. Signed-off-by: Andrew Anderson --- changelog.d/fixed-16599-current-phase-track-fill.md | 1 + src/pkg/dashboard/static-src/css/tracker.css | 5 +++++ src/pkg/dashboard/static/index.html | 5 +++++ .../dashboard/webstatic/testdata/tracker-header-geometry.js | 2 +- 4 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 changelog.d/fixed-16599-current-phase-track-fill.md diff --git a/changelog.d/fixed-16599-current-phase-track-fill.md b/changelog.d/fixed-16599-current-phase-track-fill.md new file mode 100644 index 0000000000..26f225abdb --- /dev/null +++ b/changelog.d/fixed-16599-current-phase-track-fill.md @@ -0,0 +1 @@ +Activity Monitor: a CI/Review chevron that is the row's current phase but has not run yet (CI unknown on a review-pending row, Review queued beside running CI) keeps a muted fill with its glyph instead of rendering transparent, so every row's current location stays visible. Refs #16599. diff --git a/src/pkg/dashboard/static-src/css/tracker.css b/src/pkg/dashboard/static-src/css/tracker.css index 35f3b1bb75..14c04bf207 100644 --- a/src/pkg/dashboard/static-src/css/tracker.css +++ b/src/pkg/dashboard/static-src/css/tracker.css @@ -382,6 +382,11 @@ .ham-seg.ham-activity-track.done { background: var(--panel-strong); color: var(--green); box-shadow: none; opacity: 1; } .ham-seg.ham-activity-track.failing { background: var(--panel-strong); color: var(--status-error); box-shadow: none; opacity: 1; } .ham-seg.ham-activity-track.failing .ham-ico { stroke-width: 2; } + /* A not-yet-run track in the current phase (CI unknown on a 050 row, + Review queued beside running CI) keeps the same muted field as its + done / failing neighbours — the glyph alone, neutral — so the current + phase stays a visibly filled location (hivecommons/hive#16599). */ + .ham-seg.ham-activity-track.todo.ham-current { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; } /* Words without motion (checks not reported, unknown evidence, a row parked on a person): current-phase text on a muted field, never amber. */ .ham-seg.ham-activity-track.pending { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; } diff --git a/src/pkg/dashboard/static/index.html b/src/pkg/dashboard/static/index.html index 7a018174c7..72c12b8d7b 100644 --- a/src/pkg/dashboard/static/index.html +++ b/src/pkg/dashboard/static/index.html @@ -1722,6 +1722,11 @@ .ham-seg.ham-activity-track.done { background: var(--panel-strong); color: var(--green); box-shadow: none; opacity: 1; } .ham-seg.ham-activity-track.failing { background: var(--panel-strong); color: var(--status-error); box-shadow: none; opacity: 1; } .ham-seg.ham-activity-track.failing .ham-ico { stroke-width: 2; } + /* A not-yet-run track in the current phase (CI unknown on a 050 row, + Review queued beside running CI) keeps the same muted field as its + done / failing neighbours — the glyph alone, neutral — so the current + phase stays a visibly filled location (hivecommons/hive#16599). */ + .ham-seg.ham-activity-track.todo.ham-current { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; } /* Words without motion (checks not reported, unknown evidence, a row parked on a person): current-phase text on a muted field, never amber. */ .ham-seg.ham-activity-track.pending { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; } diff --git a/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js b/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js index 25644876b6..14b2300a93 100644 --- a/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js +++ b/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js @@ -211,7 +211,7 @@ if (cell.dataset.routeState?.split(' ').includes('active')) { assert(cell.classList.contains('ham-current'), name + 'current phase remains highlighted independently of work'); const style = getComputedStyle(cell); - assert(Number(style.opacity) >= 0.9 && style.backgroundColor !== 'rgba(0, 0, 0, 0)' && style.backgroundColor !== 'transparent', name + 'queued/unknown/assigned/completed current tracks retain a visible steady fill'); + assert(Number(style.opacity) >= 0.9 && style.backgroundColor !== 'rgba(0, 0, 0, 0)' && style.backgroundColor !== 'transparent', name + 'queued/unknown/assigned/completed current tracks retain a visible steady fill: ' + JSON.stringify({ cls: cell.className, track: cell.dataset.track, state: cell.dataset.activityState, bg: style.backgroundColor, opacity: style.opacity, label: cell.getAttribute('aria-label')?.slice(0, 80) })); } if (cell.dataset.track) { // CI / Review lanes are chevrons like their neighbours: same notch From a4e6590d85ff1931d08a1bcf6de87d6cc6a195c8 Mon Sep 17 00:00:00 2001 From: clubanderson <407614+clubanderson@users.noreply.github.com> Date: Wed, 4 Nov 2026 17:08:36 +0000 Subject: [PATCH 2/3] changelog: fragment for #16625 Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> --- changelog.d/fixed-16625.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/fixed-16625.md diff --git a/changelog.d/fixed-16625.md b/changelog.d/fixed-16625.md new file mode 100644 index 0000000000..3523513fc6 --- /dev/null +++ b/changelog.d/fixed-16625.md @@ -0,0 +1 @@ +- Keep a not-yet-run current-phase CI/Review chevron visibly filled (#16625) From e5ea1c1db0cbbe5f255816f02ff2da7a4c30616d Mon Sep 17 00:00:00 2001 From: Andrew Anderson Date: Wed, 4 Nov 2026 12:24:12 -0500 Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=93=9D=20changelog:=20drop=20duplicat?= =?UTF-8?q?e=20fragment=20(fixed-16625.md=20carries=20the=20entry)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Andrew Anderson --- changelog.d/fixed-16599-current-phase-track-fill.md | 1 - 1 file changed, 1 deletion(-) delete mode 100644 changelog.d/fixed-16599-current-phase-track-fill.md diff --git a/changelog.d/fixed-16599-current-phase-track-fill.md b/changelog.d/fixed-16599-current-phase-track-fill.md deleted file mode 100644 index 26f225abdb..0000000000 --- a/changelog.d/fixed-16599-current-phase-track-fill.md +++ /dev/null @@ -1 +0,0 @@ -Activity Monitor: a CI/Review chevron that is the row's current phase but has not run yet (CI unknown on a review-pending row, Review queued beside running CI) keeps a muted fill with its glyph instead of rendering transparent, so every row's current location stays visible. Refs #16599.