diff --git a/changelog.d/fixed-16625.md b/changelog.d/fixed-16625.md new file mode 100644 index 0000000000..3523513fc6 --- /dev/null +++ b/changelog.d/fixed-16625.md @@ -0,0 +1 @@ +- Keep a not-yet-run current-phase CI/Review chevron visibly filled (#16625) diff --git a/src/pkg/dashboard/static-src/css/tracker.css b/src/pkg/dashboard/static-src/css/tracker.css index 88b7c0a5ba..0e16ece3c5 100644 --- a/src/pkg/dashboard/static-src/css/tracker.css +++ b/src/pkg/dashboard/static-src/css/tracker.css @@ -388,6 +388,11 @@ .ham-seg.ham-activity-track.done { background: var(--panel-strong); color: var(--green); box-shadow: none; opacity: 1; } .ham-seg.ham-activity-track.failing { background: var(--panel-strong); color: var(--status-error); box-shadow: none; opacity: 1; } .ham-seg.ham-activity-track.failing .ham-ico { stroke-width: 2; } + /* A not-yet-run track in the current phase (CI unknown on a 050 row, + Review queued beside running CI) keeps the same muted field as its + done / failing neighbours — the glyph alone, neutral — so the current + phase stays a visibly filled location (hivecommons/hive#16599). */ + .ham-seg.ham-activity-track.todo.ham-current { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; } /* Words without motion (checks not reported, unknown evidence, a row parked on a person): current-phase text on a muted field, never amber. */ .ham-seg.ham-activity-track.pending { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; } diff --git a/src/pkg/dashboard/static/index.html b/src/pkg/dashboard/static/index.html index 8e44fe5616..0105abcc3d 100644 --- a/src/pkg/dashboard/static/index.html +++ b/src/pkg/dashboard/static/index.html @@ -1728,6 +1728,11 @@ .ham-seg.ham-activity-track.done { background: var(--panel-strong); color: var(--green); box-shadow: none; opacity: 1; } .ham-seg.ham-activity-track.failing { background: var(--panel-strong); color: var(--status-error); box-shadow: none; opacity: 1; } .ham-seg.ham-activity-track.failing .ham-ico { stroke-width: 2; } + /* A not-yet-run track in the current phase (CI unknown on a 050 row, + Review queued beside running CI) keeps the same muted field as its + done / failing neighbours — the glyph alone, neutral — so the current + phase stays a visibly filled location (hivecommons/hive#16599). */ + .ham-seg.ham-activity-track.todo.ham-current { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; } /* Words without motion (checks not reported, unknown evidence, a row parked on a person): current-phase text on a muted field, never amber. */ .ham-seg.ham-activity-track.pending { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; } diff --git a/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js b/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js index 25644876b6..14b2300a93 100644 --- a/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js +++ b/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js @@ -211,7 +211,7 @@ if (cell.dataset.routeState?.split(' ').includes('active')) { assert(cell.classList.contains('ham-current'), name + 'current phase remains highlighted independently of work'); const style = getComputedStyle(cell); - assert(Number(style.opacity) >= 0.9 && style.backgroundColor !== 'rgba(0, 0, 0, 0)' && style.backgroundColor !== 'transparent', name + 'queued/unknown/assigned/completed current tracks retain a visible steady fill'); + assert(Number(style.opacity) >= 0.9 && style.backgroundColor !== 'rgba(0, 0, 0, 0)' && style.backgroundColor !== 'transparent', name + 'queued/unknown/assigned/completed current tracks retain a visible steady fill: ' + JSON.stringify({ cls: cell.className, track: cell.dataset.track, state: cell.dataset.activityState, bg: style.backgroundColor, opacity: style.opacity, label: cell.getAttribute('aria-label')?.slice(0, 80) })); } if (cell.dataset.track) { // CI / Review lanes are chevrons like their neighbours: same notch