From 5ab881907819a7bc1106e875a0d4ad160ca8c47f Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Wed, 4 Nov 2026 00:11:16 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Activity=20Monitor:=20keep=20sta?= =?UTF-8?q?ge=20chevrons=20a=20one-line=20band=20(chevron=20info=20wrapper?= =?UTF-8?q?=20no=20longer=20grows=20the=20cell)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On phones and coarse-pointer tablets responsive.css gives every .config-info a 40px --tap-target min-height and a drawn ring. The chevron's .ham-chevron-info.config-info wrapper reset width/height but not min-height, so every chevron grew to 40px + 2*sp-1 = 44px instead of one 20px line. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --- changelog.d/fixed-16551-chevron-height.md | 1 + src/pkg/dashboard/stage_tracker_activity.test.js | 5 +++++ src/pkg/dashboard/static-src/css/tracker.css | 7 ++++++- src/pkg/dashboard/static/index.html | 7 ++++++- 4 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 changelog.d/fixed-16551-chevron-height.md diff --git a/changelog.d/fixed-16551-chevron-height.md b/changelog.d/fixed-16551-chevron-height.md new file mode 100644 index 0000000000..549f916cd9 --- /dev/null +++ b/changelog.d/fixed-16551-chevron-height.md @@ -0,0 +1 @@ +- Activity Monitor stage chevrons are a one-line band again on phones and touch tablets; the chevron's info wrapper no longer inherits the 40px tap-target floor (and ring) that made every chevron a 44px box ([#16551](https://github.com/hivecommons/hive/issues/16551)). diff --git a/src/pkg/dashboard/stage_tracker_activity.test.js b/src/pkg/dashboard/stage_tracker_activity.test.js index da570393d0..24e11ebcd1 100644 --- a/src/pkg/dashboard/stage_tracker_activity.test.js +++ b/src/pkg/dashboard/stage_tracker_activity.test.js @@ -618,6 +618,11 @@ test('known and original chevrons keep full long text inside a shared one-line c assert.ok(known.match(/role="tooltip">([^]*?)<\/span>/)[1].includes(handle)); const css = fs.readFileSync(path.join(__dirname, 'static-src/css/tracker.css'), 'utf8'); assert.match(css, /--ham-chevron-text-lines: 1;/); + // responsive.css gives every .config-info a 40px --tap-target floor on + // phones; the chevron's info wrapper must undo it or each chevron becomes + // a 44px box (hivecommons/hive#16551). + assert.match(css, /\.ham-chevron-info\.config-info, \.ham-chevron-info\.ham-chevron-decision \{[^}]*min-height: 0;/); + assert.match(css, /\.ham-chevron-info\.config-info::before \{ content: none; \}/); assert.match(css, /\.ham-chevron-copy \{[^}]*-webkit-line-clamp: var\(--ham-chevron-text-lines\);[^}]*white-space: normal; overflow-wrap: anywhere;/); assert.doesNotMatch(css, /\.ham-(?:seg-t|detour)\.ham-has-holder[^}]*white-space: nowrap/); assert.match(css, /padding: var\(--sp-1\) calc\(var\(--ham-notch\) \+ var\(--sp-2\)\)/); diff --git a/src/pkg/dashboard/static-src/css/tracker.css b/src/pkg/dashboard/static-src/css/tracker.css index f5449e2f8e..edc493b6fb 100644 --- a/src/pkg/dashboard/static-src/css/tracker.css +++ b/src/pkg/dashboard/static-src/css/tracker.css @@ -432,7 +432,12 @@ focus exposes the same full text. */ .ham-strip[aria-label="Pipeline progress"] { grid-auto-rows: minmax(calc(var(--ham-chevron-line-height) * 1em + 2 * var(--sp-1) + 2 * var(--line-width)), auto); } .ham-strip[aria-label="Pipeline progress"] > .ham-seg { box-sizing: border-box; align-self: stretch; line-height: var(--ham-chevron-line-height); padding: var(--sp-1) calc(var(--ham-notch) + var(--sp-2)); } - .ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decision { display: flex; align-items: center; justify-content: center; gap: var(--sp-1); width: 100%; height: 100%; min-width: 0; flex-shrink: 1; margin: 0; padding: 0; border: 0; background: transparent; color: inherit; font: inherit; line-height: inherit; position: static; } + /* min-height: 0 and no ::before ring: on phones / coarse pointers + responsive.css turns every .config-info into a --tap-target (40px) + square with a drawn ring; the chevron's info wrapper is not that + icon, and its 40px floor made every chevron a 44px box. */ + .ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decision { display: flex; align-items: center; justify-content: center; gap: var(--sp-1); width: 100%; height: 100%; min-width: 0; min-height: 0; flex-shrink: 1; margin: 0; padding: 0; border: 0; background: transparent; color: inherit; font: inherit; line-height: inherit; position: static; } + .ham-chevron-info.config-info::before { content: none; } .ham-chevron-info.config-info:hover { background: transparent; border: 0; color: inherit; } .ham-chevron-info:focus-visible, .ham-chevron-decision:focus-within { outline: var(--line-width) solid currentColor; outline-offset: var(--sp-1); } /* The copy shrink-wraps its text (flex 0 1 auto) so the words, with diff --git a/src/pkg/dashboard/static/index.html b/src/pkg/dashboard/static/index.html index 238321f87b..eb5959f741 100644 --- a/src/pkg/dashboard/static/index.html +++ b/src/pkg/dashboard/static/index.html @@ -1769,7 +1769,12 @@ focus exposes the same full text. */ .ham-strip[aria-label="Pipeline progress"] { grid-auto-rows: minmax(calc(var(--ham-chevron-line-height) * 1em + 2 * var(--sp-1) + 2 * var(--line-width)), auto); } .ham-strip[aria-label="Pipeline progress"] > .ham-seg { box-sizing: border-box; align-self: stretch; line-height: var(--ham-chevron-line-height); padding: var(--sp-1) calc(var(--ham-notch) + var(--sp-2)); } - .ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decision { display: flex; align-items: center; justify-content: center; gap: var(--sp-1); width: 100%; height: 100%; min-width: 0; flex-shrink: 1; margin: 0; padding: 0; border: 0; background: transparent; color: inherit; font: inherit; line-height: inherit; position: static; } + /* min-height: 0 and no ::before ring: on phones / coarse pointers + responsive.css turns every .config-info into a --tap-target (40px) + square with a drawn ring; the chevron's info wrapper is not that + icon, and its 40px floor made every chevron a 44px box. */ + .ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decision { display: flex; align-items: center; justify-content: center; gap: var(--sp-1); width: 100%; height: 100%; min-width: 0; min-height: 0; flex-shrink: 1; margin: 0; padding: 0; border: 0; background: transparent; color: inherit; font: inherit; line-height: inherit; position: static; } + .ham-chevron-info.config-info::before { content: none; } .ham-chevron-info.config-info:hover { background: transparent; border: 0; color: inherit; } .ham-chevron-info:focus-visible, .ham-chevron-decision:focus-within { outline: var(--line-width) solid currentColor; outline-offset: var(--sp-1); } /* The copy shrink-wraps its text (flex 0 1 auto) so the words, with