]*>[\s\S]*?Review 5\/5 · awaiting human decision<\/span>/.test(parkedRow), 'genuinely parked on a person keeps the human word, still not amber: ' + parkedRow);
}
+// hivecommons/hive#16540 rows. #16509: adopted, CI 7/11 unreported, review
+// decided → one lit chevron. #16268: waiting for the contributor, CI 7/11
+// unreported, review approved → exactly one. Three qualifying (fix running,
+// CI running, review running) → the tracks win and the stage chevron is
+// settled-current. The ≤2 invariant itself runs on every fixture above.
+{
+ const seen = new Date(now - 60000).toISOString();
+ const unreported = { head: 'f269349', state: 'missing', caption: 'CI waiting · required check "test" hasn\'t reported for this head yet', checks_passed: 7, checks_total: 11, blocker: 'test', source: 'checks', observed_at: seen };
+ const lit = (html) => litChevrons(strip(html));
+ const three = stageTrackerRowHtml({ repo: 'acme/console', number: 16509, kind: 'pr', stage: 74, display_column: 30, head: 'f269349', author: 'thatguywob', author_kind: 'human',
+ code_activity: { head: 'f269349', state: 'adopted', caption: 'Adopted by hive · activity', source: 'adoption', observed_at: seen }, ci_activity: unreported,
+ review_activity: { head: 'f269349', state: 'human_decision', caption: 'Review findings · human decision', perspectives_done: 5, perspectives_total: 5, source: 'verified-review-bundle', observed_at: seen } }, stages, ctx);
+ assert.strictEqual(lit(three), 1, 'adopted + unreported CI + decided review lights one chevron: ' + strip(three));
+ assert.ok(/
]*>[\s\S]*?CI 7\/11 · test not reported<\/span>/.test(three), 'unreported checks are pending, not amber: ' + three);
+ const owner = stageTrackerRowHtml({ repo: 'acme/console', number: 16268, kind: 'pr', stage: 71, display_column: 30, head: 'f269349', author: 'hanthor', author_kind: 'human',
+ code_activity: { head: 'f269349', state: 'waiting_owner', caption: 'Waiting for @hanthor · not observed coding', actor: 'hanthor', source: 'native-author-wait', observed_at: seen }, ci_activity: unreported,
+ review_activity: { head: 'f269349', state: 'approved', caption: 'Review approved', perspectives_done: 5, perspectives_total: 5, source: 'verified-review-bundle', observed_at: seen } }, stages, ctx);
+ assert.strictEqual(lit(owner), 1, 'with the contributor: only the stage chevron is lit: ' + strip(owner));
+ assert.ok(/
]*aria-current="step"/.test(owner) && owner.includes('Waiting for @hanthor'), owner);
+ assert.ok(/data-track="ci"[^>]*>[\s\S]*?CI 7\/11 · test not reported<\/span>/.test(owner) && /
/.test(row) && titled(strip(row)).length === 1, row);
diff --git a/src/pkg/dashboard/static-src/css/tracker.css b/src/pkg/dashboard/static-src/css/tracker.css
index d779d80254..0496b4c20e 100644
--- a/src/pkg/dashboard/static-src/css/tracker.css
+++ b/src/pkg/dashboard/static-src/css/tracker.css
@@ -375,9 +375,21 @@
"current-phase" tint: the operator reads the words, not the shade.
Only fresh observed work earns the pulse. */
.ham-activity-track.ham-current { opacity: 1; box-shadow: none; }
- .ham-seg.ham-activity-track.failing { background: var(--status-error); color: var(--surface-0); box-shadow: none; opacity: 1; }
+ /* A FILLED chevron means "this is where the item is / what moves now"
+ (hivecommons/hive#16540). A CI / Review track is filled only while it
+ runs (.active, amber). Every other state is words on the muted field
+ with the semantic colour on text and glyph only: green for passed /
+ approved, red for a finding, muted for pending, decided or not started. */
+ .ham-seg.ham-activity-track.done { background: var(--panel-strong); color: var(--green); box-shadow: none; opacity: 1; }
+ .ham-seg.ham-activity-track.failing { background: var(--panel-strong); color: var(--status-error); box-shadow: none; opacity: 1; }
.ham-seg.ham-activity-track.failing .ham-ico { stroke-width: 2; }
- .ham-seg.ham-activity-track.done.decided { background: var(--surface-3); color: var(--muted); box-shadow: none; opacity: 1; animation: none; }
+ /* Words without motion (checks not reported, unknown evidence, a row
+ parked on a person): current-phase text on a muted field, never amber. */
+ .ham-seg.ham-activity-track.pending { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; }
+ /* The stage chevron while both tracks run: bright words, no amber, no pulse. */
+ .ham-seg.active.ham-settled-current { background: var(--surface-3); color: var(--text); animation: none; }
+ .ham-seg.active.ham-settled-current::before { display: none; }
+ .ham-seg.ham-activity-track.done.decided { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; }
/* The count words stay on one line and ellipsize instead of wrapping. */
.ham-chevron-copy.ham-track-state .ham-ico { vertical-align: -2px; margin-right: 3px; }
.ham-seg.active[data-motion]::before { content: ''; position: absolute; inset: 0; opacity: 0; pointer-events: none; }
diff --git a/src/pkg/dashboard/static-src/js/tracker-row-strip.js b/src/pkg/dashboard/static-src/js/tracker-row-strip.js
index 5d69383e19..e45b818c7b 100644
--- a/src/pkg/dashboard/static-src/js/tracker-row-strip.js
+++ b/src/pkg/dashboard/static-src/js/tracker-row-strip.js
@@ -95,14 +95,41 @@
return !!(hive || item.stage === 74 || item.adopted_by);
}
+ // A row parked on a person: the contributor's move (071/072 or a
+ // waiting_owner code word), a hold, or a human decision. Nothing of
+ // the hive's is in motion on it, so no CI / Review track is amber.
+ function stageTrackerWaitingOnPerson(item) {
+ if (!item) return false;
+ if (item.needs_human || item.on_hold || item.hold) return true;
+ const stage = Number(item.stage);
+ if (stage === 71 || stage === 72) return true;
+ const code = item.code_activity;
+ return !!(code && code.head === item.head && code.state === 'waiting_owner');
+ }
+
+ // A CI / Review track is in motion only on concrete evidence on the
+ // current head: a check-run in_progress / queued, or a reviewer
+ // running / queued (or the backend's own active flag). Checks that
+ // have not reported, unknown evidence and settled verdicts are not
+ // motion (hivecommons/hive#16540).
+ function stageTrackerTrackRunning(item, kind) {
+ const a = item && item[kind + '_activity'];
+ if (!a || !item.head || a.head !== item.head) return false;
+ if (stageTrackerWaitingOnPerson(item)) return false;
+ const moving = kind === 'ci' ? ['running', 'queued'] : ['reviewing', 'adjudicating', 'assigned'];
+ return !!(a.active || moving.includes(a.state));
+ }
+
// Evidence is supplied independently by the backend. A native 050 label
// cannot say who reviews, whether checks run, or whether an author codes.
// The chevron wears its glyph plus the count words from
// stageTrackerTrackWord (hivecommons/hive#16484). Style follows the
- // track's own state on the current head: in progress = the full active
- // fill (both tracks may be lit at once; the words disambiguate), done =
- // the passed-stage style, a finding = the failing style, not started =
- // the empty chevron with the glyph alone. Freshness gates only the pulse.
+ // track's own state on the current head: running = the full active
+ // fill (both tracks may be lit at once; the words disambiguate); done,
+ // a finding, pending and decided are words in their colour on the muted
+ // field — only a running track is filled (hivecommons/hive#16540); not
+ // started = the empty chevron with the glyph alone. Freshness gates only
+ // the pulse.
function stageTrackerActivityTrackHtml(item, kind, sg, blank, nowMs) {
if (blank) return `
`;
const name = kind === 'ci' ? 'CI' : 'Review';
@@ -125,7 +152,10 @@
// A complete verdict parked on a person is settled, not in progress:
// done-style, muted, never the amber fill (hivecommons/hive#16509 row).
const settled = matches && state === 'human_decision' && (!known || !a.active);
- const cls = finished ? 'done' : finding ? 'failing' : settled ? 'done decided' : text ? 'active' : 'todo';
+ // At most two chevrons on a row are ever amber: a track is active
+ // only while it is running; words without motion are pending.
+ const running = stageTrackerTrackRunning(item, kind);
+ const cls = finished ? 'done' : finding ? 'failing' : settled ? 'done decided' : running ? 'active' : text ? 'pending' : 'todo';
const source = matches ? a.source || 'unavailable' : 'unavailable';
const freshness = !Number.isFinite(observed) ? 'observation time unknown' : (stale ? 'stale · ' : 'observed · ') + new Date(observed).toISOString();
const since = matches && a.since && Number.isFinite(Date.parse(a.since)) ? ' · since ' + new Date(a.since).toISOString() : '';
@@ -215,6 +245,12 @@
const remediation = codeOnHead && ['unassigned', 'remediating', 'fix_pushed'].includes(code.state) ? code.state : '';
if (remediation === 'remediating' && Number(item.display_column) === 30) motion = STAGE_TRACKER_MOTION_ACTIVE;
const evidence = item.remediation && item.remediation.kind ? 'evidence: ' + item.remediation.kind + (item.remediation.actor ? ' by ' + item.remediation.actor : '') + (item.remediation.since ? ' since ' + item.remediation.since : '') + (item.remediation.source ? ' (' + item.remediation.source + ')' : '') : '';
+ // Both tracks running: the PR waits on them, nobody works it. The
+ // stage chevron is settled-current (bright words, no amber, no pulse)
+ // so the row never lights three chevrons (hivecommons/hive#16540).
+ const tracksRunning = ['ci', 'review'].filter(kind => stageTrackerTrackRunning(item, kind)).length;
+ const waitingOnTracks = tracksRunning === 2;
+ if (waitingOnTracks) motion = STAGE_TRACKER_MOTION_STATIC;
const motionAttr = motion === STAGE_TRACKER_MOTION_STATIC ? '' : ` data-motion="${motion}"`;
return segs.map(sg => {
if (sg.number === 50) return ['ci', 'review'].map(kind => stageTrackerActivityTrackHtml(item, kind, sg, sg.number < from || sg.number > to, nowMs)).join('');
@@ -222,7 +258,7 @@
const sentinel = !!(sg.detour && sg.detour.sentinel);
const sentinelSuffix = !!(sg.detour && sg.detour.sentinelSuffix);
const fixPushed = sg.number === 30 && sg.state === 'done' && remediation === 'fix_pushed';
- const cls = ['ham-seg', sg.state, sg.cap ? 'cap' : '', fixPushed ? 'ham-fix-pushed' : '', sg.state === 'active' && sg.number === 30 && remediation ? 'ham-remediation-' + remediation : '', sg.cap && sg.terminal ? 'merged' : '', sg.detour ? 'detoured' : '', sg.hold ? 'ham-open-hold' : '', sg.blocked ? 'ham-open-blocked' : '', sg.draft ? 'ham-open-draft' : '', sg.isNew ? 'ham-open-new' : '', sg.advisory ? 'ham-open-advisory' : '', sg.openSince && sg.openSince.stale ? 'ham-open-stale' : '', sentinel || sentinelSuffix ? 'ham-sentinel' : ''].filter(Boolean).join(' ');
+ const cls = ['ham-seg', sg.state, sg.cap ? 'cap' : '', sg.state === 'active' && !sg.cap && waitingOnTracks ? 'ham-settled-current' : '', fixPushed ? 'ham-fix-pushed' : '', sg.state === 'active' && sg.number === 30 && remediation ? 'ham-remediation-' + remediation : '', sg.cap && sg.terminal ? 'merged' : '', sg.detour ? 'detoured' : '', sg.hold ? 'ham-open-hold' : '', sg.blocked ? 'ham-open-blocked' : '', sg.draft ? 'ham-open-draft' : '', sg.isNew ? 'ham-open-new' : '', sg.advisory ? 'ham-open-advisory' : '', sg.openSince && sg.openSince.stale ? 'ham-open-stale' : '', sentinel || sentinelSuffix ? 'ham-sentinel' : ''].filter(Boolean).join(' ');
const active = sg.state === 'active';
let tip = '';
let gateCaption = '';
@@ -267,6 +303,7 @@
if (code.blocker) tip += ' · ' + code.blocker;
if (claimant) tip += ' · ' + stageTrackerClaimantLine(claimant, nowMs);
}
+ if (waitingOnTracks && !sg.cap) tip = 'Waiting on CI and review, both running — ' + tip;
}
let inner;
// A lit chevron on a row parked on a person ("Needs human decision",
diff --git a/src/pkg/dashboard/static/index.html b/src/pkg/dashboard/static/index.html
index 58d56b99ef..7c0616274b 100644
--- a/src/pkg/dashboard/static/index.html
+++ b/src/pkg/dashboard/static/index.html
@@ -1712,9 +1712,21 @@
"current-phase" tint: the operator reads the words, not the shade.
Only fresh observed work earns the pulse. */
.ham-activity-track.ham-current { opacity: 1; box-shadow: none; }
- .ham-seg.ham-activity-track.failing { background: var(--status-error); color: var(--surface-0); box-shadow: none; opacity: 1; }
+ /* A FILLED chevron means "this is where the item is / what moves now"
+ (hivecommons/hive#16540). A CI / Review track is filled only while it
+ runs (.active, amber). Every other state is words on the muted field
+ with the semantic colour on text and glyph only: green for passed /
+ approved, red for a finding, muted for pending, decided or not started. */
+ .ham-seg.ham-activity-track.done { background: var(--panel-strong); color: var(--green); box-shadow: none; opacity: 1; }
+ .ham-seg.ham-activity-track.failing { background: var(--panel-strong); color: var(--status-error); box-shadow: none; opacity: 1; }
.ham-seg.ham-activity-track.failing .ham-ico { stroke-width: 2; }
- .ham-seg.ham-activity-track.done.decided { background: var(--surface-3); color: var(--muted); box-shadow: none; opacity: 1; animation: none; }
+ /* Words without motion (checks not reported, unknown evidence, a row
+ parked on a person): current-phase text on a muted field, never amber. */
+ .ham-seg.ham-activity-track.pending { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; }
+ /* The stage chevron while both tracks run: bright words, no amber, no pulse. */
+ .ham-seg.active.ham-settled-current { background: var(--surface-3); color: var(--text); animation: none; }
+ .ham-seg.active.ham-settled-current::before { display: none; }
+ .ham-seg.ham-activity-track.done.decided { background: var(--panel-strong); color: var(--muted); box-shadow: none; opacity: 1; animation: none; }
/* The count words stay on one line and ellipsize instead of wrapping. */
.ham-chevron-copy.ham-track-state .ham-ico { vertical-align: -2px; margin-right: 3px; }
.ham-seg.active[data-motion]::before { content: ''; position: absolute; inset: 0; opacity: 0; pointer-events: none; }
@@ -17885,14 +17897,41 @@
Where to get help
return !!(hive || item.stage === 74 || item.adopted_by);
}
+ // A row parked on a person: the contributor's move (071/072 or a
+ // waiting_owner code word), a hold, or a human decision. Nothing of
+ // the hive's is in motion on it, so no CI / Review track is amber.
+ function stageTrackerWaitingOnPerson(item) {
+ if (!item) return false;
+ if (item.needs_human || item.on_hold || item.hold) return true;
+ const stage = Number(item.stage);
+ if (stage === 71 || stage === 72) return true;
+ const code = item.code_activity;
+ return !!(code && code.head === item.head && code.state === 'waiting_owner');
+ }
+
+ // A CI / Review track is in motion only on concrete evidence on the
+ // current head: a check-run in_progress / queued, or a reviewer
+ // running / queued (or the backend's own active flag). Checks that
+ // have not reported, unknown evidence and settled verdicts are not
+ // motion (hivecommons/hive#16540).
+ function stageTrackerTrackRunning(item, kind) {
+ const a = item && item[kind + '_activity'];
+ if (!a || !item.head || a.head !== item.head) return false;
+ if (stageTrackerWaitingOnPerson(item)) return false;
+ const moving = kind === 'ci' ? ['running', 'queued'] : ['reviewing', 'adjudicating', 'assigned'];
+ return !!(a.active || moving.includes(a.state));
+ }
+
// Evidence is supplied independently by the backend. A native 050 label
// cannot say who reviews, whether checks run, or whether an author codes.
// The chevron wears its glyph plus the count words from
// stageTrackerTrackWord (hivecommons/hive#16484). Style follows the
- // track's own state on the current head: in progress = the full active
- // fill (both tracks may be lit at once; the words disambiguate), done =
- // the passed-stage style, a finding = the failing style, not started =
- // the empty chevron with the glyph alone. Freshness gates only the pulse.
+ // track's own state on the current head: running = the full active
+ // fill (both tracks may be lit at once; the words disambiguate); done,
+ // a finding, pending and decided are words in their colour on the muted
+ // field — only a running track is filled (hivecommons/hive#16540); not
+ // started = the empty chevron with the glyph alone. Freshness gates only
+ // the pulse.
function stageTrackerActivityTrackHtml(item, kind, sg, blank, nowMs) {
if (blank) return ``;
const name = kind === 'ci' ? 'CI' : 'Review';
@@ -17915,7 +17954,10 @@
Where to get help
// A complete verdict parked on a person is settled, not in progress:
// done-style, muted, never the amber fill (hivecommons/hive#16509 row).
const settled = matches && state === 'human_decision' && (!known || !a.active);
- const cls = finished ? 'done' : finding ? 'failing' : settled ? 'done decided' : text ? 'active' : 'todo';
+ // At most two chevrons on a row are ever amber: a track is active
+ // only while it is running; words without motion are pending.
+ const running = stageTrackerTrackRunning(item, kind);
+ const cls = finished ? 'done' : finding ? 'failing' : settled ? 'done decided' : running ? 'active' : text ? 'pending' : 'todo';
const source = matches ? a.source || 'unavailable' : 'unavailable';
const freshness = !Number.isFinite(observed) ? 'observation time unknown' : (stale ? 'stale · ' : 'observed · ') + new Date(observed).toISOString();
const since = matches && a.since && Number.isFinite(Date.parse(a.since)) ? ' · since ' + new Date(a.since).toISOString() : '';
@@ -18005,6 +18047,12 @@
Where to get help
const remediation = codeOnHead && ['unassigned', 'remediating', 'fix_pushed'].includes(code.state) ? code.state : '';
if (remediation === 'remediating' && Number(item.display_column) === 30) motion = STAGE_TRACKER_MOTION_ACTIVE;
const evidence = item.remediation && item.remediation.kind ? 'evidence: ' + item.remediation.kind + (item.remediation.actor ? ' by ' + item.remediation.actor : '') + (item.remediation.since ? ' since ' + item.remediation.since : '') + (item.remediation.source ? ' (' + item.remediation.source + ')' : '') : '';
+ // Both tracks running: the PR waits on them, nobody works it. The
+ // stage chevron is settled-current (bright words, no amber, no pulse)
+ // so the row never lights three chevrons (hivecommons/hive#16540).
+ const tracksRunning = ['ci', 'review'].filter(kind => stageTrackerTrackRunning(item, kind)).length;
+ const waitingOnTracks = tracksRunning === 2;
+ if (waitingOnTracks) motion = STAGE_TRACKER_MOTION_STATIC;
const motionAttr = motion === STAGE_TRACKER_MOTION_STATIC ? '' : ` data-motion="${motion}"`;
return segs.map(sg => {
if (sg.number === 50) return ['ci', 'review'].map(kind => stageTrackerActivityTrackHtml(item, kind, sg, sg.number < from || sg.number > to, nowMs)).join('');
@@ -18012,7 +18060,7 @@
if (code.blocker) tip += ' · ' + code.blocker;
if (claimant) tip += ' · ' + stageTrackerClaimantLine(claimant, nowMs);
}
+ if (waitingOnTracks && !sg.cap) tip = 'Waiting on CI and review, both running — ' + tip;
}
let inner;
// A lit chevron on a row parked on a person ("Needs human decision",