From 37e2a7962147cb9c0d9a13a18e363bf35f4c2413 Mon Sep 17 00:00:00 2001 From: Andrew Anderson Date: Tue, 3 Nov 2026 17:58:09 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Drop=20cross-row=20chevron=20hei?= =?UTF-8?q?ght=20assertion=20from=20geometry=20probe?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Rows are now only as tall as their longest caption (#16464), so the browser geometry probe's requirement that each lane keep the same height across rows contradicted the shipped contract and failed every viewport in the reporting-only screenshot workflow. Within-row uniformity and the content-driven height check remain. Signed-off-by: Andrew Anderson --- .../webstatic/testdata/tracker-header-geometry.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js b/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js index 25b0ea6dea..f3506a6c7f 100644 --- a/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js +++ b/src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js @@ -82,7 +82,11 @@ if ([...row.querySelectorAll(':scope > .ham-current-stage, :scope > .ham-human-context')] .some(context => /superseded/i.test(context.textContent))) coverage.superseded++; if (row.matches('.ham-row') && row.querySelectorAll(':scope > .ham-sub').length > 1) coverage.multiIssue++; - const signature = columns.map(cell => ({ left: rect(cell).left - rect(strip).left, width: rect(cell).width, height: rect(cell).height })); + // Height is deliberately absent from the cross-row signature: a row is + // only as tall as its longest caption (one or two lines), so rows differ + // in height by design. Within-row uniformity and the content-driven + // height contract are asserted separately below. + const signature = columns.map(cell => ({ left: rect(cell).left - rect(strip).left, width: rect(cell).width })); const stripLeft = rect(strip.parentElement).left; // Recorded preparation roots retain the existing rail gutter. Compare // like gutters across rows; header-to-lane checks below remain exact. @@ -92,7 +96,6 @@ assert(near(stripLeft, reference.left), name + 'root/nested progress containers with the same rail gutter share one horizontal origin'); for (const [lane, box] of signature.entries()) { assert(near(box.left, reference.signature[lane].left) && near(box.width, reference.signature[lane].width), name + 'physical lane ' + lane + ' aligns across issue, PR-only and multi-PR rows'); - assert(near(box.height, reference.signature[lane].height), name + 'physical lane ' + lane + ' has the same compact height across rows'); } const flow = [...row.children].filter(child => visible(child) && !['absolute', 'fixed'].includes(getComputedStyle(child).position)); const rowGap = parseFloat(getComputedStyle(row).rowGap) || 0;