diff --git a/changelog.d/added-pin-only-human-merge-relay.md b/changelog.d/added-pin-only-human-merge-relay.md new file mode 100644 index 0000000000..4530ff073d --- /dev/null +++ b/changelog.d/added-pin-only-human-merge-relay.md @@ -0,0 +1 @@ +- Enforce the configured trusted-author pin-only exception in the GitHub merge-request relay, requiring a complete diff and exact requested head while preserving all other merge gates. diff --git a/src/cmd/hive/notifywire.go b/src/cmd/hive/notifywire.go index cb6b6698fa..cda8a8d6a2 100644 --- a/src/cmd/hive/notifywire.go +++ b/src/cmd/hive/notifywire.go @@ -35,6 +35,13 @@ func syncAutoMergePolicyToGitHubClient(cfg *config.Config, ghClient *github.Clie ghClient.SetMergeRequestNoCIAllowedRepos(cfg.AutoMerge.NoCIOKSet()) // The merge-request relay refuses PRs touching these paths (#11039). ghClient.SetHumanMergePaths(cfg.AutoMerge.HumanMergePaths) + pinOnly := make(map[string]github.PinOnlySpec) + for repo := range cfg.AutoMerge.HumanMergePinOnly { + if ex, enabled := cfg.AutoMerge.HumanMergePinOnlyFor(repo); enabled { + pinOnly[repo] = github.PinOnlySpec{Enabled: true, Paths: ex.Paths, Kinds: ex.Kinds, TrustedAuthors: ex.TrustedAuthors} + } + } + ghClient.SetHumanMergePinOnly(pinOnly) ghClient.SetAutoMergeMinHeadAge(cfg.AutoMerge.EffectiveMinHeadAge()) return set, ok } diff --git a/src/docs/hive-merge.md b/src/docs/hive-merge.md index b16e28202c..68fe61729e 100644 --- a/src/docs/hive-merge.md +++ b/src/docs/hive-merge.md @@ -170,17 +170,16 @@ sweep lanes whatever the intent tier. If the changed-file list for a configured repo cannot be fetched completely, the merge is withheld (fail closed). See [operator-reference.md](operator-reference.md). -**Pin-only policy (enforced by the automerge sweep and `/approve`; relay pending).** +**Pin-only policy (enforced by the automerge sweep, `/approve`, and relay).** `auto_merge.human_merge_pin_only` provides the schema and conservative diff classifier for #16242 / #16262. **The automerge sweep lanes and `/approve` -enforce it (#16266); the `hive-merge` relay does not yet** (#16265) and still -requires the existing human-merge path policy. The native merge queue is entered +enforce it (#16266), as does the `hive-merge` relay (#16265)**. The native merge queue is entered only after a lane's human-merge-path gate, so queued PRs inherit the exception. A sweep lane does not hold a PR on its human-merge-path matches when the repo has an enabled entry, the PR author is in `trusted_authors` (case-insensitive login match), GitHub's reported changed-file count is present and equals the fetched list, -and the classifier accepts the diff. The check reuses the file list the path +and the classifier accepts the diff. The sweep check reuses the file list the path gate already fetches, so it costs no extra API call; a repo without an enabled entry behaves exactly as before. `/hive approve` applies the same check, so its reply never contradicts the lane. Any other outcome holds the PR as before. @@ -211,7 +210,8 @@ permission/credential/signing text and non-pin edits fail closed. This classifier proves **syntax only**, not authenticated identity, exact-head binding, file-list completeness, semantic interpretation or review of upstream references. The sweep supplies the author (GitHub's PR author login) and -file-list completeness itself; the relay integration remains #16265; +file-list completeness itself. The relay additionally requires a nonempty requested +head SHA matching the PR head before and after fetching files; attribution and safe hold release are tracked in #16269. None of the schema or classifier APIs grants permission to merge or clears a hold. Native required checks and producer bindings, freshness, current reviews, substantive @@ -219,9 +219,9 @@ objections, unrelated holds and configured soak must remain independent gates. Operators stage the key in the controller's configured `hive.yaml` seed, not in the image repository (reload behaviour is documented in the operator reference -linked above). On an image that contains #16266, reloading the seed enables -the sweep and `/approve` exception at once; the `hive-merge` relay still -ignores the key until #16265 lands, so relay merges keep holding matching PRs. +linked above). On an image that contains #16266 and #16265, reloading the seed enables +the sweep, `/approve`, and `hive-merge` relay exception at once. Non-GitHub +forge relays retain the existing fail-closed human-merge-path policy. There is **no minimum deployable version enabling this lane yet**. Utah rollout and current-head positive/negative deployment evidence remain tracked by diff --git a/src/docs/operator-reference/README.md b/src/docs/operator-reference/README.md index ba9166cbe5..dc7dda4da5 100644 --- a/src/docs/operator-reference/README.md +++ b/src/docs/operator-reference/README.md @@ -253,7 +253,7 @@ Go callers keep reading `cfg.Agents`, `cfg.Governor.Gateways` and so on through | `project.label_driven_supersede_park_actors` | `[]` (off) | Automation logins (for example a lifecycle bot running as `github-actions[bot]`) whose park labels a later trusted acceptance supersedes on label-driven repos: Hive removes the label, says so in the release comment, and releases the issue ([#13605](https://github.com/hivecommons/hive/issues/13605)). Park labels added by people, by unlisted bots, or by a listed bot after the acceptance still block; `hold` is never superseded. Per-repo override: `project.repo_policies[].label_driven_supersede_park_actors`. | | `auto_merge.allow_unprotected_base` | Deprecated no-op. | Accepted so older configs keep loading. `hive-merge` now merges into any protected or unprotected branch the App can write, subject to the CI-evidence gate and GitHub's own merge rules. | | `auto_merge.no_ci_ok` | Empty by default. | Explicit repo list whose zero-CI merge-request verdict may pass; failing or pending CI evidence is still enforced. | -| `auto_merge.human_merge_pin_only` | Unset (off); enforced by the automerge sweep lanes and `/approve` (#16266), **not yet by the `hive-merge` relay** (#16265). | Per-repo schema for `enabled`, `paths`, `kinds` (`action-sha`, `image-digest`, `version-pin`) and `trusted_authors`. Enabled entries require all three lists. The sweep does not place a human-merge-path hold on a PR whose author is in `trusted_authors` and whose complete diff (every changed file, guarded or not) is pin replacements; it never clears an existing hold. See [hive-merge.md](../hive-merge.md) for grammar, restrictions and outstanding integration/deployment requirements (#16242). | +| `auto_merge.human_merge_pin_only` | Unset (off); enforced by the automerge sweep lanes and `/approve` (#16266), and the `hive-merge` relay (#16265). | Per-repo schema for `enabled`, `paths`, `kinds` (`action-sha`, `image-digest`, `version-pin`) and `trusted_authors`. Enabled entries require all three lists. The sweep does not place a human-merge-path hold on a PR whose author is in `trusted_authors` and whose complete diff (every changed file, guarded or not) is pin replacements; it never clears an existing hold. See [hive-merge.md](../hive-merge.md) for grammar, restrictions and outstanding integration/deployment requirements (#16242). | | `auto_merge.human_merge_paths` | Unset (off). | Per-repo map of `owner/repo` to glob patterns (same syntax as `intent.guardrail_path_patterns`) for paths a person must merge. Applies to every merge lane (App self-merge, trusted-author, label-queued, merge-request relay) whatever the intent tier; a matching PR is held with one comment, and an incomplete changed-file list fails closed. Details in the sweep key table below. | | `auto_merge.human_merge_title_prefixes` | `["⚠️", "⚠"]` | Title prefixes (after trimming) that mark a PR as a breaking change a person must merge. Every auto-merge lane and the merge train skip the PR; the tracker parks it at 090 *Ready for human merge · human merge*. Set to `[]` to disable. | | `auto_merge.human_merge_labels` | `["needs-owner-merge"]` | Labels (case-insensitive) that mark a PR a person must merge; same effect as the title prefixes. Set to `[]` to disable. | @@ -456,7 +456,7 @@ advanced into the merge path. | `auto_merge.repos..required_checks` | inherits default | Per-repo override for heterogeneous hives. `` may be the bare name from `project.repos` or `owner/repo`; an explicit empty list declares that GitHub has no required contexts, while Hive still requires positive CI evidence from at least one real successful check-run before merge. | | `auto_merge.allow_unprotected_base` | deprecated no-op | Accepted for compatibility only. [`hive-merge`](../hive-merge.md) no longer refuses solely because a base branch has no GitHub branch protection; it may merge into any branch the App can write after positive CI evidence. | | `auto_merge.no_ci_ok` | unset (refuse) | **Merge-request watcher key, not a sweep key.** Per-repo opt-in that downgrades only the "unverified" CI verdict (zero statuses, check runs, and workflow runs) to green, for adopted repos with no CI by design. Red and pending verdicts are never downgraded (#6281). See [hive-merge.md](../hive-merge.md). | -| `auto_merge.human_merge_paths` | unset | Per-repo map of `owner/repo` to glob patterns (same syntax as `intent.guardrail_path_patterns`) for paths a person must merge, e.g. `Danathar/goodreads-mcp: [".claude/settings.json", ".claude/hooks/**"]`. Every App merge path honors it: the automerge sweep lanes (App self-merge, trusted-author, label-queued) and the agent merge-request relay refuse a PR that touches a listed path, add `hold`, and post one `` comment naming the path(s); a person must merge it. The sweep lanes skip that hold only for a PR admitted by `auto_merge.human_merge_pin_only` (#16266); the relay does not apply that exception yet. If the changed-file list cannot be fetched completely for a configured repo, the merge is withheld (#11038, #11039). | +| `auto_merge.human_merge_paths` | unset | Per-repo map of `owner/repo` to glob patterns (same syntax as `intent.guardrail_path_patterns`) for paths a person must merge, e.g. `Danathar/goodreads-mcp: [".claude/settings.json", ".claude/hooks/**"]`. Every App merge path honors it: the automerge sweep lanes (App self-merge, trusted-author, label-queued) and the agent merge-request relay refuse a PR that touches a listed path, add `hold`, and post one `` comment naming the path(s); a person must merge it. The sweep lanes and GitHub relay skip that hold only for a PR admitted by `auto_merge.human_merge_pin_only` (#16266, #16265); the relay also requires the exact requested head before and after fetching files. If the changed-file list cannot be fetched completely for a configured repo, the merge is withheld (#11038, #11039). | | `auto_merge.human_merge_title_prefixes` | `["⚠️", "⚠"]` | PR-title prefixes that mean "breaking change — owner merges" (U+26A0 with or without the VS16 selector by default, matched after trimming leading whitespace). One shared predicate, `automerge.RequiresHumanMerge(pr)`, runs where each lane computes eligibility — App self-merge, label-queued, trusted-author and contributor lanes, plus the refetch before a merge — so a matching PR is never merged by hive and never fronts a merge train, however green and however approved. The PR parks at stage 090 *Ready for human merge* with the `human merge` chip and reason *breaking change — owner merges*; the owner merges it with **Approve & merge as maintainer** or on GitHub. Hive posts one writeback-gated comment saying it will wait for a human. Set to `[]` to turn the title rule off. Added after a ⚠️-titled PR was auto-merged by the trusted-author lane while its owner was still deciding whether to ship it. | | `auto_merge.human_merge_labels` | `["needs-owner-merge"]` | Labels (case-insensitive, trimmed) that carry the same "a person merges this" meaning as the title prefixes above; either match is enough. Set to `[]` to turn the label rule off. | | `auto_merge.require_current_base` | unset | Repo list (`owner/repo`) with an explicit **on** override for the current-base merge gate (Settings → Repos → "Merge only on current base"). On a gated repo the App self-merge, trusted-author and contributor lanes only merge a head that contains the current base tip. A green head tested against an older base is updated with GitHub update-branch (a merge commit; no author commit is rewritten) and merges once CI is green on the new head, so a semantic conflict with work merged since turns that PR red instead of breaking the base ([#13634](https://github.com/hivecommons/hive/issues/13634), [#15335](https://github.com/hivecommons/hive/issues/15335)). Costs one compare call per merge candidate. Listing a repo here is also **strict**: a behind head the App cannot update (fork without maintainer edits, branch protection or a missing `contents: write`) is parked (`fork-not-editable` / `update-branch`) rather than merged as tested. Wins over `skip_current_base` and over the default. | @@ -497,8 +497,8 @@ hosted spoke changes survive restarts without editing `hive.yaml`. ### Human-merge pin-only rollout -**Availability:** the automerge sweep lanes and `/approve` enforce the -exception (#16266); the relay does not yet. Minimum +**Availability:** the automerge sweep lanes and `/approve` (#16266) and the +GitHub relay (#16265) enforce the exception. Minimum supported version: the first deployed v5 release containing the schema/classifier (#16262), relay (#16265), sweep (#16266), and hold-release admission integration (#16269). No released version is established here; do not assume an existing @@ -507,7 +507,7 @@ digest/version and live positive/negative evidence in projectbluefin/utah#1082 before enabling that rollout. The additive configuration (schema #16262; enforced by the automerge sweep lanes -and `/approve` per #16266, relay pending #16265) is: +and `/approve` per #16266, and the GitHub relay per #16265) is: ```yaml auto_merge: diff --git a/src/pkg/config/automerge_pin_only.go b/src/pkg/config/automerge_pin_only.go index b03e534abe..2638b65bc6 100644 --- a/src/pkg/config/automerge_pin_only.go +++ b/src/pkg/config/automerge_pin_only.go @@ -10,8 +10,8 @@ import ( // PinOnlyException is policy wired in Engine.SetHumanMergePinOnly and // enforced by the automerge sweep and /approve gates via humanMergePinOnlyExempt // (#16266). It proves trusted PR author, complete file list, and SHA-bound merge, -// but not upstream review (separate gates handle that). The hive-merge relay does -// not yet apply it (#16265). +// but not upstream review (separate gates handle that). The hive-merge relay +// applies the same policy through Client.SetHumanMergePinOnly (#16265). type PinOnlyException struct { Enabled bool `yaml:"enabled" json:"enabled"` Paths []string `yaml:"paths" json:"paths"` diff --git a/src/pkg/config/config.go b/src/pkg/config/config.go index bca9a76240..97ebc6ac65 100644 --- a/src/pkg/config/config.go +++ b/src/pkg/config/config.go @@ -8341,8 +8341,8 @@ type AutoMergeConfig struct { HumanMergePaths map[string][]string `yaml:"human_merge_paths,omitempty" json:"human_merge_paths,omitempty"` // HumanMergePinOnly holds the opt-in pin-only exception, enforced by the - // automerge sweep and /approve gates via humanMergePinOnlyExempt (#16266); - // the hive-merge relay does not apply it yet (#16265). + // automerge sweep and /approve gates (#16266), and the hive-merge relay + // (#16265). HumanMergePinOnly map[string]PinOnlyException `yaml:"human_merge_pin_only,omitempty" json:"human_merge_pin_only,omitempty"` // HumanMergeTitlePrefixes lists title prefixes (matched after trimming // the title) that mark a PR as one the owner merges by hand; no lane and diff --git a/src/pkg/github/client.go b/src/pkg/github/client.go index 7cf1957651..daeb39937d 100644 --- a/src/pkg/github/client.go +++ b/src/pkg/github/client.go @@ -150,8 +150,9 @@ type Client struct { mergePolicyMu sync.RWMutex allowUnprotectedBaseRepos map[string]bool noCIAllowedRepos map[string]bool - humanMergePaths map[string][]string // auto_merge.human_merge_paths; see SetHumanMergePaths - sentinelHeads sentinelHeadsSeen // head SHAs the sentinel sweep already evaluated + humanMergePaths map[string][]string // auto_merge.human_merge_paths; see SetHumanMergePaths + humanMergePinOnly map[string]PinOnlySpec // guarded by mergePolicyMu + sentinelHeads sentinelHeadsSeen // head SHAs the sentinel sweep already evaluated autoMergeMinHeadAge time.Duration mergeAlertMu sync.Mutex mergeAlertSink MergeFailureAlertSink diff --git a/src/pkg/github/human_merge_paths.go b/src/pkg/github/human_merge_paths.go index 2531bcf8e5..7c20a83cda 100644 --- a/src/pkg/github/human_merge_paths.go +++ b/src/pkg/github/human_merge_paths.go @@ -13,7 +13,8 @@ import ( // Human-merge paths (#11027): auto_merge.human_merge_paths lists, per repo, // paths a person must merge. Every App merge path (the automerge sweep lanes // and the merge-request relay) refuses a PR that touches one, adds `hold`, -// and leaves one marker-stamped comment naming the path(s). +// and leaves one marker-stamped comment naming the path(s), unless the +// configured pin-only exception is proven. const ( // HumanMergePathsConfigKey is the config key named in every refusal. HumanMergePathsConfigKey = "auto_merge.human_merge_paths" @@ -192,9 +193,58 @@ func (c *Client) humanMergePathsFor(repo string) []string { return c.humanMergePaths[repoPolicyKey(c.org, repo)] } +// PinOnlySpec is the relay's config-independent pin-only exception policy. +// It only lifts the human-merge-path gate, never any other merge requirement. +type PinOnlySpec struct { + Enabled bool + Paths []string + Kinds []string + TrustedAuthors []string +} + +func (p PinOnlySpec) clone() PinOnlySpec { + p.Paths = append([]string(nil), p.Paths...) + p.Kinds = append([]string(nil), p.Kinds...) + p.TrustedAuthors = append([]string(nil), p.TrustedAuthors...) + return p +} + +// SetHumanMergePinOnly replaces the relay policy on config reload; nil clears it. +// Duplicate normalized repository keys fail closed. +func (c *Client) SetHumanMergePinOnly(policies map[string]PinOnlySpec) { + if c == nil { + return + } + normalized := make(map[string]PinOnlySpec, len(policies)) + for repo, policy := range policies { + key := repoPolicyKey(c.org, repo) + if key == "" { + continue + } + if _, duplicate := normalized[key]; duplicate { + normalized[key] = PinOnlySpec{} + continue + } + normalized[key] = policy.clone() + } + c.mergePolicyMu.Lock() + defer c.mergePolicyMu.Unlock() + c.humanMergePinOnly = normalized +} + +func (c *Client) humanMergePinOnlyFor(repo string) PinOnlySpec { + if c == nil { + return PinOnlySpec{} + } + c.mergePolicyMu.RLock() + defer c.mergePolicyMu.RUnlock() + return c.humanMergePinOnly[repoPolicyKey(c.org, repo)].clone() +} + // mergeRequestHumanMergePathRefusal checks a merge request against the // repo's human-merge paths. It returns a non-empty refusal (terminal) when -// the PR touches one — after adding `hold` and the single marker comment — +// the PR touches one without a proven pin-only exception — after adding +// `hold` and the single marker comment — // and an error when the repo has paths configured but the complete // changed-file list cannot be established (fail closed). An unconfigured // repo costs no API call. @@ -216,6 +266,37 @@ func (c *Client) mergeRequestHumanMergePathRefusal(ctx context.Context, req Merg if len(matches) == 0 { return "", nil } + if ex := c.humanMergePinOnlyFor(req.Repo); ex.Enabled { + reason := "PR author is not trusted" + trusted := false + for _, author := range ex.TrustedAuthors { + if author != "" && strings.EqualFold(author, pr.GetUser().GetLogin()) { + trusted = true + break + } + } + if trusted { + switch { + case req.ExpectSHA == "" || pr.GetHead().GetSHA() != req.ExpectSHA: + reason = "PR head does not match requested head" + case pr.ChangedFiles == nil || pr.GetChangedFiles() != len(files): + reason = "complete changed-file count is unavailable" + default: + var ok bool + ok, reason = intent.ClassifyPinOnly(files, matches, intent.PinOnlySpec{Paths: ex.Paths, Kinds: ex.Kinds}) + if ok { + // The files endpoint is not SHA-addressable. Ensure the head did not + // move while paging; the eventual merge also uses req.ExpectSHA. + current, _, err := c.client.PullRequests.Get(ctx, owner, name, req.Number) + if err == nil && current.GetHead().GetSHA() == req.ExpectSHA { + return "", nil + } + reason = "PR head could not be confirmed after listing files" + } + } + } + c.warn("merge-request watcher: pin-only exception rejected", "repo", req.Repo, "pr", req.Number, "reason", reason) + } if err := HoldForHumanMergePaths(ctx, c.client, owner, name, req.Number, matches, pr.GetHead().GetSHA()); err != nil { c.warn("merge-request watcher: human-merge-path hold failed", "repo", req.Repo, "pr", req.Number, "error", err) } diff --git a/src/pkg/github/human_merge_paths_test.go b/src/pkg/github/human_merge_paths_test.go index cf45762c5e..b625cdbc10 100644 --- a/src/pkg/github/human_merge_paths_test.go +++ b/src/pkg/github/human_merge_paths_test.go @@ -19,6 +19,10 @@ import ( type humanPathMergeFixture struct { mu sync.Mutex files []string + fileDetails []map[string]any + prPayload map[string]any + movedHead string + ci *ciFixture prStatus int filesStatus int filesHits int @@ -29,7 +33,10 @@ type humanPathMergeFixture struct { func newHumanPathMergeServer(t *testing.T, f *humanPathMergeFixture) *httptest.Server { t.Helper() - green := greenFixture() + green := f.ci + if green == nil { + green = greenFixture() + } return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { f.mu.Lock() defer f.mu.Unlock() @@ -38,13 +45,19 @@ func newHumanPathMergeServer(t *testing.T, f *humanPathMergeFixture) *httptest.S case r.Method == http.MethodGet && p == "/repos/o/r/pulls/42" && f.prStatus != 0: w.WriteHeader(f.prStatus) return + case r.Method == http.MethodGet && p == "/repos/o/r/pulls/42" && f.prPayload != nil: + if f.movedHead != "" && f.filesHits > 0 { + f.prPayload["head"] = map[string]any{"sha": f.movedHead} + } + _ = json.NewEncoder(w).Encode(f.prPayload) + return case r.Method == http.MethodGet && p == "/repos/o/r/pulls/42/files": f.filesHits++ if f.filesStatus != 0 { w.WriteHeader(f.filesStatus) return } - var out []map[string]any + out := f.fileDetails for _, name := range f.files { out = append(out, map[string]any{"filename": name, "status": "modified"}) } @@ -85,12 +98,15 @@ func newHumanPathMergeServer(t *testing.T, f *humanPathMergeFixture) *httptest.S })) } -func runHumanPathMergeRequest(t *testing.T, f *humanPathMergeFixture, paths map[string][]string) (string, MergeResponse) { +func runHumanPathMergeRequest(t *testing.T, f *humanPathMergeFixture, paths map[string][]string, pinOnly ...map[string]PinOnlySpec) (string, MergeResponse) { t.Helper() srv := newHumanPathMergeServer(t, f) t.Cleanup(srv.Close) c := testMergeClient(t, srv.URL) c.SetHumanMergePaths(paths) + if len(pinOnly) > 0 { + c.SetHumanMergePinOnly(pinOnly[0]) + } dir := t.TempDir() mergeRequestDirForTest = dir @@ -227,3 +243,114 @@ func TestHumanMergePathHelpersGuardNilInputs(t *testing.T) { t.Fatalf("reason = %q", reason) } } + +func pinOnlyRelayFixture() *humanPathMergeFixture { + return &humanPathMergeFixture{ + prPayload: map[string]any{"number": 42, "state": "open", "user": map[string]any{"login": "alice", "type": "User"}, "head": map[string]any{"sha": "abc", "repo": map[string]any{"full_name": "o/r"}}, "base": map[string]any{"ref": "main", "repo": map[string]any{"full_name": "o/r"}}, "changed_files": 1}, + fileDetails: []map[string]any{{"filename": "Containerfile", "status": "modified", "additions": 1, "deletions": 1, "patch": "@@ -1 +1 @@\n-FROM image@sha256:" + strings.Repeat("a", 64) + "\n+FROM image@sha256:" + strings.Repeat("b", 64)}}, + } +} + +func TestMergeRequestPinOnlyException(t *testing.T) { + for _, tc := range []struct { + name string + change func(*humanPathMergeFixture, *PinOnlySpec) + wantPass bool + wantUnknown bool + }{ + {name: "trusted pin", wantPass: true}, + {name: "disabled", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { ex.Enabled = false }}, + {name: "untrusted", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { ex.TrustedAuthors = []string{"bob"} }}, + {name: "empty trust list", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { ex.TrustedAuthors = nil }}, + {name: "mixed diff", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { + f.fileDetails[0]["patch"] = strings.Replace(f.fileDetails[0]["patch"].(string), "@@ -1 +1 @@", "@@ -1 +1,2 @@", 1) + "\n+RUN echo unsafe" + f.fileDetails[0]["additions"] = 2 + }}, + {name: "unguarded extra file", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { + f.prPayload["changed_files"] = 2 + f.files = []string{"README.md"} + }}, + {name: "outside exception paths", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { ex.Paths = []string{".github/workflows/*.yml"} }}, + {name: "missing patch", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { delete(f.fileDetails[0], "patch") }}, + {name: "missing count", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { delete(f.prPayload, "changed_files") }}, + {name: "incomplete list", wantUnknown: true, change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { f.prPayload["changed_files"] = 2 }}, + {name: "wrong head", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { f.prPayload["head"] = map[string]any{"sha": "other"} }}, + {name: "head moves during file fetch", change: func(f *humanPathMergeFixture, ex *PinOnlySpec) { f.movedHead = "other" }}, + } { + t.Run(tc.name, func(t *testing.T) { + f := pinOnlyRelayFixture() + ex := PinOnlySpec{Enabled: true, Paths: []string{"Containerfile"}, Kinds: []string{"image-digest"}, TrustedAuthors: []string{"ALICE"}} + if tc.change != nil { + tc.change(f, &ex) + } + _, resp := runHumanPathMergeRequest(t, f, map[string][]string{"o/r": {"Containerfile"}}, map[string]PinOnlySpec{"O/R": ex}) + if tc.wantPass { + if !resp.OK || f.merges != 1 || len(f.labels) != 0 || len(f.comments) != 0 { + t.Fatalf("result=%+v merges=%d labels=%v comments=%v; want merge without hold", resp, f.merges, f.labels, f.comments) + } + } else { + if resp.OK || f.merges != 0 { + t.Fatalf("result=%+v merges=%d; want refusal", resp, f.merges) + } + if tc.wantUnknown { + if !strings.Contains(resp.Error, "fail closed") || len(f.labels) != 0 || len(f.comments) != 0 { + t.Fatalf("unknown list must fail closed without a hold: %+v", resp) + } + } else if len(f.labels) != 1 || len(f.comments) != 1 || !strings.Contains(f.comments[0], HumanMergePathMarker) { + t.Fatalf("labels=%v comments=%v; want hold and marker", f.labels, f.comments) + } + } + }) + } +} + +func TestMergeRequestPinOnlyStillRequiresGreenCI(t *testing.T) { + f := pinOnlyRelayFixture() + f.ci = greenFixture() + f.ci.checks[0].conclusion = "failure" + _, resp := runHumanPathMergeRequest(t, f, map[string][]string{"o/r": {"Containerfile"}}, map[string]PinOnlySpec{"r": {Enabled: true, Paths: []string{"Containerfile"}, Kinds: []string{"image-digest"}, TrustedAuthors: []string{"alice"}}}) + if resp.OK || f.merges != 0 || len(f.labels) != 0 || len(f.comments) != 0 { + t.Fatalf("result=%+v merges=%d labels=%v comments=%v; pin exception must still fail CI", resp, f.merges, f.labels, f.comments) + } +} + +func TestSetHumanMergePinOnlyReload(t *testing.T) { + c := NewClientForTest("http://127.0.0.1:0", "o", []string{"r"}, slog.New(slog.NewTextHandler(io.Discard, nil))) + ex := PinOnlySpec{Enabled: true, Paths: []string{"Containerfile"}, Kinds: []string{"image-digest"}, TrustedAuthors: []string{"alice"}} + c.SetHumanMergePinOnly(map[string]PinOnlySpec{" O/R ": ex}) + ex.Paths[0] = "unsafe" + got := c.humanMergePinOnlyFor("r") + if !got.Enabled || got.Paths[0] != "Containerfile" { + t.Fatalf("policy not normalized or copied: %+v", got) + } + got.Paths[0] = "unsafe" + if c.humanMergePinOnlyFor("r").Paths[0] != "Containerfile" { + t.Fatal("lookup must return a copy") + } + c.SetHumanMergePinOnly(map[string]PinOnlySpec{"r": ex, "O/R": ex}) + if c.humanMergePinOnlyFor("r").Enabled { + t.Fatal("duplicate normalized keys must fail closed") + } + c.SetHumanMergePinOnly(nil) + if c.humanMergePinOnlyFor("r").Enabled { + t.Fatal("nil must clear policy") + } + var absent *Client + absent.SetHumanMergePinOnly(nil) + if absent.humanMergePinOnlyFor("r").Enabled { + t.Fatal("nil client must have no policy") + } +} + +func TestMergeRequestPinOnlyRequiresExpectedHead(t *testing.T) { + f := pinOnlyRelayFixture() + srv := newHumanPathMergeServer(t, f) + defer srv.Close() + c := testMergeClient(t, srv.URL) + c.SetHumanMergePaths(map[string][]string{"o/r": {"Containerfile"}}) + c.SetHumanMergePinOnly(map[string]PinOnlySpec{"o/r": {Enabled: true, Paths: []string{"Containerfile"}, Kinds: []string{"image-digest"}, TrustedAuthors: []string{"alice"}}}) + refusal, err := c.mergeRequestHumanMergePathRefusal(context.Background(), MergeRequest{Repo: "o/r", Number: 42}) + if err != nil || refusal == "" || len(f.labels) != 1 || len(f.comments) != 1 { + t.Fatalf("refusal=%q err=%v labels=%v comments=%v; missing requested head must hold", refusal, err, f.labels, f.comments) + } +} diff --git a/src/pkg/github/merge_request_watcher.go b/src/pkg/github/merge_request_watcher.go index cd8aa3796e..9dd0a114c8 100644 --- a/src/pkg/github/merge_request_watcher.go +++ b/src/pkg/github/merge_request_watcher.go @@ -423,8 +423,8 @@ func (c *Client) handleOneMergeRequest(ctx context.Context, path string, nowFn f return } // Human-merge paths (#11039): a PR touching a path listed in - // auto_merge.human_merge_paths for its repo is never merged by the App, - // whatever agent asks. A match is terminal (the request is refused, the + // auto_merge.human_merge_paths for its repo requires a person unless the + // configured pin-only exception is proven, whatever agent asks. A match is terminal (the request is refused, the // PR gets `hold` and one marker comment); an unknown changed-file list on // a configured repo fails closed through the bounded retry path. Checked // before the optional branch-update so a refused PR receives no push.