From 6f66f624f283412c37c0ef4ecb6ebe625140eb4b Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Mon, 2 Nov 2026 19:34:45 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(github):=20classify=20the=20?= =?UTF-8?q?hive:status=20comment=20writer=20and=20reconcile=20the=20direct?= =?UTF-8?q?-write=20ratchet?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --- changelog.d/fixed-16335.md | 1 + src/docs/notifications.md | 1 + src/pkg/github/notification_write_sites.go | 1 + src/pkg/writeback/testdata/direct-writes-baseline.txt | 5 +++-- 4 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 changelog.d/fixed-16335.md diff --git a/changelog.d/fixed-16335.md b/changelog.d/fixed-16335.md new file mode 100644 index 0000000000..36c085531b --- /dev/null +++ b/changelog.d/fixed-16335.md @@ -0,0 +1 @@ +- The `hive:status` comment writer (`clientStatusForge.CreateComment`) is now classified as a `status` passthrough in the notification write-site inventory, and the direct-write ratchet baseline is reconciled with the serialised status writer from #16319, turning `v5` CI green again after two concurrent merges missed each other ([#16335](https://github.com/hivecommons/hive/issues/16335)). diff --git a/src/docs/notifications.md b/src/docs/notifications.md index c611aec27c..95d78107e9 100644 --- a/src/docs/notifications.md +++ b/src/docs/notifications.md @@ -424,6 +424,7 @@ without a class. Review submissions and review requests are always counted as | `github.(*Client).priorArtGateClose` | `status` | | | `github.(*Client).reconcileBlockedTargets` | `status` | | | `github.(*Client).recordReviewEvidenceMerge` | `status` | | +| `github.(*clientStatusForge).CreateComment` | `status` | passthrough wrapper; attributed to its caller | | `github.SyncIssueStageLabelsWith` | `status` | | | `github.ensureIssueStagePRLink` | `status` | | | `github.githubIssueBacklogSink.AppendToItem` | `status` | | diff --git a/src/pkg/github/notification_write_sites.go b/src/pkg/github/notification_write_sites.go index b764528475..b0b42313f6 100644 --- a/src/pkg/github/notification_write_sites.go +++ b/src/pkg/github/notification_write_sites.go @@ -27,6 +27,7 @@ var notificationWriteSites = map[string]NotificationWriteSite{ "main.(*repoForgeRouter).CreateIssueComment": {Class: NotificationClassAttention, Passthrough: true}, "main.liveTriageCommenter.CreateIssueComment": {Class: NotificationClassAttention, Passthrough: true}, "github.(*Client).UpsertIssueMarkerComment": {Class: NotificationClassStatus, Passthrough: true}, + "github.(*clientStatusForge).CreateComment": {Class: NotificationClassStatus, Passthrough: true}, // status: bookkeeping readable on demand. "dashboard.(*ContributeWSHub).markAlreadyDoneIssue": {Class: NotificationClassStatus}, diff --git a/src/pkg/writeback/testdata/direct-writes-baseline.txt b/src/pkg/writeback/testdata/direct-writes-baseline.txt index 670a7f79ba..fd121804ef 100644 --- a/src/pkg/writeback/testdata/direct-writes-baseline.txt +++ b/src/pkg/writeback/testdata/direct-writes-baseline.txt @@ -15,7 +15,7 @@ raw pkg/github/automerge/automerge_held_runs.go 3 raw pkg/github/automerge/automerge_merge_commit.go 1 raw pkg/github/automerge/automerge_merge_forward.go 1 raw pkg/github/automerge/automerge_stage_human.go 1 -raw pkg/github/automerge/automerge_stage_labels.go 3 +raw pkg/github/automerge/automerge_stage_labels.go 5 raw pkg/github/automerge/automerge_sweep_queued.go 3 raw pkg/github/automerge/automerge_sweep_trusted.go 4 raw pkg/github/automerge/automerge_unauthorized.go 3 @@ -38,6 +38,7 @@ raw pkg/github/pr_contributor_link.go 1 raw pkg/github/pr_issue_link.go 2 raw pkg/github/pr_level_hold.go 5 raw pkg/github/pr_signed_reconcile.go 1 +raw pkg/github/pr_status_comment.go 2 raw pkg/github/pr_supersession_autoclose.go 3 raw pkg/github/pr_supersession_resolve.go 1 raw pkg/github/pr_supersession_sweep.go 2 @@ -106,7 +107,7 @@ wrap pkg/github/pr_duplicate_guard.go 1 wrap pkg/github/pr_level_hold.go 1 wrap pkg/github/pr_reporter_trust_release.go 1 wrap pkg/github/pr_request_watcher.go 3 -wrap pkg/github/pr_status_comment.go 1 +wrap pkg/github/pr_status_comment.go 2 wrap pkg/github/pr_supersession_autoclose.go 1 wrap pkg/github/pr_supersession_decision.go 1 wrap pkg/github/pr_supersession_resolve.go 6