From 8cf2d6809af207d0938a8480b7f5562bb28ba3d4 Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Sat, 31 Oct 2026 14:07:31 -0400 Subject: [PATCH 1/3] fix(dashboard): treat an omp HOME without a sign-in as expected, not a repeated error Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --- .../fixed-16080-omp-home-probe-log-level.md | 1 + src/pkg/dashboard/cli_models_omp.go | 2 +- src/pkg/dashboard/cli_models_omp_test.go | 39 ++++++++++++++++++- 3 files changed, 40 insertions(+), 2 deletions(-) create mode 100644 changelog.d/fixed-16080-omp-home-probe-log-level.md diff --git a/changelog.d/fixed-16080-omp-home-probe-log-level.md b/changelog.d/fixed-16080-omp-home-probe-log-level.md new file mode 100644 index 0000000000..af8655a02e --- /dev/null +++ b/changelog.d/fixed-16080-omp-home-probe-log-level.md @@ -0,0 +1 @@ +- An omp agent HOME without a sign-in no longer files a repeated fleet defect: the per-HOME "omp model discovery found no models for this HOME" line during model discovery is logged at Info instead of Warn, since a HOME with no sign-in contributes nothing by design. The "serving static fallback" warning, emitted only when every HOME fails, is unchanged ([#16080](https://github.com/hivecommons/hive/issues/16080)). diff --git a/src/pkg/dashboard/cli_models_omp.go b/src/pkg/dashboard/cli_models_omp.go index 493a07063c..1cc0d8809b 100644 --- a/src/pkg/dashboard/cli_models_omp.go +++ b/src/pkg/dashboard/cli_models_omp.go @@ -84,7 +84,7 @@ func (s *Server) discoverOmpModels() cliModelResult { } lastErr = err if s.logger != nil { - s.logger.Warn("omp model discovery found no models for this HOME", "home", home, "err", err.Error()) + s.logger.Info("omp model discovery found no models for this HOME", "home", home, "err", err.Error()) } continue } diff --git a/src/pkg/dashboard/cli_models_omp_test.go b/src/pkg/dashboard/cli_models_omp_test.go index 60f8fecf6d..f1a99da50c 100644 --- a/src/pkg/dashboard/cli_models_omp_test.go +++ b/src/pkg/dashboard/cli_models_omp_test.go @@ -1,6 +1,12 @@ package dashboard -import "testing" +import ( + "bytes" + "errors" + "log/slog" + "strings" + "testing" +) func TestOmpProbeRunsUnderGivenHome(t *testing.T) { t.Setenv("HOME", "/data/home/agents/x") @@ -30,3 +36,34 @@ func TestOmpStaticEffortsMatchCatalog(t *testing.T) { t.Errorf("gemini-3.7-flash efforts = %v", got) } } + +func TestOmpHomeWithoutSignInIsNotAWarning(t *testing.T) { + t.Setenv("HOME", "/data/home/agents/unsigned") + orig := runOmpModelsProbe + t.Cleanup(func() { runOmpModelsProbe = orig }) + runOmpModelsProbe = func(home string) ([]string, map[string][]string, error) { + return nil, nil, errors.New("omp models failed: exit status 1") + } + var buf bytes.Buffer + s := newTestServer() + s.logger = slog.New(slog.NewTextHandler(&buf, &slog.HandlerOptions{Level: slog.LevelDebug})) + r := s.discoverOmpModels() + if !r.fallback { + t.Fatalf("expected static fallback when no HOME has a sign-in: %+v", r) + } + var sawMiss bool + for _, line := range strings.Split(buf.String(), "\n") { + if strings.Contains(line, "found no models for this HOME") { + sawMiss = true + if strings.Contains(line, "level=WARN") { + t.Fatalf("per-HOME miss must not log at WARN (fleet reporter files it as a defect): %s", line) + } + } + } + if !sawMiss { + t.Fatal("per-HOME miss should still be logged below WARN") + } + if !strings.Contains(buf.String(), "level=WARN msg=\"omp model discovery unavailable") { + t.Fatalf("all-homes-failed warning must remain: %s", buf.String()) + } +} From 020f5e3addea911b23a6f64b976d00e615fbfe50 Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Sat, 31 Oct 2026 14:40:24 -0400 Subject: [PATCH 2/3] fix(dashboard): log omp all-homes-failed fallback at Info, not Warn With a single omp HOME (or the process-HOME probe) every per-HOME miss is also an all-homes miss, so the retained Warn refiled the same expected condition under a new unclassified_error_repeated fingerprint. Lower it to Info to match the goose/agy/claude backends; the degraded transition is already audited once by auditDiscoveryTransition. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --- .../fixed-16080-omp-home-probe-log-level.md | 2 +- src/pkg/dashboard/cli_models_omp.go | 2 +- src/pkg/dashboard/cli_models_omp_test.go | 15 ++++++++++++--- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/changelog.d/fixed-16080-omp-home-probe-log-level.md b/changelog.d/fixed-16080-omp-home-probe-log-level.md index af8655a02e..19da69d472 100644 --- a/changelog.d/fixed-16080-omp-home-probe-log-level.md +++ b/changelog.d/fixed-16080-omp-home-probe-log-level.md @@ -1 +1 @@ -- An omp agent HOME without a sign-in no longer files a repeated fleet defect: the per-HOME "omp model discovery found no models for this HOME" line during model discovery is logged at Info instead of Warn, since a HOME with no sign-in contributes nothing by design. The "serving static fallback" warning, emitted only when every HOME fails, is unchanged ([#16080](https://github.com/hivecommons/hive/issues/16080)). +- An omp agent HOME without a sign-in no longer files a repeated fleet defect: both the per-HOME "omp model discovery found no models for this HOME" line and the all-homes-failed "omp model discovery unavailable, serving static fallback" line are logged at Info instead of Warn, matching the goose/agy/claude backends. A HOME with no sign-in contributes nothing by design, and the degraded-discovery transition is already audited once by the discovery tracker ([#16080](https://github.com/hivecommons/hive/issues/16080)). diff --git a/src/pkg/dashboard/cli_models_omp.go b/src/pkg/dashboard/cli_models_omp.go index 1cc0d8809b..f89dd75f4e 100644 --- a/src/pkg/dashboard/cli_models_omp.go +++ b/src/pkg/dashboard/cli_models_omp.go @@ -97,7 +97,7 @@ func (s *Server) discoverOmpModels() cliModelResult { } if len(models) == 0 { if s.logger != nil { - s.logger.Warn("omp model discovery unavailable, serving static fallback", "homes", homes, "err", fmt.Sprint(lastErr)) + s.logger.Info("omp model discovery unavailable, serving static fallback", "homes", homes, "err", fmt.Sprint(lastErr)) } return cliModelResult{fallback: true, reasoningEfforts: cloneEffortMap(ompStaticReasoningEfforts)} } diff --git a/src/pkg/dashboard/cli_models_omp_test.go b/src/pkg/dashboard/cli_models_omp_test.go index f1a99da50c..76e9bead9d 100644 --- a/src/pkg/dashboard/cli_models_omp_test.go +++ b/src/pkg/dashboard/cli_models_omp_test.go @@ -51,7 +51,7 @@ func TestOmpHomeWithoutSignInIsNotAWarning(t *testing.T) { if !r.fallback { t.Fatalf("expected static fallback when no HOME has a sign-in: %+v", r) } - var sawMiss bool + var sawMiss, sawFallback bool for _, line := range strings.Split(buf.String(), "\n") { if strings.Contains(line, "found no models for this HOME") { sawMiss = true @@ -59,11 +59,20 @@ func TestOmpHomeWithoutSignInIsNotAWarning(t *testing.T) { t.Fatalf("per-HOME miss must not log at WARN (fleet reporter files it as a defect): %s", line) } } + if strings.Contains(line, "omp model discovery unavailable") { + sawFallback = true + if strings.Contains(line, "level=WARN") { + t.Fatalf("all-homes-failed fallback must not log at WARN (fleet reporter files it as a defect): %s", line) + } + } } if !sawMiss { t.Fatal("per-HOME miss should still be logged below WARN") } - if !strings.Contains(buf.String(), "level=WARN msg=\"omp model discovery unavailable") { - t.Fatalf("all-homes-failed warning must remain: %s", buf.String()) + if !sawFallback { + t.Fatal("all-homes-failed fallback should still be logged below WARN") + } + if strings.Contains(buf.String(), "level=WARN") { + t.Fatalf("discoverOmpModels must not emit any WARN for a HOME without a sign-in: %s", buf.String()) } } From 7d5cecea4459f04b2ef03317d2055351262ade87 Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Sat, 31 Oct 2026 15:42:38 -0400 Subject: [PATCH 3/3] chore: retrigger CI after native-queue-policy bootstrap landed on v6 (#16061) Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>