diff --git a/src/pkg/github/issue_blocker_test.go b/src/pkg/github/issue_blocker_test.go index 209b0231ce..8e1dae4d36 100644 --- a/src/pkg/github/issue_blocker_test.go +++ b/src/pkg/github/issue_blocker_test.go @@ -59,6 +59,35 @@ func TestWebhookIssueCommentRecordsBlocker(t *testing.T) { } } +// hivecommons/hive#15273: a blocker recorded from a live issue_comment +// delivery (not seeded via Observe) is forgotten when GitHub later closes +// the issue, so capabilities.blocked_items stops counting it while other +// items keep their count. Negative cases (labeled, PR close, reopen) live in +// TestWebhookClosedIssueClearsBlocker. +func TestWebhookCommentSeededBlockerClearsOnClose(t *testing.T) { + l := swapSharedLedger(t) + c, _ := setupWebhookCacheTest(t) + at := time.Date(2026, 10, 20, 19, 33, 0, 0, time.UTC) + res, err := c.HandleWebhookEvent("issue_comment", []byte(`{"action":"created","issue":{"number":21},"comment":{"body":`+jsonString(workflowsReport)+`,"created_at":"2026-10-20T19:33:00Z"},"repository":{"full_name":"org/repo"}}`)) + if err != nil || res.BlockerKind == "" { + t.Fatalf("seed: %+v %v", res, err) + } + repo := res.ConfiguredRepo + l.Observe(repo, 22, workflowsReport, at) + if _, ok := l.Blocking(repo, 21); !ok { + t.Fatal("issue 21 not blocking before close") + } + if _, err := c.HandleWebhookEvent("issues", []byte(`{"action":"closed","issue":{"number":21,"state":"closed"},"repository":{"full_name":"org/repo"}}`)); err != nil { + t.Fatal(err) + } + if _, ok := l.Get(repo, 21); ok { + t.Fatal("closed issue kept its ledger row") + } + if got := l.Capabilities(); got.BlockedItems != 1 { + t.Fatalf("blocked_items = %+v, want only issue 22", got) + } +} + func jsonString(s string) string { return `"` + strings.NewReplacer(`\`, `\\`, `"`, `\"`, "\n", `\n`).Replace(s) + `"` }