From 520092a87258d24b72674de1a4362a8abf1a880a Mon Sep 17 00:00:00 2001 From: onkar717 Date: Thu, 29 Oct 2026 11:23:47 +0530 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(dashboard):=20pass=20PR-open?= =?UTF-8?q?=20predicate=20to=20stageTrackerResolveLinkedPRs=20calls?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit stageTrackerResolveLinkedPRs gained a second open func(repo string, number int) bool parameter but TestStageTrackerLinkedPRProgressRowsAndEvents still called it with one argument, breaking the v5 build (pkg/dashboard/stage_tracker_linked_progress_test.go:95,101). Pass nil, which the function already treats as "no cross-repository vouching" (stage_tracker.go:2996). Hive-Run: hivecommons/hive#15320 Hive-Plan: fix-v5-test-failure-15320 Hive-Spec: tests#compile-fix Signed-off-by: onkar717 --- src/pkg/dashboard/stage_tracker_linked_progress_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pkg/dashboard/stage_tracker_linked_progress_test.go b/src/pkg/dashboard/stage_tracker_linked_progress_test.go index 06e36fc78a..8fbfdbb58e 100644 --- a/src/pkg/dashboard/stage_tracker_linked_progress_test.go +++ b/src/pkg/dashboard/stage_tracker_linked_progress_test.go @@ -92,13 +92,13 @@ func TestStageTrackerLinkedPRProgressRowsAndEvents(t *testing.T) { {Repo: "acme/console", Number: 15223, Kind: "pr", Stage: trackerNumberNeedsAuthor, Caption: "Needs @pat to fix CI", LinkedIssues: []StageTrackerLinkedIssue{{Number: 15218}}}, } - stageTrackerResolveLinkedPRs(items) + stageTrackerResolveLinkedPRs(items, nil) before, err := json.Marshal(items) if err != nil { t.Fatal(err) } items[1].Caption = "Needs @pat to rebase" - stageTrackerResolveLinkedPRs(items) + stageTrackerResolveLinkedPRs(items, nil) after, err := json.Marshal(items) if err != nil { t.Fatal(err)