From b9f25d876c136d5a81ad7bf0af641c05a084b365 Mon Sep 17 00:00:00 2001 From: thatguywob Date: Thu, 29 Oct 2026 05:31:07 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=96=20docs:=20clarify=20delegated=20is?= =?UTF-8?q?sue=20park=20diagnosis?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Describe the label predicate without attributing a never-lifted park to #15021, where the scanner parked the issue again. Clarify the stuck-label fixture uses no later re-park evidence. Hive-Run: hivecommons/hive#15296 Hive-Plan: reconcile-delegated-park-comments Hive-Spec: hivecommons/hive#15296#contradictory-diagnosis Signed-off-by: thatguywob --- .../dashboard/api_repo_item_decide_delegated_test.go | 7 ++++--- src/pkg/dashboard/delegated_decision_effect.go | 10 ++++++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/pkg/dashboard/api_repo_item_decide_delegated_test.go b/src/pkg/dashboard/api_repo_item_decide_delegated_test.go index 38f3972b33..195da01488 100644 --- a/src/pkg/dashboard/api_repo_item_decide_delegated_test.go +++ b/src/pkg/dashboard/api_repo_item_decide_delegated_test.go @@ -619,9 +619,10 @@ func TestReparkFromEvents(t *testing.T) { } } -// TestDelegatedDecisionStuckIssueWording reproduces hivecommons/hive#15021: -// the hive approved an ISSUE (`default-approve`), approved-direction landed -// but stage/045-needs-decision never came off. Past the effect timeout the +// TestDelegatedDecisionStuckIssueWording covers an approved issue with both +// approved-direction and stage/045-needs-decision, with no later re-park +// recorded. Unlike hivecommons/hive#15021, this fixture has no timeline +// evidence that the park lifted and was added again. Past the effect timeout the // toast must not say "approved for merge" (nothing merges on an issue), // must name the stuck label, and must offer the lift first. func TestDelegatedDecisionStuckIssueWording(t *testing.T) { diff --git a/src/pkg/dashboard/delegated_decision_effect.go b/src/pkg/dashboard/delegated_decision_effect.go index c4a8ebe19e..49c5885e48 100644 --- a/src/pkg/dashboard/delegated_decision_effect.go +++ b/src/pkg/dashboard/delegated_decision_effect.go @@ -209,10 +209,12 @@ func (s *Server) delegatedStuckWhy(in delegatedecision.Input, d delegatedecision } } -// issueParkLabelStuck reports the case seen on hivecommons/hive#15021: the -// hive approved an issue and `approved-direction` landed, but the -// stage/045-needs-decision park label never came off, so the scanner keeps -// skipping the issue. The toast names the label and offers the lift. +// issueParkLabelStuck reports an approved issue that still carries both +// approved-direction and stage/045-needs-decision. The labels alone do not +// show whether the park was never lifted or was added again. The caller +// handles later re-parks first (hivecommons/hive#15021: approve lifted 045, +// then the scanner re-parked), so those become a new ask rather than a +// stuck-label diagnosis. The toast names the label and offers the lift. func issueParkLabelStuck(in delegatedecision.Input, d delegatedecision.Decision) bool { if in.Kind != delegatedecision.KindIssue || d.Verdict != delegatedecision.VerdictApprove { return false