From 39bcd6f570ead16d751ffe89d6ed6ce573e0342a Mon Sep 17 00:00:00 2001 From: Andrew Anderson Date: Thu, 29 Oct 2026 00:40:41 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20dashboard:=20sidebar=20Overview?= =?UTF-8?q?=20and=20activity-monitor=20counts=20explain=20and=20align=20th?= =?UTF-8?q?eir=20populations?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Overview pill prints the open set as items (33 issues / 13 PRs); the Hive activity monitor pill prints the same set as rows (every issue, plus each PR not drawn under a listed issue). Nothing said so, so 33/13 beside 37 read as a disagreement. Both tooltips and the activity-monitor header now name the unit and spell out the row make-up (37 rows (33 issues + 4 PRs on their own row) · 9 PRs shown on their issue's row). Docs corrected; node-harness tests cover the derivation. Fixes #15295 Signed-off-by: Andrew Anderson --- ...ixed-sidebar-counts-explain-populations.md | 1 + src/docs/dashboard-sections.md | 5 ++- src/pkg/dashboard/open_items_test.go | 10 +++-- .../dashboard/overview_kpi_sparklines_test.go | 2 +- .../overview_kpi_values_10139_test.go | 1 + .../dashboard/overview_sidebar_pill_test.go | 2 +- src/pkg/dashboard/stage_tracker_ui_test.go | 19 ++++++++- src/pkg/dashboard/static/index.html | 42 +++++++++++++++---- 8 files changed, 66 insertions(+), 16 deletions(-) create mode 100644 changelog.d/fixed-sidebar-counts-explain-populations.md diff --git a/changelog.d/fixed-sidebar-counts-explain-populations.md b/changelog.d/fixed-sidebar-counts-explain-populations.md new file mode 100644 index 0000000000..1f7a7b13ae --- /dev/null +++ b/changelog.d/fixed-sidebar-counts-explain-populations.md @@ -0,0 +1 @@ +- Dashboard sidebar: the Overview counter (`33/13`, open issues / open PRs) and the Hive activity monitor counter (`37`, rows) count the same open set two ways — every open issue is a row, a PR is its own row only when not drawn under a listed issue. Both tooltips and the activity-monitor header now say so (`37 rows (33 issues + 4 PRs on their own row) · 9 PRs shown on their issue's row`), so the numbers read as one population, not a disagreement. diff --git a/src/docs/dashboard-sections.md b/src/docs/dashboard-sections.md index 0dc6e1c4dc..6085f3b43b 100644 --- a/src/docs/dashboard-sections.md +++ b/src/docs/dashboard-sections.md @@ -44,7 +44,8 @@ How many issues and pull requests Hive is tracking right now, and how many of th - **Total open issues** and **Total open PRs** count every open issue and every open pull request in the repositories you selected. Draft pull requests count too. - When the ForgeState cache (`forgestate.enabled: true`) has finished its first full scan of a repository, the two totals are read from that cache instead of from the GitHub search API. The cache is kept current by webhook events and its own low-rate refresh, so the totals do not cost a `/search/issues` request on every status refresh. The actionable, held, blocked and outside parts still come from Hive's own classification; whatever the cache counts that the classification has not placed yet lands in Outside's **hold-adjacent/other** part, so the sum always matches the total. - If GitHub rate-limits or fails the count request, the tiles keep the last good numbers and show **Counts stale since