From da2e388034bf01e690451a705465b75162a4bf37 Mon Sep 17 00:00:00 2001 From: Andrew Anderson Date: Wed, 28 Oct 2026 15:10:09 -0400 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=90=9B=20Let=20hive=20decide:=20say?= =?UTF-8?q?=20when=20a=20decision=20never=20took=20effect,=20in=20plain=20?= =?UTF-8?q?words?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A delegated decision whose expected effect (park lifted, merge, close, fresh hive PR, new commit) has not shown within decisions.delegate.effect_timeout (default 30m) is reported as no-effect: "Hive decided at , but it hasn't taken effect: " with Merge as maintainer / Re-run decision (force) / Close as superseded / Send back for a new commit as toast buttons, plus one plain-words follow-up comment on the item (stalled marker, never a second decision). Inside the window the no-op names the decision and the deadline instead of a bare rule slug. One glossary (pkg/delegatedecision/decision_glossary.go, mirrored as STAGE_TRACKER_DECISION_GLOSSARY with a drift test) renders every rule, verdict and reason in plain words across toast, popover, PR comment and tooltip. The delegate's comment carries Hive decided / Why / What happens next / If it doesn't happen above the attribution and machine marker. A /hive decision comment the hive itself posted (delegated marker) is no longer read as a maintainer's change request, whichever login posted it — the self-blocking seen on #14822 (contributor-lane:changes-requested every cycle on the PR that carried the parser fix). Signed-off-by: Andrew Anderson --- .../fixed-stuck-decision-plain-words.md | 1 + src/docs/dashboard-sections.md | 6 +- src/docs/labels-and-control-signals.md | 73 +++++ src/docs/operator-reference.md | 2 +- src/pkg/config/decisions.go | 30 +- src/pkg/config/decisions_test.go | 19 ++ .../api_repo_item_decide_delegated.go | 53 ++-- .../api_repo_item_decide_delegated_test.go | 146 ++++++++- .../dashboard/api_repo_item_decision_test.go | 3 + .../dashboard/delegated_decision_effect.go | 237 ++++++++++++++ src/pkg/dashboard/row_action_result.go | 8 +- src/pkg/dashboard/stage_tracker_decision.go | 8 + .../dashboard/stage_tracker_glossary_test.go | 47 +++ .../stage_tracker_row_actions_test.go | 50 ++- src/pkg/dashboard/static/index.html | 151 ++++++++- src/pkg/delegatedecision/decision_comment.go | 185 +++++++++++ src/pkg/delegatedecision/decision_glossary.go | 297 ++++++++++++++++++ .../decision_glossary_test.go | 172 ++++++++++ src/pkg/delegatedecision/policy.go | 21 +- src/pkg/github/issue_unpark_command.go | 2 +- src/pkg/github/pr_unpark_decision.go | 14 +- src/pkg/github/pr_unpark_decision_test.go | 54 ++++ 22 files changed, 1513 insertions(+), 66 deletions(-) create mode 100644 changelog.d/fixed-stuck-decision-plain-words.md create mode 100644 src/pkg/dashboard/delegated_decision_effect.go create mode 100644 src/pkg/dashboard/stage_tracker_glossary_test.go create mode 100644 src/pkg/delegatedecision/decision_comment.go create mode 100644 src/pkg/delegatedecision/decision_glossary.go create mode 100644 src/pkg/delegatedecision/decision_glossary_test.go diff --git a/changelog.d/fixed-stuck-decision-plain-words.md b/changelog.d/fixed-stuck-decision-plain-words.md new file mode 100644 index 0000000000..6958c3cb55 --- /dev/null +++ b/changelog.d/fixed-stuck-decision-plain-words.md @@ -0,0 +1 @@ +- "Let hive decide" now tells the owner when a recorded decision never took effect and what to do about it: past `decisions.delegate.effect_timeout` (default 30m) a repeat click answers "Hive decided at