diff --git a/changelog.d/fixed-15009.md b/changelog.d/fixed-15009.md new file mode 100644 index 0000000000..1c65a93f1c --- /dev/null +++ b/changelog.d/fixed-15009.md @@ -0,0 +1 @@ +- A busy hive whose reviewer lane is backed up no longer files a repeated unclassified runtime-error self-report for the one-shot "PR waits on the hive past the stage dwell" warning; the condition stays in the log and the dashboard's hive-held count ([#15009](https://github.com/hivecommons/hive/issues/15009)). diff --git a/src/pkg/fleetreport/fleetreport.go b/src/pkg/fleetreport/fleetreport.go index f039e1dbe6..f0dc43b505 100644 --- a/src/pkg/fleetreport/fleetreport.go +++ b/src/pkg/fleetreport/fleetreport.go @@ -772,6 +772,16 @@ var benignSubstrings = []string{ // That is the merge-safety policy working as designed, re-logged per // merge attempt, not a repeated runtime defect (hivecommons/hive#14727). "forward-merge guard: refusing to squash", + // The stage labeller (src/pkg/github/automerge/automerge_stage_labels.go) + // warns once per PR per quiet period when a PR waiting on the hive + // (review pending, checks running) sits past its stage dwell, and + // surfaces the same condition as the dashboard's hive-held count + // (hivecommons/hive#12534). The feed keys on the message alone, so a + // busy hive whose reviewer lane is backed up has every held PR warn once + // and the burst across unrelated PRs reads as one repeated defect — it + // is a per-hive operational signal, not a runtime error + // (hivecommons/hive#15009). + "stage labels: pr waits on the hive past the stage dwell", } // IsBenignMessage reports whether a raw log message is noise the generic diff --git a/src/pkg/fleetreport/runtime_test.go b/src/pkg/fleetreport/runtime_test.go index 07fad20f98..a794a480c8 100644 --- a/src/pkg/fleetreport/runtime_test.go +++ b/src/pkg/fleetreport/runtime_test.go @@ -807,6 +807,15 @@ func TestIsBenignMessageForwardMergeGuard(t *testing.T) { } } +func TestIsBenignMessageStageHiveHeld(t *testing.T) { + if !IsBenignMessage("stage labels: PR waits on the hive past the stage dwell — reviewer lane needs attention") { + t.Error("hive-held stage dwell warning not benign") + } + if IsBenignMessage("stage labels: provisioning failed") { + t.Error("stage label provisioning failure wrongly benign") + } +} + func TestIsBenignMessageCopilotModelFallback(t *testing.T) { const msg = "copilot CLI substituted the configured model" if !IsBenignMessage(msg) {