From 5da1bdbeaad8a2f616fde05881d044b7ca864f12 Mon Sep 17 00:00:00 2001 From: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Date: Wed, 28 Oct 2026 12:47:25 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix:=20treat=20stale=20abbreviat?= =?UTF-8?q?ed=20verdict=20head=20warning=20as=20benign?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --- changelog.d/fixed-review-watcher-abbreviated-head.md | 1 + src/pkg/fleetreport/fleetreport.go | 5 +++++ src/pkg/fleetreport/runtime_test.go | 1 + 3 files changed, 7 insertions(+) create mode 100644 changelog.d/fixed-review-watcher-abbreviated-head.md diff --git a/changelog.d/fixed-review-watcher-abbreviated-head.md b/changelog.d/fixed-review-watcher-abbreviated-head.md new file mode 100644 index 0000000000..60610529de --- /dev/null +++ b/changelog.d/fixed-review-watcher-abbreviated-head.md @@ -0,0 +1 @@ +- The self-report classifier no longer files `unclassified_error_repeated` issues for the review-request watcher warning that an abbreviated verdict head is not the PR's current head and was recorded as written (#14997). diff --git a/src/pkg/fleetreport/fleetreport.go b/src/pkg/fleetreport/fleetreport.go index f039e1dbe6..8dd2fe62ae 100644 --- a/src/pkg/fleetreport/fleetreport.go +++ b/src/pkg/fleetreport/fleetreport.go @@ -723,6 +723,11 @@ var benignSubstrings = []string{ // Request watchers log a policy denial (e.g. repo not allowlisted) as an // expected outcome, not a runtime error. "request watcher: denied (policy)", + // A reviewer's abbreviated verdict head that prefixes neither the dispatch + // head nor the PR's current head names an older revision; the relay keeps + // it as written on purpose (pkg/github/review_verdict_relay.go), so it is + // an expected outcome of a push landing mid-review, not a runtime defect. + "abbreviated verdict head is not the pr's current head; recorded as written", // ReconcileSeededDefaults (pkg/policies/seed_reconcile.go) warns once per // policy template whose on-disk copy diverges from the embedded default // with no seed-manifest record, already deduped per path per process diff --git a/src/pkg/fleetreport/runtime_test.go b/src/pkg/fleetreport/runtime_test.go index 07fad20f98..c8ec623fa2 100644 --- a/src/pkg/fleetreport/runtime_test.go +++ b/src/pkg/fleetreport/runtime_test.go @@ -994,6 +994,7 @@ func TestRecurringRuntimeMessagesAreClassified(t *testing.T) { "issue-request watcher: DENIED (policy)", "merge-request watcher: DENIED (policy)", "pr-request watcher: DENIED (policy)", + "review-request watcher: abbreviated verdict head is not the PR's current head; recorded as written", "push-branch-request watcher: DENIED (policy)", } { if !IsBenignMessage(m) {