From a9d6648967d58f358afc09cf0ebd2a75800e8160 Mon Sep 17 00:00:00 2001 From: Tiisetso Mosala <65363519+trmosala@users.noreply.github.com> Date: Wed, 18 Nov 2026 09:28:32 +0200 Subject: [PATCH] fix(decoder): order the copy's layout transitions with its semaphores The reorder copy runs on the transfer queue and is ordered against the decode queue with timeline semaphores whose stage mask is COPY. Its barriers used NONE as the source stage of the transitions into the transfer layouts and as the destination stage of the transition back, so the transitions were outside the scope those semaphores cover. The validation layer reports that as a WRITE_AFTER_WRITE hazard against vkCmdDecodeVideoKHR. Use COPY for those stages, so each transition is chained to the wait before it and the signal after it. Co-Authored-By: Claude Fable 5.2 --- src/decoder/transfer.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/decoder/transfer.rs b/src/decoder/transfer.rs index d3a43b4..b146c31 100644 --- a/src/decoder/transfer.rs +++ b/src/decoder/transfer.rs @@ -72,7 +72,7 @@ impl DecoderCommon { let to_transfer = [ vk::ImageMemoryBarrier2 { - src_stage_mask: vk::PipelineStageFlags2::NONE, + src_stage_mask: vk::PipelineStageFlags2::COPY, src_access_mask: vk::AccessFlags2::NONE, dst_stage_mask: vk::PipelineStageFlags2::COPY, dst_access_mask: vk::AccessFlags2::TRANSFER_READ, @@ -81,7 +81,7 @@ impl DecoderCommon { ..range(frame.image, base_layer) }, vk::ImageMemoryBarrier2 { - src_stage_mask: vk::PipelineStageFlags2::NONE, + src_stage_mask: vk::PipelineStageFlags2::COPY, src_access_mask: vk::AccessFlags2::NONE, dst_stage_mask: vk::PipelineStageFlags2::COPY, dst_access_mask: vk::AccessFlags2::TRANSFER_WRITE, @@ -142,7 +142,7 @@ impl DecoderCommon { let restore = [vk::ImageMemoryBarrier2 { src_stage_mask: vk::PipelineStageFlags2::COPY, src_access_mask: vk::AccessFlags2::TRANSFER_READ, - dst_stage_mask: vk::PipelineStageFlags2::NONE, + dst_stage_mask: vk::PipelineStageFlags2::COPY, dst_access_mask: vk::AccessFlags2::NONE, old_layout: vk::ImageLayout::TRANSFER_SRC_OPTIMAL, new_layout: frame.layout,