fix(agent): validate HUB_URL host to prevent misleading "lookup api" DNS error#2011
Open
svenvg93 wants to merge 2 commits into
Open
fix(agent): validate HUB_URL host to prevent misleading "lookup api" DNS error#2011svenvg93 wants to merge 2 commits into
svenvg93 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
When
HUB_URLis set to an empty string (e.g. via a systemd drop-in that doesn't take effect),url.Parse("")succeeds silently and the agent constructs the WebSocket addressws://api/beszel/agent-connect, causing a confusingdial tcp: lookup apiDNS error with no indication of what went wrong.Fixes #1958
🪵 Changelog
🔧 Fixed
HUB_URLcontains a host after parsing and fails immediately with a clear error message instead of attempting to connect toapias a hostname