fix(agent): show all IP:port mappings for containers bound to multiple IPs#1993
Open
svenvg93 wants to merge 2 commits into
Open
fix(agent): show all IP:port mappings for containers bound to multiple IPs#1993svenvg93 wants to merge 2 commits into
svenvg93 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
Fix incorrect port display for Docker containers bound to multiple IP addresses. The agent was deduplicating ports by port number alone, so only the first IP:port binding was shown when the same port was exposed on more than one IP.
Fixes #1991
🪵 Changelog
✏️ Changed
convertContainerPortsToStringnow deduplicates byIP:portpair instead of port number alone🔧 Fixed
172.16.151.72:65533->80/tcp, 172.16.156.25:65533->80/tcp) now show all IP:port mappings instead of only the first one