Skip to content

Add rolling option#19

Open
sobrinho wants to merge 1 commit into
heartcombo:mainfrom
sobrinho:rolling-encryptor
Open

Add rolling option#19
sobrinho wants to merge 1 commit into
heartcombo:mainfrom
sobrinho:rolling-encryptor

Conversation

@sobrinho

Copy link
Copy Markdown
Contributor

Legacy applications want to migrate from SHA1 to SHA512, for example.

Inspired in what Authlogic has with transition_from_crypto_providers.

@sobrinho

Copy link
Copy Markdown
Contributor Author

It probably makes sense to have a BCrypt cryptor now to be able to migrate from sha1 or any encryptor from this gem to the "new encryptor" that Devises uses these days.

If we agree in this PR, I can do another one to be able to support that rolling or even include in this one.

@sobrinho

Copy link
Copy Markdown
Contributor Author

Merging #20 we can rebase this to merge cleanly.

@sobrinho sobrinho force-pushed the rolling-encryptor branch from 5f7ca3f to ceb9c5a Compare April 30, 2020 23:28
@pboling

pboling commented Jan 24, 2022

Copy link
Copy Markdown

@sobrinho This is awesome. Any chance of this making it into a release? Would love to be able to roll from bcrypt to argon2id

ref: https://www.monterail.com/blog/more-secure-passwords-bcrypt

@sobrinho sobrinho force-pushed the rolling-encryptor branch 2 times, most recently from ad3c062 to 81fbeb3 Compare January 24, 2022 19:09
@sobrinho

Copy link
Copy Markdown
Contributor Author

PR updated.

@pboling

pboling commented Jan 25, 2022

Copy link
Copy Markdown

@carlosantoniodasilva thoughts?

@vaot

vaot commented Jan 19, 2023

Copy link
Copy Markdown

@sobrinho This is great. Is there any interest in merging this one ? We would love to have this option to move from bcrypt.

@sobrinho

Copy link
Copy Markdown
Contributor Author

PR rebased!

The build is broken for another reason on 3.0 rails main and 2.7 rails main.

@carlosantoniodasilva feel free to merge this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants