From 0c6712765f7b45e0c5ffdcf2db7bbb7a46758fbf Mon Sep 17 00:00:00 2001 From: Houssem Eddine BENABDALLAH Date: Sat, 7 Nov 2026 15:27:01 +0100 Subject: [PATCH 1/2] Edge: fail when the tag stays on an old commit; changelog for 1.6.1 --- .github/workflows/edge.yml | 17 +++++++++++++++-- CHANGELOG.md | 7 +++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/.github/workflows/edge.yml b/.github/workflows/edge.yml index 8832e31..cacbcba 100644 --- a/.github/workflows/edge.yml +++ b/.github/workflows/edge.yml @@ -46,8 +46,21 @@ jobs: fi if gh release create edge dist/* --prerelease --target "$GITHUB_SHA" --title "dev-main" \ --notes "Built from main at $GITHUB_SHA. Not a release: install a version for production use."; then - exit 0 + published=1 + break fi sleep 20 done - exit 1 + test -n "${published:-}" + # gh reuses an existing tag and ignores --target: when the old tag could not be deleted (a tag ruleset refuses it, + # "Cannot delete this tag" above), the release is published on the old commit and nothing else fails. + - name: Check that the edge tag moved to this commit + env: + GH_TOKEN: ${{ github.token }} + GH_REPO: ${{ github.repository }} + run: | + tagged=$(gh api "repos/$GH_REPO/commits/edge" --jq .sha) + if [ "$tagged" != "$GITHUB_SHA" ]; then + echo "::error::The edge tag points to $tagged, not $GITHUB_SHA: exclude refs/tags/edge from the repository's tag ruleset." + exit 1 + fi diff --git a/CHANGELOG.md b/CHANGELOG.md index b04734e..f528609 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,13 @@ phpgraph follows [semantic versioning](https://semver.org) from 1.0.0; what stay the files a build reuses. Docker image, 12-thread laptop: Sylius 28 → 10 s, Akeneo 26 → 17 s; with the cache of the previous build, Sylius 14 → 8 s. Peak memory +12 to +20 % with workers, −4 to −28 % without. +## 1.6.1 (2026-10-30) + +### Fixed +- A configuration helper called with the string `"param"`, the name of one of its parameters, took the string for the + parameter's value, so that call was never evaluated. The rest of 1.6.1 is internal (the AGENTS.md rules applied to + `src/`): every graph of the corpus is identical to 1.6.0's. + ## 1.6.0 (2026-10-30) ### Added From dddebdb6dc2fdc450e2a700de5e409212708508f Mon Sep 17 00:00:00 2001 From: Houssem Eddine BENABDALLAH Date: Sat, 7 Nov 2026 15:32:06 +0100 Subject: [PATCH 2/2] Edge: retry reading the tag; changelog: any "param" literal, not a parameter's name --- .github/workflows/edge.yml | 9 ++++++--- CHANGELOG.md | 6 +++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/edge.yml b/.github/workflows/edge.yml index cacbcba..a56ac28 100644 --- a/.github/workflows/edge.yml +++ b/.github/workflows/edge.yml @@ -59,8 +59,11 @@ jobs: GH_TOKEN: ${{ github.token }} GH_REPO: ${{ github.repository }} run: | - tagged=$(gh api "repos/$GH_REPO/commits/edge" --jq .sha) - if [ "$tagged" != "$GITHUB_SHA" ]; then - echo "::error::The edge tag points to $tagged, not $GITHUB_SHA: exclude refs/tags/edge from the repository's tag ruleset." + for _ in 1 2 3; do + tagged=$(gh api "repos/$GH_REPO/commits/edge" --jq .sha) && break + sleep 20 + done + if [ "${tagged:-}" != "$GITHUB_SHA" ]; then + echo "::error::The edge tag points to ${tagged:-an unreadable commit}, not $GITHUB_SHA: exclude refs/tags/edge from the repository's tag ruleset." exit 1 fi diff --git a/CHANGELOG.md b/CHANGELOG.md index f528609..7d1e6af 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,9 +20,9 @@ phpgraph follows [semantic versioning](https://semver.org) from 1.0.0; what stay ## 1.6.1 (2026-10-30) ### Fixed -- A configuration helper called with the string `"param"`, the name of one of its parameters, took the string for the - parameter's value, so that call was never evaluated. The rest of 1.6.1 is internal (the AGENTS.md rules applied to - `src/`): every graph of the corpus is identical to 1.6.0's. +- A call to a configuration helper with the string `"param"` among its arguments was taken for a call depending on + its caller's parameters, so it was never evaluated and the services it declares were missing. The rest of 1.6.1 is + internal (the AGENTS.md rules applied to `src/`): every graph of the corpus is identical to 1.6.0's. ## 1.6.0 (2026-10-30)