Skip to content

Missing CloseMessage event #9

Description

@pgjones

I think this should send a CloseMessage frame before closing the connection, rather than just sending an EOF as at the moment. I think s.ws.WriteMessage(websocket.CloseMessage, []byte{}) in the error handling part of readConsole would do this, but my go isn't good enough for me to be sure.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions