From 14cde74ac500d8593f2d65bac88a902e3d012360 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dar=C3=ADo=20Kondratiuk?= Date: Thu, 5 Nov 2026 12:19:21 -0300 Subject: [PATCH 1/2] Run the screenshot tests that waited on #1109 and #1095 Co-Authored-By: Claude Sonnet 5.5 Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK --- .../E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs | 1 - tests/E2E.NUnit.Tests/Screenshot/PageScreenshotTests.cs | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs b/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs index af49a62a2..05eca7d11 100644 --- a/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs +++ b/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs @@ -14,7 +14,6 @@ namespace E2E.NUnit.Tests.Screenshot; /// elementhandle (element handles), and should hide and remove elements based on attr (no style option). /// All nine tests are ignored: ToHaveScreenshotAsync cannot resolve the CSS-selector and frame locators of Browser as masks (#1109). /// -[Ignore("ToHaveScreenshotAsync cannot mask a CSS-selector or frame locator of Browser: #1109")] public sealed class PageScreenshotMaskOptionTests : ScreenshotTest { [Test] diff --git a/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotTests.cs b/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotTests.cs index ce0ed0b4b..e0874328e 100644 --- a/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotTests.cs +++ b/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotTests.cs @@ -173,7 +173,6 @@ public async Task Should_work_for_translateZ() } [Test] - [Ignore("App.ScreenshotAsync fails when the page navigates during the capture: #1095")] public async Task Should_work_while_navigating() { await Browser.SetViewportAsync(500, 500); From 871a9aac031df0ee8ccb3f057558b9b779f1e9cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dar=C3=ADo=20Kondratiuk?= Date: Thu, 5 Nov 2026 12:23:33 -0300 Subject: [PATCH 2/2] Drop the stale ignored-tests sentence of the mask option class Co-Authored-By: Claude Sonnet 5.5 Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK --- .../E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs b/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs index 05eca7d11..67c95e030 100644 --- a/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs +++ b/tests/E2E.NUnit.Tests/Screenshot/PageScreenshotMaskOptionTests.cs @@ -12,7 +12,6 @@ namespace E2E.NUnit.Tests.Screenshot; /// (Playwright's page-screenshot.spec.ts). A mask is the ToHaveScreenshotAsync option, compared against the same /// viewport with boxes of the mask color painted over the masked elements. Not ported, as upstream: mask option should work with /// elementhandle (element handles), and should hide and remove elements based on attr (no style option). -/// All nine tests are ignored: ToHaveScreenshotAsync cannot resolve the CSS-selector and frame locators of Browser as masks (#1109). /// public sealed class PageScreenshotMaskOptionTests : ScreenshotTest {