From ec05f47f229c50aa93d41cd8c4d72d1076d05eb5 Mon Sep 17 00:00:00 2001 From: James <279246542+jamessburnss1313-dev@users.noreply.github.com> Date: Fri, 20 Nov 2026 12:30:33 +0000 Subject: [PATCH] fix(chat): Effort and Mode lists open where they can be seen Tooltip and Popover share the empty scope, and a Tooltip provides its own Popper and Popover context. With the Tooltip between Popover and PopoverTrigger, the trigger anchored the Tooltip and the Popover content was never placed: it stayed at the top-left at opacity 0. Nest the Popover inside the TooltipTrigger, as the Model picker does. test:composer opens Effort (and Mode on Dev) at every width and requires a list that is seen on screen, beside its word on desktop, and gone after Escape. --- pkg/ui/scripts/composer.mjs | 30 +++++++++++++++++ pkg/ui/src/chat/Tune.tsx | 66 +++++++++++++++++++------------------ 2 files changed, 64 insertions(+), 32 deletions(-) diff --git a/pkg/ui/scripts/composer.mjs b/pkg/ui/scripts/composer.mjs index 30269c301..b84dee017 100644 --- a/pkg/ui/scripts/composer.mjs +++ b/pkg/ui/scripts/composer.mjs @@ -284,6 +284,36 @@ for (const [width, height, ratio] of [ await tab.screenshot({ path: join(OUT, `${name}.png`) }) await tab.locator('[data-slot="composer-shell"]').screenshot({ path: join(OUT, `${name}-rest.png`) }) + // Effort and Mode open their list where it can be seen: drawn, on screen, beside the word that opened it. + for (const slotName of kind === 'dev' ? ['effort', 'mode'] : ['effort']) { + const trigger = tab.locator(`[data-slot="composer-foot"] [data-slot="${slotName}"]`) + check((await trigger.count()) === 1, `${name}: ${slotName} is drawn under the frame`) + if (!(await trigger.count())) continue + await trigger.click() + await tab.locator('[data-slot="choices"]').last().waitFor({ state: 'visible', timeout: 5_000 }).catch(() => {}) + const panel = await tab.evaluate((s) => { + const list = [...document.querySelectorAll('[data-slot="choices"]')].at(-1) + if (!list) return null + const b = list.getBoundingClientRect() + const t = document.querySelector(`[data-slot="composer-foot"] [data-slot="${s}"]`).getBoundingClientRect() + let seen = true + for (let n = list; n; n = n.parentElement) { + const st = getComputedStyle(n) + if (st.opacity === '0' || st.visibility === 'hidden' || st.display === 'none') seen = false + } + return { seen, x: b.x, y: b.y, r: b.right, bottom: b.bottom, w: b.width, vw: innerWidth, vh: innerHeight, gap: Math.min(Math.abs(t.top - b.bottom), Math.abs(b.top - t.bottom)) } + }, slotName) + check( + panel && panel.seen && panel.w > 0 && panel.x >= 0 && panel.y >= 0 && panel.r <= panel.vw + 1 && panel.bottom <= panel.vh + 1, + `${name}: ${slotName} opens a list that is seen on screen (${JSON.stringify(panel)})`, + ) + if (!phone) check(panel && panel.gap <= 24, `${name}: ${slotName}'s list opens beside its word (${panel?.gap})`) + await tab.keyboard.press('Escape') + const shut = await tab.locator('[data-slot="choices"]').last().waitFor({ state: 'hidden', timeout: 5_000 }).then(() => true, () => false) + check(shut, `${name}: Escape puts ${slotName}'s list away`) + await settle(tab) + } + // Focused, with three lines: the edge brightens, send has the last place, the field three lines tall. const field = tab.locator('[data-slot="composer-field"]') await field.focus() diff --git a/pkg/ui/src/chat/Tune.tsx b/pkg/ui/src/chat/Tune.tsx index 6ad32180b..efe4562ef 100644 --- a/pkg/ui/src/chat/Tune.tsx +++ b/pkg/ui/src/chat/Tune.tsx @@ -305,11 +305,13 @@ function Opens({ ) } + // The Popover sits inside the TooltipTrigger, as the Model picker's does. A Tooltip between a Popover and its + // trigger takes the trigger as its own anchor, and the panel then opens unplaced and unseen. return ( - (o ? !disabled && setOpen(true) : close(false))} allowFlip stayInFrame placement="top-end"> - - - + + + + (o ? !disabled && setOpen(true) : close(false))} allowFlip stayInFrame placement="top-end"> - - - - - {hint} - - - - { - e.preventDefault() - triggerRef.current?.focus?.() - }} - > - {children(() => close(true), false)} - - + { + e.preventDefault() + triggerRef.current?.focus?.() + }} + > + {children(() => close(true), false)} + + + + + + + {hint} + + + ) }