From 4b4145bd90a86a90aa54ccd0e5f69d3f51f751d9 Mon Sep 17 00:00:00 2001 From: MiMoHo Date: Thu, 30 Jul 2026 04:37:28 +0200 Subject: [PATCH] Stop claiming shift-command-S for the search window by default The search hotkey defaulted to shift-command-S, which is Save As... in Word and the colour picker in iWork. A clipboard manager taking a shortcut that common away from the frontmost app, on a fresh install, without asking, is the wrong default - the user's report was that Save As... had stopped working. So register no default for it. The recorder then stays empty, -toggleSearchHotKey: registers nothing because it already guards on ShortcutRecorderEmptyCode, and the shortcut reaches the frontmost app as before. Anyone who wants the search window assigns a shortcut under "Search clipboard hotkey" in Preferences, and anyone who has already assigned one keeps it, because that value lives in the user domain rather than in the registered defaults. The documentation was out of sync with the code as well: help.md and readme.md both promised shift-command-B, while the registered default was keyCode 1, which is S. Both now say the shortcut is unset and where to set one. Verified with a test program against the bundled ShortcutRecorder that a control which was never assigned a combo reports ShortcutRecorderEmptyCode (-1), so the existing guard is what makes "no default" mean "no hotkey", and that assigning one lifts the guard. Builds with Xcode 26.5, 76 warnings, identical to master. Co-Authored-By: Claude --- AppController.m | 9 +++++++-- help.md | 2 +- readme.md | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/AppController.m b/AppController.m index 3898ab0..1bedea2 100755 --- a/AppController.m +++ b/AppController.m @@ -61,8 +61,13 @@ - (id)init [[NSUserDefaults standardUserDefaults] registerDefaults:[NSDictionary dictionaryWithObjectsAndKeys: [NSDictionary dictionaryWithObjects:[NSArray arrayWithObjects:[NSNumber numberWithInt:9],[NSNumber numberWithLong:1179648],nil] forKeys:[NSArray arrayWithObjects:@"keyCode",@"modifierFlags",nil]], @"ShortcutRecorder mainHotkey", - [NSDictionary dictionaryWithObjects:[NSArray arrayWithObjects:[NSNumber numberWithInt:1],[NSNumber numberWithLong:1179648|NSEventModifierFlagShift],nil] forKeys:[NSArray arrayWithObjects:@"keyCode",@"modifierFlags",nil]], - @"ShortcutRecorder searchHotkey", + // No default for "ShortcutRecorder searchHotkey" on purpose. It used to default to + // shift-command-S, which is Save As... in Word and the colour picker in iWork, and a + // clipboard manager has no business claiming a shortcut that common system-wide. With + // no default the recorder stays empty, -toggleSearchHotKey: registers nothing (it + // already guards on ShortcutRecorderEmptyCode), and the shortcut reaches the frontmost + // app as before. Users who want the search window assign a shortcut in Preferences. + // Anyone who has already set one keeps it - that value lives in the user domain. [NSNumber numberWithInt:10], @"displayNum", [NSNumber numberWithInt:40], diff --git a/help.md b/help.md index d985e05..d466195 100644 --- a/help.md +++ b/help.md @@ -66,7 +66,7 @@ Here's a complete list of keys you can use in the Bezel. **Search Window** -Press the Search Hotkey (Shift-Command-B, by default) to open the search window. Type to filter your clipboard history. Use the arrow keys to navigate results and press Return to paste the selected item. +The search window has **no shortcut out of the box** — assign one under "Search clipboard hotkey" in Preferences first. It is left unset deliberately, so that Flycut does not take a shortcut away from the app you are working in. Once assigned, press it to open the search window, type to filter your clipboard history, use the arrow keys to navigate results and press Return to paste the selected item. **Menu Features** diff --git a/readme.md b/readme.md index 0f4a484..cc3dd5c 100644 --- a/readme.md +++ b/readme.md @@ -26,7 +26,7 @@ Every time you copy a code piece, Flycut stores it in history. Later, you can pa | Shortcut | Action | |----------|--------| | Shift+Command+V | Open clipboard history (bezel) | -| Shift+Command+B | Open search window | +| _(unset by default)_ | Open search window — assign one in Preferences | ### Bezel Navigation