Feature: Implement Feedback Loop for Missed Redactions

[matthewgoluba]

To support a community-driven improvement cycle, users need a way to report when the tool misses sensitive data.

Architecture:

• Bun HTTP server endpoint (part of packages/api/)
• PostgreSQL database for persistent storage (local dev + production)
• No external services - all self-hosted

Requirements:

• Endpoint: POST /api/feedback
• Payload: { original: string, missed: string, type?: string, regex?: string, sampleData?: string, patternName?: string, category?: string }
• Storage: PostgreSQL database
• Admin: GET /api/feedback to list all submissions

Tasks:

• Add PostgreSQL connection to API server
• Create feedback table schema
• Create POST /api/feedback route handler
• Create GET /api/feedback route handler (admin view)
• Add database migration script
• Document environment variables for DB connection

[goobz22]

Implementation Notes Based on Codebase Review

Current State

• No database or persistence layer exists
• No API routes exist yet (see Issue Feature: Implement REST API for Redaction Service #3)
• UI is entirely client-side

Suggested Implementation

1. Create packages/ui/app/api/feedback/route.ts:

import { NextRequest, NextResponse } from 'next/server';
import { promises as fs } from 'fs';
import path from 'path';

const FEEDBACK_FILE = path.join(process.cwd(), 'data', 'feedback.json');

interface FeedbackEntry {
  id: string;
  timestamp: string;
  original: string;
  missed: string;
  suggestedType: string;
  status: 'pending' | 'reviewed' | 'implemented';
}

export async function POST(request: NextRequest) {
  try {
    const { original, missed, type } = await request.json();
    
    if (!original || !missed) {
      return NextResponse.json(
        { error: 'Missing required fields: original, missed' },
        { status: 400 }
      );
    }
    
    // Ensure data directory exists
    await fs.mkdir(path.dirname(FEEDBACK_FILE), { recursive: true });
    
    // Load existing feedback
    let feedback: FeedbackEntry[] = [];
    try {
      const data = await fs.readFile(FEEDBACK_FILE, 'utf-8');
      feedback = JSON.parse(data);
    } catch {
      // File doesn't exist yet
    }
    
    // Add new entry
    const entry: FeedbackEntry = {
      id: crypto.randomUUID(),
      timestamp: new Date().toISOString(),
      original,
      missed,
      suggestedType: type || 'unknown',
      status: 'pending'
    };
    feedback.push(entry);
    
    await fs.writeFile(FEEDBACK_FILE, JSON.stringify(feedback, null, 2));
    
    return NextResponse.json({ success: true, id: entry.id });
  } catch (error) {
    return NextResponse.json(
      { error: 'Failed to save feedback' },
      { status: 500 }
    );
  }
}

export async function GET() {
  try {
    const data = await fs.readFile(FEEDBACK_FILE, 'utf-8');
    return NextResponse.json(JSON.parse(data));
  } catch {
    return NextResponse.json([]);
  }
}

2. Extended payload for Issue #8 (Regex Builder):

interface FeedbackEntry {
  // ... existing fields
  regex?: string;           // User-submitted regex pattern
  sampleData?: string;      // Original data used to create regex
  patternName?: string;     // User-suggested name
  category?: 'pii' | 'system' | 'financial' | 'custom';
}

3. Add to .gitignore:

data/feedback.json

Future Considerations

• For production: migrate to SQLite or PostgreSQL
• Add authentication for admin view
• Add duplicate detection (similar missed values)
• Webhook integration to notify maintainers of new feedback

[goobz22]

Implementation Complete

Created PostgreSQL feedback storage system:

Database Schema (packages/api/db/schema.sql)

CREATE TABLE feedback (
  id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
  created_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),
  original TEXT NOT NULL,
  missed TEXT NOT NULL,
  suggested_type VARCHAR(100),
  regex TEXT,
  sample_data TEXT,
  pattern_name VARCHAR(200),
  category VARCHAR(50)
);

API Endpoints

• POST /api/feedback - Submit missed redaction feedback
• GET /api/feedback - List feedback with pagination
• GET /api/feedback?category=pii - Filter by category
• DELETE /api/feedback?id=xxx - Remove feedback entry

Files Created

• packages/api/db/client.ts - PostgreSQL client using Bun's SQL
• packages/api/db/schema.sql - Migration script
• packages/api/routes/feedback.ts - Route handlers

Ready to close.

[goobz22]

Correction: Environment variable documentation still needed. See updated task list above.