diag(logic): Probe the skirmish side and team records

The AI's default team is copied out of the skirmish team records in
Player::initFromDict, and ParseTeamsDataChunk silently drops any team whose
owner is not already a skirmish side. Log every team the .scb offers with the
owner it names and whether that owner matched, report when SkirmishScripts.scb
fails to open at all (which would leave the records empty, since they are
cleared just before the parse), and dump what survived prepareForMP_or_Skirmish.

Also of note: every file in this failure path is identical to the vibecode
port, which does not show the bug - VictoryConditions.cpp, PlayerList.cpp,
Dict.cpp and Scripts.cpp match exactly, DataChunk.cpp reads the same widths,
and SidesList.cpp differs only by a branch that is unreachable for this map.
So this is not a fix that was lost in the re-port.

Author: githubawn

GeneralsMD/Code/GameEngine/Source/GameLogic/Map/SidesList.cpp

@@ -45,6 +45,11 @@
 
 #include "PreRTS.h"	// This must go first in EVERY cpp file in the GameEngine
 
+#ifndef _WIN32
+// TheSuperHackers @info TEMPORARY DIAGNOSTIC - see the skirmish probes below.
+#include <cstdio>
+#endif
+
 #include "Common/DataChunk.h"
 #include "Common/GameState.h"
 #include "Common/PlayerTemplate.h"
@@ -464,6 +469,12 @@ static Bool ParseTeamsDataChunk(DataChunkInput &file, DataChunkInfo *info, void
 		Dict teamDict = file.readDict();
 		AsciiString teamName = teamDict.getAsciiString(TheKey_teamName);
 		AsciiString player = teamDict.getAsciiString(TheKey_teamOwner);
+#ifndef _WIN32
+		// TheSuperHackers @info TEMPORARY DIAGNOSTIC - teams whose owner is not already a
+		// skirmish side are dropped silently here, which would leave the AI without a default team.
+		std::fprintf(stderr, "[GGC_SK] scbTeam name='%s' owner='%s' matched=%d\n",
+			teamName.str(), player.str(), sides->findSkirmishSideInfo(player) ? 1 : 0);
+#endif
 		if (sides->findSkirmishSideInfo(player)) {
 			// player exists, so just add it.
 			sides->addSkirmishTeam(&teamDict);
@@ -568,9 +579,36 @@ void SidesList::prepareForMP_or_Skirmish()
 					static_readPlayerNames[i].clear();
 				}
 		}
+#ifndef _WIN32
+		else
+		{
+			// TheSuperHackers @info TEMPORARY DIAGNOSTIC - if this file does not open the
+			// skirmish team records stay empty, because they were cleared just above.
+			std::fprintf(stderr, "[GGC_SK] FAILED to open '%s'\n", path.str());
+		}
+#endif
 
 
 	}
+
+#ifndef _WIN32
+	// TheSuperHackers @info TEMPORARY DIAGNOSTIC - the skirmish AI's default team is copied out
+	// of these records in Player::initFromDict, so show exactly what survived this function.
+	std::fprintf(stderr, "[GGC_SK] prepare done: sides=%d skirmishSides=%d skirmishTeams=%d\n",
+		m_numSides, m_numSkirmishSides, getNumSkirmishTeams());
+	for (Int probeS = 0; probeS < m_numSkirmishSides; ++probeS)
+	{
+		std::fprintf(stderr, "[GGC_SK]   skirmishSide[%d] name='%s' faction='%s'\n", probeS,
+			getSkirmishSideInfo(probeS)->getDict()->getAsciiString(TheKey_playerName).str(),
+			getSkirmishSideInfo(probeS)->getDict()->getAsciiString(TheKey_playerFaction).str());
+	}
+	for (Int probeT = 0; probeT < getNumSkirmishTeams(); ++probeT)
+	{
+		std::fprintf(stderr, "[GGC_SK]   skirmishTeam[%d] name='%s' owner='%s'\n", probeT,
+			getSkirmishTeamInfo(probeT)->getDict()->getAsciiString(TheKey_teamName).str(),
+			getSkirmishTeamInfo(probeT)->getDict()->getAsciiString(TheKey_teamOwner).str());
+	}
+#endif
 }