Skip to content

Commit 8fe79fc

Browse files
committed
Fix Linux artifact acceptance under pipefail
1 parent df55281 commit 8fe79fc

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/release-acceptance.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ jobs:
8383
tar -xOf "dist/accept/1Helm-$version-linux-node.tgz" "$root/resources/source-build.json" > dist/accept/source-build.json
8484
test "$(jq -r .version dist/accept/source-build.json)" = "$version"
8585
test "$(jq -r .commit dist/accept/source-build.json)" = "$commit"
86-
tar -tzf "dist/accept/1Helm-$version-linux-node.tgz" | grep -qx "$root/src/server/index.ts"
87-
tar -tzf "dist/accept/1Helm-$version-linux-node.tgz" | grep -qx "$root/node_modules/node-pty/build/Release/pty.node"
86+
grep -Fqx "$root/src/server/index.ts" dist/accept/archive-files.txt
87+
grep -Fqx "$root/node_modules/node-pty/build/Release/pty.node" dist/accept/archive-files.txt
8888
printf 'Accepted exact Linux package for %s %s\n' "$version" "$commit" > dist/accept/linux-acceptance.txt
8989
node scripts/release-stage-evidence.mjs create linux-acceptance "$version" "$commit" \
9090
dist/accept/linux-acceptance-evidence.json dist/accept/linux-acceptance.txt "dist/accept/1Helm-$version-linux-node.tgz"

test/release-workflows.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ test("release pipeline has durable retry boundaries instead of one monolithic ru
1717
assert.match(read("release-mac-build.yml"), /ci_run_id/);
1818
assert.match(read("release-acceptance.yml"), /run-id:.*build_run_id/);
1919
assert.doesNotMatch(read("release-acceptance.yml"), /package:dmg:release|package:linux/, "acceptance must not rebuild artifacts");
20+
assert.doesNotMatch(read("release-acceptance.yml"), /tar -tzf.*\| grep -q/, "archive checks must not trigger tar SIGPIPE under pipefail");
2021
assert.doesNotMatch(read("release-publish.yml"), /npm ci|package:|notarytool/, "publication must consume, not rebuild");
2122
assert.doesNotMatch(read("release-public-verify.yml"), /npm ci|package:|notarytool/, "public verification must consume, not rebuild");
2223
});

0 commit comments

Comments
 (0)