Deprecate the `PROFILE_INDEXED` data category

[Dav1dde]

The profile indexed data category was previously used for dynamic sampling. A profile which had some metrics extracted but would be dropped due to dynamic sampling would have counted as Accepted in the PROFILE category but filtered in the PROFILE_INDEXED category. This was changed already a long time ago. Profiles are now independent of dynamic sampling.

CoS:

• Deprecate the PROFILE_INDEXED data category
• Eliminate all uses of that data category within Relay
• Simplify code, e.g. rate limiting logic
• Update integration tests

Follow Up:

• Release sentry-relay
• Purge all uses of the PROFILE_INDEXED category in Sentry and getsentry.

Known Bugs:

• Rate limiting of profiles in the processor is incorrectly implemented, a profile which is dropped due to a profile indexed rate limit, emits an outcome in the profile category (it shouldn't)

[linear]

RELAY-203

[Dav1dde]

Small update, the profile indexed category is still in use, so we should keep it around and also emit the outcomes to both categories. But we should still re-thinking the approach of that category in Relay, it is inconsistently implemented between different rate limiters and for Relay these two categories should be identical (the sampling happens in a Python consumer, not Relay).

Potential option: No longer implement rate limits in the indexed category as it would be equivalent to the profile category and call it a day.