From f93cd2584beb56be12c246584712afc025b73741 Mon Sep 17 00:00:00 2001 From: Etienne Lescot Date: Sat, 1 Aug 2026 13:27:13 +0200 Subject: [PATCH] feat(build): add the Fedora RPM target electron-builder's rpm target shells out to rpmbuild, which the Linux runner doesn't have: the setup step installs libarchive-tools only, for pacman's bsdtar. Without it the build fails at the packaging step rather than at config parse, so the omission is easy to miss until CI runs. The release job needs nothing further -- it uploads whatever `find artifacts -type f` returns, so only the upload-artifact glob had to learn the new extension. Co-authored-by: Mundo-Dev0ps --- .github/workflows/build.yml | 8 ++++++-- electron-builder.json5 | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 76ac9ef39..74b548892 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -317,8 +317,11 @@ jobs: - name: Setup Node.js uses: ./.github/actions/setup - - name: Install pacman build dependencies - run: sudo apt-get update && sudo apt-get install -y libarchive-tools + - name: Install pacman and rpm build dependencies + # libarchive-tools -> bsdtar, for the pacman target. rpm -> rpmbuild, + # which electron-builder shells out to for the rpm target; without it + # the Linux build fails at the packaging step, not at config parse. + run: sudo apt-get update && sudo apt-get install -y libarchive-tools rpm - name: Stage whisper-stt binaries shell: bash @@ -338,6 +341,7 @@ jobs: release/**/*.zsync release/**/*.deb release/**/*.pacman + release/**/*.rpm if-no-files-found: error retention-days: 30 diff --git a/electron-builder.json5 b/electron-builder.json5 index b12185877..23abd1f19 100644 --- a/electron-builder.json5 +++ b/electron-builder.json5 @@ -98,7 +98,8 @@ "target": [ "AppImage", "deb", - "pacman" + "pacman", + "rpm" ], "icon": "icons/icons/png", "artifactName": "${productName}-Linux-${version}.${ext}",