Skip to content

Added support for JSON schemata for the Reflector type; fixes #509#527

Merged
liuzicheng1987 merged 3 commits into
mainfrom
f/reflector_schema
Oct 19, 2025
Merged

Added support for JSON schemata for the Reflector type; fixes #509#527
liuzicheng1987 merged 3 commits into
mainfrom
f/reflector_schema

Conversation

@liuzicheng1987
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @liuzicheng1987, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the JSON schema generation capabilities by introducing full support for types that leverage the Reflector mechanism. By modifying the parser's type recognition and schema generation process, it ensures that custom reflection types defined through Reflector specializations are accurately translated into their corresponding JSON schemata. This change broadens the utility of the schema generation feature, enabling more complex and customized data structures to be precisely represented in JSON schema, and directly addresses issue #509.

Highlights

  • Reflector Type Schema Generation: The system now correctly generates JSON schemata for types that utilize the Reflector mechanism, allowing for more flexible and custom schema definitions based on ReflType specializations.
  • Expanded Parser Conditions: The internal parser logic has been updated to recognize types with read_reflector or write_reflector specializations, ensuring they are properly handled during schema generation.
  • New Test Case for Reflector Schema: A dedicated test file (test_reflector_schema.cpp) has been added to validate the JSON schema generation for Reflector types, confirming the correct output for a Parent struct with a custom Reflector specialization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for generating JSON schemas for types that use rfl::Reflector. The changes in Parser_default.hpp correctly extend schema generation to these types, and a new test file is added to verify this functionality. I have one suggestion to improve the robustness of the implementation in Parser_default.hpp to prevent potential compilation errors for certain Reflector specializations.

Comment thread include/rfl/parsing/Parser_default.hpp
@liuzicheng1987 liuzicheng1987 merged commit dfcbff9 into main Oct 19, 2025
292 checks passed
@liuzicheng1987 liuzicheng1987 deleted the f/reflector_schema branch October 19, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant