From 1db353a5e68866b11fd14c345d72f5919d002229 Mon Sep 17 00:00:00 2001 From: CasualPokePlayer <50538166+CasualPokePlayer@users.noreply.github.com> Date: Wed, 27 May 2026 17:49:12 -0700 Subject: [PATCH 1/2] Hide the SGB border for bgb and no$gmb; add passing results for SGB --- emulators/bgb.ini | 2 +- emulators/nocash.py | 2 ++ testroms/cpp/sgb-ext-test.png | Bin 0 -> 1324 bytes testroms/samesuite/sgb/command_mlt_req.png | Bin 0 -> 1892 bytes .../sgb/command_mlt_req_1_incrementing.png | Bin 0 -> 1500 bytes 5 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 testroms/cpp/sgb-ext-test.png create mode 100644 testroms/samesuite/sgb/command_mlt_req.png create mode 100644 testroms/samesuite/sgb/command_mlt_req_1_incrementing.png diff --git a/emulators/bgb.ini b/emulators/bgb.ini index eb8f68a..892bf2c 100644 --- a/emulators/bgb.ini +++ b/emulators/bgb.ini @@ -71,7 +71,7 @@ BackgroundGBC= SoundBufSize=57 SoundPages=4 SoundPagesAhead=3 -Border=1 +Border=0 Blend=0 Doubler=off StartOpen=0 diff --git a/emulators/nocash.py b/emulators/nocash.py index 494315e..fff8207 100644 --- a/emulators/nocash.py +++ b/emulators/nocash.py @@ -19,4 +19,6 @@ def startProcess(self, rom, *, model, required_features): def getScreenshot(self): screenshot = getScreenshot(self.title_check) + if screenshot.size[0] == 256: # SGB + return screenshot.crop((48, 40, 48 + 160, 40 + 144)) return screenshot.crop((80, 34, 80 + 160, 34 + 144)) diff --git a/testroms/cpp/sgb-ext-test.png b/testroms/cpp/sgb-ext-test.png new file mode 100644 index 0000000000000000000000000000000000000000..e3a66d1d9a63b65440917a4e7ebea9c02eaa56df GIT binary patch literal 1324 zcmeAS@N?(olHy`uVBq!ia0vp^3xIe62OE&=-q!^2X+?^QKos)S9a~60+7BevL9R^{>rK(-+x6N4a- zjsoJ$b{4RB4v-B32|x_e52Mj-Wnf?i`iq@`1*pcr$k>2!0mNL89@YgAv!(&rAixAP zi3zMS$kGDHg6c9fFaXKkTs~{+$?e?nKof6xx;TbZ#J#=o&@aYaz$Nj-@BPJ(#O?2deT$NE#f}{*U6oIJ>R~9(QD7YAI0nin|}QI_3QS1@$j(qH%s^Z=sC}S z{>=Kwf3+Va?ao~PRP#~xS^V4jnD*}{D(jlN&;R+e`Lp|;x%Q85@2{`6t64gqVc*k> z`jsEQ&9;3s^Sr&a{4D$b`|bW`)p0-g({%pNr1N$EBJFDNV>`KJ%F{drd- za;g8>4;w!Q`(N_&KfnI-BD?;${ZEL&{rkWF{Qm6v&)w(R*O#0(Sn+9p%)uYu4Pq(FBA&{A)x%-?yg zf1lY5dvp08{@;P3VFs&w#P9K1q|W$y;^(&cY;&9sRc?9-6y;C=p*alCjut$yxmohQ zVMP+_;!`CL?=}RtMfT6h|DAcjQe}?%>^#=RT?~tW=oDu{91r`s$-bk;js^m)Q-YGd aem$eY)#OLb59L5b6N9I#pUXO@geCwQb1H2B literal 0 HcmV?d00001 diff --git a/testroms/samesuite/sgb/command_mlt_req.png b/testroms/samesuite/sgb/command_mlt_req.png new file mode 100644 index 0000000000000000000000000000000000000000..4f6edebb7d91939f65847681e23ffdbde6b9d36a GIT binary patch literal 1892 zcmdT_X;4#F6nTT(|8}Nl?sw03&OPV5_x!rw z$3&r5EOTB40KkgKh<$OeuZMBL#tPo)?35DNA#&r;djJ;SWeg51(sv)+4FD~4yM64=_gF(mQQ=B}0&b#Y`b*P@EfoDmp ztX4bS$vPl)qv?yFsi`TwTCD~*5y!;(Nb2x&CX)qz3@o`^&cW(h49Z@*L?+@Dg-~m* zv)GS?YoVb!<2ugdrv%+WohyOQ-61;TW|*y;ZHy?*Q&&7#w^bk_OSgiHzY zg`h#R`8AaLiY$q~OX#K80s)aefn%7XkKMyUJus)CJ|vA6PX(GLr|LNrU_OcfP03Y8>e$ZJ$e>96<%(bG&+7>;yJ1cfjN=G!1D|Hp2vj!=Y0 z&frcB_ErttY#?pVC}Mk2C=}7c6R40gKfXbW7`fN6#$~NzbuWet;c%299IjbI=~5M9 zLf?eX*gGjeEAG-z@E{OQ*`e!yX?=dkT`Mg=-SJ)@en7J|PN2X@cTg?0cq3DgcYBo$ zv!7?xW3)q*uKmxK@Kdvf;^;FooYL0xWB%RKa~rgkd=h5z;#QZo- z!4a>OhK)imDTeQpgkkUki=RP(&W|s!PlB$xxq`)5LF)IMbgrq5ULvNZK#0ss7!%xt4(6e7iYrY+@U$ zoUfWkBL%<9?aG7)q}EMT2H_|rlum31mGr&fHBEzf;o(R*m+*svB*^F<Vq@rME}dd|I~9^# zZc$S_VP?qHPIY3A%- zgv1#N{X-=fjLu4da&PJyFrK|n+E{Yyf4jU3sCvhP{_HOrEpxs${S%R4QTteXQoi{M DJbj4Z literal 0 HcmV?d00001 diff --git a/testroms/samesuite/sgb/command_mlt_req_1_incrementing.png b/testroms/samesuite/sgb/command_mlt_req_1_incrementing.png new file mode 100644 index 0000000000000000000000000000000000000000..b0ee6b55ef7d201bdfcb4d91441a83f4c30375b8 GIT binary patch literal 1500 zcmeAS@N?(olHy`uVBq!ia0vp^3xIe62OE&=-q!^2X+?^QKos)S9a~60+7BevL9R^{>rK(-+x6N4a- zjsoJ$b{4RB4v-B32|x_e52Mj-Wnf?i`iq@`1*pcr$k>2!0mNL89@YgAv!(&rAixAP zi3zMS$kGDHg6c9fFaXKkTs~{+$?e?nz`*G6ba4!+hZd!M)c_VcGjKg||R>wBjjE1bN3o!e`-Qqw5& zRjV)V3XJW&*83`JOI}F$;?l*tq}EDbJzV*omkSouwT!KHuq=Ph5O9y`AzKI#AKxAw6NTgBW;kN&%U`~E)G<82ZLE^cGE zXFoA-vece6t&4wa7vt*ay;$POqF0Ku&zB}vY*R#JgtLE<7etZ4#_t#{eeP;P$R8qJ5 z?zUSmiqe0le-?ONQC*!~9oYTPWBc-1bN?^@JmLF_-RGu0zB=n%|Cc$NeM-!iocj67 zcjnsHzp9^iM9KbAI{z!QWzX$+TPyy`I~5_?$5)%qm49iOKJ!JMNBYxcZ`O9k@zhRy z#r<9V`HZux*NH#xuj+GWmfB?Y>gvMd*FTqM_kH?(RqBX%%uAczSDDxRtDi?(9=rF? zz{+jUio4v_x9_tqxwLPd^Y!x2QI~&C{5RA8;K%OIe_#KcRV%)C=AWn5^TV}&hws_H zzuva`%-`jozioXQ@Uiis+^)6a{rO!b_4&T|m-h^A@2~pvqBQK= z`>%_`N}&SE%U$!WIArs_dG>8_&asQreuwwTXYGIW z?Ye2~{!4Lv!8hvoX1z>(bN2D&Rdro+YbCY+?s9wnOKjQ zzgg`{GxIlnkzROeKl8i4O)~OMkKQMxPrhEWfBEg?t-rkMV;7$f|91Y*%lnG`C0z{n z_AA%leIj8P{?+xy>+7YfKUI|G+qTPXp1u6d)mv|V2;P!eX*d7v{I6GM?rZ#Mt+3|b n%>P}7vy~b)3|VBbE9M{jrVa1y*%_);K;@ICtDnm{r-UW|5?g#K literal 0 HcmV?d00001 From 0eab01ca7dc69d02c9892d7175eea62a73728b71 Mon Sep 17 00:00:00 2001 From: CasualPokePlayer <50538166+CasualPokePlayer@users.noreply.github.com> Date: Wed, 27 May 2026 18:06:07 -0700 Subject: [PATCH 2/2] Disable SGB for ares ares does support SGB, but only as LLE, requiring an SNES side ROM and needing additional handling for a screenshot. It shouldn't be ran unless this is properly setup (which the SNES side ROM detail probably means it won't be any time soon). --- emulators/ares.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/emulators/ares.py b/emulators/ares.py index 9ae23e6..3051b0c 100644 --- a/emulators/ares.py +++ b/emulators/ares.py @@ -36,6 +36,8 @@ def setup(self): shutil.copyfile(settings_source, "emu/ares/settings.bml") def startProcess(self, rom, *, model, required_features): + if model == SGB: + return None target = "emu/ares/ares-rom.gb" self.cgb = model == CGB if self.cgb: