Frontend images are broken when using default uploads organized by year and month.

[viruthagiri]

Hello @gabor-udvari

I'm using your fork branch on my site. I'm facing a new problem. The uploads working fine.
As of now my files are organized by month and year.

The problem is when the month changes, old month images are broken. I guess the problem is aux_image function in this file (line number 372 ) https://github.com/gabor-udvari/Magic-Fields-2/blob/fork/mf_front_end.php uses the current upload directory constant to retrieve the image.

I mean in this file https://github.com/gabor-udvari/Magic-Fields-2/blob/fork/mf_constants.php

you used

$mf_ud = wp_upload_dir();

if( mf_mu2() ){
  /* MU path /wp-content/blogs.dir/{id_blog}/files_mf */
  define('MF_FILES_DIR', WP_CONTENT_DIR.DS.'blogs.dir'.DS.$blog_id.DS.MF_FILES_NAME.DS);
  define('MF_FILES_URL', WP_CONTENT_URL.'/blogs.dir/'.$blog_id.'/'.MF_FILES_NAME.'/');

  define('MF_CACHE_DIR', MF_FILES_DIR.MF_CACHE_NAME.DS);
  define('MF_CACHE_URL', MF_FILES_URL.MF_CACHE_NAME.'/');

}else{
  define('MF_FILES_DIR', $mf_ud['path'].DS.MF_FILES_NAME.DS);
  define('MF_FILES_URL', $mf_ud['url'].'/'.MF_FILES_NAME.'/');

  define('MF_CACHE_DIR', MF_FILES_DIR.MF_CACHE_NAME.DS);
  define('MF_CACHE_URL', MF_FILES_URL.MF_CACHE_NAME.'/');
}

But i'm not sure. Can you fix that problem? Thanks

[gabor-udvari]

Hi,

I'll check it this week.

2012-11-01 03:03 keltezéssel, mistergiri írta:

Hello @gabor-udvari https://github.com/gabor-udvari

I'm using your fork branch on my site. I'm facing a new problem. The
uploads working fine.
As of now my files are organized by month and year.

The problem is when the month changes, old month images are broken. I
guess the problem is aux_image function in this file (line number 372
)
https://github.com/gabor-udvari/Magic-Fields-2/blob/fork/mf_front_end.php
uses the current upload directory constant to retrieve the image.

I mean in this file
https://github.com/gabor-udvari/Magic-Fields-2/blob/fork/mf_constants.php

you used

define('MF_FILES_DIR', $mf_ud['path'].DS.MF_FILES_NAME.DS);
define('MF_FILES_URL', $mf_ud['url'].'/'.MF_FILES_NAME.'/');

define('MF_CACHE_DIR', MF_FILES_DIR.MF_CACHE_NAME.DS);
define('MF_CACHE_URL', MF_FILES_URL.MF_CACHE_NAME.'/');```

But i'm not sure since i'm not a php expert. Can you fix that problem?
Thanks

—
Reply to this email directly or view it on GitHub
https://github.com/gabor-udvari/Magic-Fields-2/issues/3.

[viruthagiri]

Ok thanks

[viruthagiri]

@gabor-udvari Its been more than 10 days. Any update?

[gabor-udvari]

For me any thumbnail is broken no matter in month it was uploaded, maybe because there's an another bug, I have to fix that first.

[viruthagiri]

Ok thanks bro, It would be nice if you merge the magic-fields master too.

[gabor-udvari]

A possible fix committed to the 'fork' branch, please test. I'm not sure if it fixes your problem too, but the images are displaying fine for me now.

[viruthagiri]

Hello @gabor-udvari

Still my thumbnails look broken. I've installed "Debug bar" plugin. The plugin says

WARNING: wp-content/plugins/mf/mf_front_end.php:407 - getimagesize(/home/*****/public_html/assets/2012/11/files_mf/1351706606testimage02.jpg) [function.getimagesize]: failed to open stream: No such file or directory

PS: I'm using roots theme. I think its changing the upload folder and its uses relative path for everything. You think that's the problem?

[gabor-udvari]

Thanks, that's a useful information! Seems like the two template functions work differently:

<?php
// this more or less gives back the right path:
echo '<img src="'.get('picture').'">';

// this will always give back the default:
echo get_image('picture');
?>

I think I'll fix this tonight, but if you have time, could you check if get() works in your template?

[viruthagiri]

Hi i'm in a foreach loop. So i'm not sure how to use get inside foreach loop.
This is how my image code looks like within foreach loop

<a href='".$product['products_image'][1]['original']."' class=\"lightbox\"><img alt=\"thumbnail\" src='".$product['products_image'][1]['thumb']."'></a>

[gabor-udvari]

Next version up, please test it. I can't fix this inside the aux_image function because until the image filename gets there it loses a lot of details, so now I'm checking every route which can lead to it. Btw, are you using the image_media field or the image field?

[viruthagiri]

I'm using image field.. Not image media.. I'll test it and let you know.. And one more problem.. I'm still getting cross domain must match javascript issue in the wordpress admin, but not in the front end.. But the weird thing is i'm not using subdomain. I mean i'm not using multisite... Is it because of the roots theme?

[viruthagiri]

Let me test the new version and let you know if i found any bugs.. Thanks