Skip to content

Upgrade Effect to beta.70 and rename Model.Generated to GeneratedByDb#31

Merged
fwal merged 1 commit into
nextfrom
claude/confident-franklin-iR2lL
May 22, 2026
Merged

Upgrade Effect to beta.70 and rename Model.Generated to GeneratedByDb#31
fwal merged 1 commit into
nextfrom
claude/confident-franklin-iR2lL

Conversation

@fwal

@fwal fwal commented May 22, 2026

Copy link
Copy Markdown
Owner

Summary

This PR upgrades the Effect library dependency from beta.43 to beta.70 across all packages and updates the codebase to use the renamed Model.GeneratedByDb API that reflects the new behavior in Effect beta.70.

Key Changes

  • Dependency Upgrade: Updated effect and related packages (@effect/platform-browser, @effect/vitest) from ^4.0.0-beta.43 to ^4.0.0-beta.70 across all package.json files
  • API Migration: Renamed all occurrences of Model.Generated to Model.GeneratedByDb to match the new Effect API naming
  • Behavior Update: Updated documentation and tests to reflect that GeneratedByDb fields are now excluded from both add and update operations (previously required in update)
  • Repository Type Constraint: Removed keyof S['update']['Type'] constraint from the Repository type definition, as generated fields are no longer part of the update schema
  • Test Updates: Removed id field assignments from update/encode test cases where they were previously required
  • Documentation: Updated README.md, MIGRATION.md, and inline documentation to reflect the new GeneratedByDb naming and behavior
  • Code Cleanup: Removed duplicate deleteRecursive method definition in MockFirestoreService

Notable Implementation Details

The change from Model.Generated to Model.GeneratedByDb is more than a rename—it represents a semantic shift in how generated fields are handled. These fields are now completely excluded from update operations, which simplifies the type system and removes the need for the keyof S['update']['Type'] constraint in the Repository type.

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated Effect and related dependencies to v4.0.0-beta.70 across all packages.
  • Documentation

    • Updated migration guides and code examples to reflect changes in database-generated field configuration.

Review Change Stack

- Rename Model.Generated → Model.GeneratedByDb (Effect upstream rename)
- GeneratedByDb no longer includes the id field in the update variant, so
  relax makeRepository's Id type constraint and drop id from update-variant
  encoder tests
- Remove stray duplicate deleteRecursive key in the mock Firestore service
@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8829ac95-3792-4278-96cb-fdfb00f55811

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/confident-franklin-iR2lL

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud

nx-cloud Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 141baf4

Command Status Duration Result
nx affected -t lint test build ✅ Succeeded 1m View ↗

☁️ Nx Cloud last updated this comment at 2026-05-22 11:53:18 UTC

@fwal fwal self-assigned this May 22, 2026
@fwal fwal added this to the 1.0 - Effect v4 milestone May 22, 2026
@fwal fwal marked this pull request as ready for review May 22, 2026 11:54
@fwal fwal merged commit 36a08a4 into next May 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants