Upgrade Effect to beta.70 and rename Model.Generated to GeneratedByDb#31
Conversation
- Rename Model.Generated → Model.GeneratedByDb (Effect upstream rename) - GeneratedByDb no longer includes the id field in the update variant, so relax makeRepository's Id type constraint and drop id from update-variant encoder tests - Remove stray duplicate deleteRecursive key in the mock Firestore service
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 141baf4
☁️ Nx Cloud last updated this comment at |
Summary
This PR upgrades the Effect library dependency from beta.43 to beta.70 across all packages and updates the codebase to use the renamed
Model.GeneratedByDbAPI that reflects the new behavior in Effect beta.70.Key Changes
effectand related packages (@effect/platform-browser,@effect/vitest) from^4.0.0-beta.43to^4.0.0-beta.70across all package.json filesModel.GeneratedtoModel.GeneratedByDbto match the new Effect API namingGeneratedByDbfields are now excluded from bothaddandupdateoperations (previously required inupdate)keyof S['update']['Type']constraint from theRepositorytype definition, as generated fields are no longer part of the update schemaidfield assignments from update/encode test cases where they were previously requiredGeneratedByDbnaming and behaviordeleteRecursivemethod definition in MockFirestoreServiceNotable Implementation Details
The change from
Model.GeneratedtoModel.GeneratedByDbis more than a rename—it represents a semantic shift in how generated fields are handled. These fields are now completely excluded from update operations, which simplifies the type system and removes the need for thekeyof S['update']['Type']constraint in the Repository type.Summary by CodeRabbit
Release Notes
Chores
Documentation